From 823cc89c112d8ac6591b1d2f202d66a8eb26e131 Mon Sep 17 00:00:00 2001 From: Szabolcs David Date: Mon, 12 Dec 2022 18:13:26 +0100 Subject: Do not stop navigation during saving the page if not necessary Calling Stop() interrupts printing, even if there is no page load in progress. Task-number: QTBUG-108154 Change-Id: Ibb8e898c3c7e7ea1933c88aa32d8f96604a6527a Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/470895 Reviewed-by: Allan Sandfeld Jensen --- chromium/content/browser/web_contents/web_contents_impl.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/chromium/content/browser/web_contents/web_contents_impl.cc b/chromium/content/browser/web_contents/web_contents_impl.cc index 52bff701c86..2bb3d014157 100644 --- a/chromium/content/browser/web_contents/web_contents_impl.cc +++ b/chromium/content/browser/web_contents/web_contents_impl.cc @@ -5031,7 +5031,8 @@ void WebContentsImpl::OnSavePage() { return; } - Stop(); + if (IsLoading()) + Stop(); // Create the save package and possibly prompt the user for the name to save // the page as. The user prompt is an asynchronous operation that runs on -- cgit v1.2.1