From d4dae0cad196bcb864975f30198bd0b6d32b3778 Mon Sep 17 00:00:00 2001 From: Danil Somsikov Date: Fri, 20 Jan 2023 17:12:52 +0100 Subject: [Backport] Security bug 1337747 Cherry-pick of patch originally reviewed on https://chromium-review.googlesource.com/c/v8/v8/+/4184203: Fix error dispatch in the v8 inspector session. Bug: chromium:1337747 Change-Id: I920f3c6370ac9f9bc351eff34e46b1e8d520fe3e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4184203 Auto-Submit: Danil Somsikov Commit-Queue: Benedikt Meurer Reviewed-by: Michael Achenbach Reviewed-by: Benedikt Meurer Cr-Commit-Position: refs/heads/main@{#85449} Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/469847 Reviewed-by: Michal Klocek --- chromium/v8/src/inspector/v8-inspector-session-impl.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chromium/v8/src/inspector/v8-inspector-session-impl.cc b/chromium/v8/src/inspector/v8-inspector-session-impl.cc index 8db491bf68a..72bc16ac269 100644 --- a/chromium/v8/src/inspector/v8-inspector-session-impl.cc +++ b/chromium/v8/src/inspector/v8-inspector-session-impl.cc @@ -364,7 +364,7 @@ void V8InspectorSessionImpl::dispatchProtocolMessage(StringView message) { } v8_crdtp::Dispatchable dispatchable(cbor); if (!dispatchable.ok()) { - if (dispatchable.HasCallId()) { + if (!dispatchable.HasCallId()) { m_channel->sendNotification(serializeForFrontend( v8_crdtp::CreateErrorNotification(dispatchable.DispatchError()))); } else { -- cgit v1.2.1