From daa093eea7c773db06799a13bd7e4e2e2a9f8f14 Mon Sep 17 00:00:00 2001 From: Allan Sandfeld Jensen Date: Mon, 20 Nov 2017 15:06:40 +0100 Subject: BASELINE: Update Chromium to 63.0.3239.58 Change-Id: Ia93b322a00ba4dd4004f3bcf1254063ba90e1605 Reviewed-by: Alexandru Croitor --- chromium/styleguide/java/java.md | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'chromium/styleguide/java/java.md') diff --git a/chromium/styleguide/java/java.md b/chromium/styleguide/java/java.md index 76d5f753353..24f98a3b3c1 100644 --- a/chromium/styleguide/java/java.md +++ b/chromium/styleguide/java/java.md @@ -94,7 +94,7 @@ try { somethingThatThrowsIOException(); somethingThatThrowsParseException(); } catch (IOException | ParseException e) { - Log.e(TAG, "Failed to do something with exception: ", e) + Log.e(TAG, "Failed to do something with exception: ", e); } ``` @@ -111,16 +111,15 @@ where C++ DCHECK()s make sense. For multi-statement asserts, use Example assert: ```java -assert someCallWithSideEffects() : "assert description"; +assert someCallWithoutSideEffects() : "assert description"; ``` Example use of `DCHECK_IS_ON`: ```java if (org.chromium.base.BuildConfig.DCHECK_IS_ON) { - if (!someCallWithSideEffects()) { - throw new AssertionError("assert description"); - } + // Any code here will be stripped in Release by ProGuard. + ... } ``` -- cgit v1.2.1