From 445cc7889a6f470daba1a7056ea32bf9faf3e2d9 Mon Sep 17 00:00:00 2001 From: Andrew Grieve Date: Sun, 31 May 2020 22:09:27 -0400 Subject: [PATCH 3/3] Allow access modification everywhere Chrome does not need need -keep to maintain original visibility. Loosening this constraint allows for better optimization, and is easier than adding ",allowaccessmodification" to every single -keep rule. --- .../com/android/tools/r8/shaking/AppInfoWithLiveness.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/main/java/com/android/tools/r8/shaking/AppInfoWithLiveness.java b/src/main/java/com/android/tools/r8/shaking/AppInfoWithLiveness.java index 87bfd9a2d..75bc46e33 100644 --- a/src/main/java/com/android/tools/r8/shaking/AppInfoWithLiveness.java +++ b/src/main/java/com/android/tools/r8/shaking/AppInfoWithLiveness.java @@ -918,9 +918,7 @@ public class AppInfoWithLiveness extends AppInfoWithClassHierarchy public boolean isAccessModificationAllowed(DexReference reference) { assert options().getProguardConfiguration().isAccessModificationAllowed(); - return keepInfo - .getInfo(reference, this) - .isAccessModificationAllowed(options().getProguardConfiguration()); + return true; } public boolean isPinned(DexReference reference) { -- 2.27.0.278.ge193c7cf3a9-goog