1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
|
// Copyright 2020 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/signin/reauth_tab_helper.h"
#include "base/memory/raw_ptr.h"
#include "base/test/mock_callback.h"
#include "chrome/browser/signin/reauth_result.h"
#include "chrome/test/base/chrome_render_view_host_test_harness.h"
#include "content/public/test/navigation_simulator.h"
#include "content/public/test/web_contents_tester.h"
#include "net/base/net_errors.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/blink/public/common/features.h"
namespace signin {
class ReauthTabHelperTest : public ChromeRenderViewHostTestHarness {
public:
ReauthTabHelperTest()
: reauth_url_("https://my-identity_provider.com/reauth") {}
void SetUp() override {
ChromeRenderViewHostTestHarness::SetUp();
ReauthTabHelper::CreateForWebContents(web_contents(), reauth_url(),
mock_callback_.Get());
tab_helper_ = ReauthTabHelper::FromWebContents(web_contents());
}
ReauthTabHelper* tab_helper() { return tab_helper_; }
base::MockOnceCallback<void(signin::ReauthResult)>* mock_callback() {
return &mock_callback_;
}
const GURL& reauth_url() { return reauth_url_; }
private:
raw_ptr<ReauthTabHelper> tab_helper_ = nullptr;
base::MockOnceCallback<void(signin::ReauthResult)> mock_callback_;
const GURL reauth_url_;
};
// Tests a direct call to CompleteReauth().
TEST_F(ReauthTabHelperTest, CompleteReauth) {
signin::ReauthResult result = signin::ReauthResult::kSuccess;
EXPECT_CALL(*mock_callback(), Run(result));
tab_helper()->CompleteReauth(result);
}
// Tests a successful navigation to the reauth URL.
TEST_F(ReauthTabHelperTest, NavigateToReauthURL) {
auto simulator = content::NavigationSimulator::CreateBrowserInitiated(
reauth_url(), web_contents());
simulator->Start();
EXPECT_CALL(*mock_callback(), Run(signin::ReauthResult::kSuccess));
simulator->Commit();
}
// Tests the reauth flow when the reauth URL has query parameters.
TEST_F(ReauthTabHelperTest, NavigateToReauthURLWithQuery) {
auto simulator = content::NavigationSimulator::CreateBrowserInitiated(
reauth_url().Resolve("?rapt=35be36ae"), web_contents());
simulator->Start();
EXPECT_CALL(*mock_callback(), Run(signin::ReauthResult::kSuccess));
simulator->Commit();
}
// Tests the reauth flow with multiple navigations within the same origin.
TEST_F(ReauthTabHelperTest, MultipleNavigationReauth) {
auto simulator = content::NavigationSimulator::CreateBrowserInitiated(
reauth_url(), web_contents());
simulator->Start();
simulator->Redirect(
reauth_url().DeprecatedGetOriginAsURL().Resolve("/login"));
simulator->Commit();
auto simulator2 = content::NavigationSimulator::CreateRendererInitiated(
reauth_url(), main_rfh());
simulator2->Start();
EXPECT_CALL(*mock_callback(), Run(signin::ReauthResult::kSuccess));
simulator2->Commit();
}
// Tests the reauth flow with multiple navigations across two different origins.
// TODO(https://crbug.com/1045515): update this test once navigations outside of
// reauth_url() are blocked.
TEST_F(ReauthTabHelperTest, MultipleNavigationReauthThroughExternalOrigin) {
auto simulator = content::NavigationSimulator::CreateBrowserInitiated(
reauth_url(), web_contents());
simulator->Start();
simulator->Redirect(GURL("https://other-identity-provider.com/login"));
simulator->Commit();
auto simulator2 = content::NavigationSimulator::CreateRendererInitiated(
reauth_url(), main_rfh());
simulator2->Start();
EXPECT_CALL(*mock_callback(), Run(signin::ReauthResult::kSuccess));
simulator2->Commit();
}
// Tests a failed navigation to the reauth URL, followed by a successful
// navigation.
TEST_F(ReauthTabHelperTest, NavigationToReauthURLFailed) {
auto simulator = content::NavigationSimulator::CreateBrowserInitiated(
reauth_url(), web_contents());
simulator->Start();
simulator->Fail(net::ERR_TIMED_OUT);
simulator->CommitErrorPage();
EXPECT_TRUE(tab_helper()->has_last_committed_error_page());
// Check that the navigation still counts as within the same origin.
EXPECT_TRUE(tab_helper()->is_within_reauth_origin());
auto simulator2 = content::NavigationSimulator::CreateRendererInitiated(
reauth_url(), main_rfh());
simulator2->Start();
EXPECT_CALL(*mock_callback(), Run(signin::ReauthResult::kSuccess));
simulator2->Commit();
EXPECT_FALSE(tab_helper()->has_last_committed_error_page());
}
// Tests a failed navigation redirecting to an external origin, followed by a
// successful navigation.
TEST_F(ReauthTabHelperTest, NavigationToExternalOriginFailed) {
auto simulator = content::NavigationSimulator::CreateBrowserInitiated(
reauth_url(), web_contents());
simulator->Start();
simulator->Redirect(GURL("https://other-identity-provider.com/login"));
simulator->Fail(net::ERR_TIMED_OUT);
simulator->CommitErrorPage();
EXPECT_TRUE(tab_helper()->has_last_committed_error_page());
// Check that the navigation doesn't count as within the same origin.
EXPECT_FALSE(tab_helper()->is_within_reauth_origin());
auto simulator2 = content::NavigationSimulator::CreateRendererInitiated(
reauth_url(), main_rfh());
simulator2->Start();
EXPECT_CALL(*mock_callback(), Run(signin::ReauthResult::kSuccess));
simulator2->Commit();
EXPECT_FALSE(tab_helper()->has_last_committed_error_page());
EXPECT_FALSE(tab_helper()->is_within_reauth_origin());
}
// Tests the WebContents deletion.
TEST_F(ReauthTabHelperTest, WebContentsDestroyed) {
EXPECT_CALL(*mock_callback(), Run(signin::ReauthResult::kDismissedByUser));
DeleteContents();
}
class ReauthTabHelperPrerenderTest : public ReauthTabHelperTest {
public:
ReauthTabHelperPrerenderTest() {
feature_list_.InitWithFeatures(
{blink::features::kPrerender2},
// Disable the memory requirement of Prerender2 so the test can run on
// any bot.
{blink::features::kPrerender2MemoryControls});
}
private:
base::test::ScopedFeatureList feature_list_;
};
TEST_F(ReauthTabHelperPrerenderTest,
PrerenderDoesNotAffectLastCommittedErrorPage) {
content::NavigationSimulator::NavigateAndCommitFromBrowser(web_contents(),
reauth_url());
EXPECT_FALSE(tab_helper()->has_last_committed_error_page());
// Fail prerendering navigation.
const GURL prerender_url = reauth_url().Resolve("?prerendering");
auto simulator = content::WebContentsTester::For(web_contents())
->AddPrerenderAndStartNavigation(prerender_url);
simulator->Fail(net::ERR_TIMED_OUT);
simulator->CommitErrorPage();
// has_last_committed_error_page_ is not updated by preredering.
EXPECT_FALSE(tab_helper()->has_last_committed_error_page());
}
} // namespace signin
|
