diff options
| author | Kirill Burtsev <kirill.burtsev@qt.io> | 2020-02-11 19:28:10 +0100 |
|---|---|---|
| committer | Kirill Burtsev <kirill.burtsev@qt.io> | 2020-02-14 16:54:39 +0100 |
| commit | 226fef3dc00874d3c69ac62364518411a95ef4da (patch) | |
| tree | c51130cda0cb3ea4af23a520b25beb71257662ad | |
| parent | bb46f8f9fa6001188049616a9b39e8cccf1b815a (diff) | |
| download | qtwebengine-226fef3dc00874d3c69ac62364518411a95ef4da.tar.gz | |
Emit title change event asynchronously
Ammends 445235bc01. Preserve some previous assumptions on order of
change events for url and title. Fixes flaky failures in previously
written tests like WebEngineViewSource::test_viewSource.
Fixes: QTBUG-81855
Change-Id: I487d27d594d5a0d74d39b7b58e815e5c75a73fb3
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
| -rw-r--r-- | src/core/web_contents_delegate_qt.cpp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/core/web_contents_delegate_qt.cpp b/src/core/web_contents_delegate_qt.cpp index c1cf1f659..7b339776b 100644 --- a/src/core/web_contents_delegate_qt.cpp +++ b/src/core/web_contents_delegate_qt.cpp @@ -199,7 +199,10 @@ void WebContentsDelegateQt::NavigationStateChanged(content::WebContents* source, QString newTitle = toQt(source->GetTitle()); if (m_title != newTitle) { m_title = newTitle; - m_viewClient->titleChanged(m_title); + QTimer::singleShot(0, [delegate = AsWeakPtr(), title = newTitle] () { + if (delegate) + delegate->adapterClient()->titleChanged(title); + }); } } |