summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* Fix build with disabled webengine_extensionsPeter Varga2022-11-244-11/+11
| | | | | | | | | | | | | PDF viewer depends on extensions. Guard these dependencies to make able to build with disabled webengine_extensions and enabled webengine_printing_and_pdf. The PDF Viewer is not expected to work with this configuration but the build should pass and loading a PDF should result a download. Pick-to: 6.4 Change-Id: I4d75e356951c82333ec3dbcd7b6271b9305de3df Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix build with -no-vulkanPeter Varga2022-11-241-0/+5
| | | | | Change-Id: I379f4122521f3b35759c6da6d2291f851941555a Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix Linux build with CMake versions >= 3.25Alexey Edelev2022-11-231-0/+2
| | | | | | | | | | | | The 'LINUX' variable exists in CMake since the version 3.25. This variable previously was undefined while preparsing the configure.cmake files. Since the CMake script that defines the 'check_for_ulimit' function is not included while evaluating configure.cmake first time we need to add a stub. Pick-to: 6.2 6.4 Change-Id: I25bdec4f4a1b6af23174507a8f0f9cbf01f0c398 Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
* Simplify mime-type listAllan Sandfeld Jensen2022-11-231-19/+27
| | | | | | | | | | A complex list of mime-types seems to confuse Discord, and this also lowers our entropy leak. Pick-to: 6.4 Fixes: QTBUG-108265 Change-Id: Ic33d908c4d3c5efe93b086c7b52f39d81a748b32 Reviewed-by: Szabolcs David <davidsz@inf.u-szeged.hu>
* Minor. Remove Override from client certificate storeMichal Klocek2022-11-225-27/+27
| | | | | | | | | Change 'Override" in favor of 'Qt' so it matches the rest of the source base. Pick-to: 6.4 Change-Id: I0ba614ed3017a8d7e0ba5fc703b3f04c28b5ead7 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Return both application and system certificatesAllan Sandfeld Jensen2022-11-226-13/+158
| | | | | | | | | | | | | | | | | | | | | | | | | For the certificate choice return both application and system certificates. Add unit test to cover the case on Linux. Unfortunately it requires adding the user certificate to the nss data store, which is not not nice, however porting the certificate manger from Chromium is a bigger task. Test runs only if the machine has pk12utils installed. During the test the user certificate is imported into the nss database with the nickname 'qwebengineclientcertificatestore'. This can be removed later with: ninja remove-user-personal-certificate and verified with: certutil -d sql:$HOME/.pki/nssdb -L Pick-to: 6.4 Change-Id: I475fddc68ea56304980f6c835ed4cfed4b093ad4 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Add client SSL authentication testMichal Klocek2022-11-2210-6/+200
| | | | | | | | | | | | | | | | Our qwebenginecertificatestore unit test so far only tested adding/removing custom certificates into the memory. However, it never actually initialized certificate store and did not test if ssl certificate client authentication really works. Cover that case and client authentication test. Note ca and client certificates in the test are self signed to be able to run test without network connection, however we ignore the errors. Pick-to: 6.4 Change-Id: I4df4fdfabed5abd8f8bde7d4c0c79b5fd7f6f3a9 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Doc: Emphasize in-memory and system stored client certificatesMichal Klocek2022-11-221-5/+7
| | | | | | | Task-number: QTBUG-106497 Pick-to: 6.4 Change-Id: If03062a5ab6cf5f6d14329637f44b5ea7675f65a Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* Doc: Update the docs related to the FaviconMichal Klocek2022-11-221-6/+23
| | | | | | | Fixes: QTBUG-106501 Pick-to: 6.4 Change-Id: Ib70020d947b3010d22315db3bd32c017e55f71c7 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* Doc: Emphasize QtNetwork is not usedMichal Klocek2022-11-221-0/+3
| | | | | | | Fixes: QTBUG-106510 Pick-to: 6.4 Change-Id: Ib6a63fb5796c437c14ba0885507a3cf6bf9d89f9 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* Doc: Add WebGL featureMichal Klocek2022-11-221-0/+11
| | | | | | | Fixes: QTBUG-106503 Pick-to: 6.4 Change-Id: I280be8707e803b6f01dbdffb76ab9cbce182b7af Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* Doc: Add Local Storage featureMichal Klocek2022-11-181-0/+26
| | | | | | | Fixes: QTBUG-106502 Pick-to: 6.4 Change-Id: I01dcec5e76db7921fc2597e6921e3bc6a6424aa8 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* Doc: Add webengine-spellchecker build switch docsMichal Klocek2022-11-181-0/+9
| | | | | | | Fixes: QTBUG-106500 Pick-to: 6.4 Change-Id: I7a6fabd3526bd2aa164ac992be8cfd145106d7df Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* Doc: Improve html5 geo location docsMichal Klocek2022-11-181-7/+9
| | | | | | | Task-number: QTBUG-106498 Pick-to: 6.4 Change-Id: I7e2b9d6b5cc3a3a9593303684d8f9eaf19f37dc8 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* Doc: Improve QWebEngineClientCertificateStore documentationMichal Klocek2022-11-182-1/+20
| | | | | | | Fixes: QTBUG-106497 Pick-to: 6.4 Change-Id: Ic10d2d54722b071eaacd9f7cb74b08c8ecedcd65 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* Doc: Add hardware acceleration featureMichal Klocek2022-11-181-0/+15
| | | | | | | Fixes: QTBUG-106496 Pick-to: 6.4 Change-Id: Ie1f74d5c9878f6079089007c1cc79a427e85bd70 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* Doc: Fix feature listing order in docsMichal Klocek2022-11-181-63/+64
| | | | | | | | We keep features in alphabetic order. Pick-to: 6.4 Change-Id: I4716f3f71dd16e2f01f5f3ca8650ed3d1c25fe64 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* Minor. Remove unsued qtwebengine_extensions_features.gniMichal Klocek2022-11-171-27/+0
| | | | | | Pick-to: 6.4 Change-Id: I7e2806bfc8367a4137d1e489741ea044376e4203 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Fix probabilistic signature schemeMichal Klocek2022-11-171-2/+2
| | | | | | | | We failed to support pss, which ended up in handshake failures Pick-to: 6.4 Change-Id: I12c50d6a5f2dcf32d47708a958e2fe5a18316986 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Use QSslServer in certificate testMichal Klocek2022-11-173-37/+31
| | | | | | | | | | | | | | | | | We had our own implementation for the HTTPS server. However, the way it worked involved adding for every incoming connection a socket to the list of pending connections, which resulted in unnecessary logging noise due to socket connect/disconnected signals during the SSL handshake negotiations. It also resulted in memory leaks. Since 6.4 we have now QSslServer which adds socket to the pending connection list only after encryption got established. Pick-to: 6.4 Change-Id: I3c8a2a0684e3f0760a56d4b4aaf7b777700e334b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Make client certifcate work without CAMichal Klocek2022-11-171-5/+14
| | | | | | | | | | | | | | | | | | | | Check for expired certificate, they will most likely fail during authentication, so no point of selecting them. According to rfc5246 certificate authorities list in certificate request can be empty. "If the certificate_authorities list is empty, then the client MAY send any certificate of the appropriat ClientCertificateType, unless there is some external arrangement to the contrary." https://datatracker.ietf.org/doc/html/rfc5246#section-7.4.4 Support empty CA list. Pick-to: 6.4 Change-Id: I0ae3cbd7b0cd13ef943b431c81c3edea5ae9162d Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Update dependencies on 'dev' in qt/qtwebengineQt Submodule Update Bot2022-11-171-4/+4
| | | | | Change-Id: Ib3f6e1b961195e884e1704246f4bad15f7617155 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Update dependencies on 'dev' in qt/qtwebengineQt Submodule Update Bot2022-11-161-4/+4
| | | | | Change-Id: I6f53762226885d841e44fc21131573e3ffa3c3af Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Update dependencies on 'dev' in qt/qtwebengineQt Submodule Update Bot2022-11-141-4/+4
| | | | | Change-Id: I8d7162930b278d175b22d4b9eaefc59b1b2c49f2 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Monthly re-run of clang-tidy qt-* checks (11/2022)Marc Mutz2022-11-111-21/+21
| | | | | Change-Id: Ife7ebf1bf0b1db867e0ea195d9a8a3b4abd9a1b7 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add Vulkan rendering supportPeter Varga2022-11-1018-31/+681
| | | | | | | | | | Updates 3rdparty: * 8b7ce4ef70d Make GrVkImage external Task-number: QTBUG-107669 Change-Id: If7fbe1f20538598dd1d4f3a67be17c9f7d06a3cd Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update dependencies on 'dev' in qt/qtwebengineQt Submodule Update Bot2022-11-091-4/+4
| | | | | Change-Id: I8190eee64d624ec6706d6fbb2b87f9540593d686 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Update dependencies on 'dev' in qt/qtwebengineQt Submodule Update Bot2022-11-081-4/+4
| | | | | Change-Id: I01cb3e7035f3c0614762e8174df18e28555efda0 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Update dependencies on 'dev' in qt/qtwebengineQt Submodule Update Bot2022-11-031-4/+4
| | | | | Change-Id: Ifec022c0ddfc505d7ef90c39d034e79d329bd9e2 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Update ChromiumMichael Brüning2022-11-033-2/+2
| | | | | | | | | | Sumbmodule src/3rdparty 24df9c9b..9457651e: > [Backport] CVE-2022-3723: Type Confusion in V8 Task-number: QTBUG-108106 Change-Id: Ic6ae78e84df7198e5729f1377b60d774e1b1e5fa Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Mention WebSockets in docsSzabolcs David2022-11-033-0/+20
| | | | | | | | | | | | | | | | QtWebChannel has an example for a use case of HTML web sockets and connectivity of the native side of application. We don't need to create a new example of our own by mentioning this. However, the chat client application uses JS libraries served from remote, so we have to enable LocalContentCanAccessRemoteUrls setting to make it work out of the box in WebEngine example browsers. Desktop Chrome works the same way by default. Task-number: QTBUG-106505 Change-Id: I9020d0a09a88de16d32af063aee5d55c9837f484 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Doc: Normalize page namesKai Köhne2022-11-021-1/+1
| | | | | | | | | | | | | | qdoc does enforce lowercase file names for .html pages, and also replaces underscore with a dash. Make sure that the original \page name already is normalized, so that it's easier to search. This was done by find . -name "*.qdoc" -exec perl -p -i -E "s/\\\page (.*)/\\\page \L\1/ && s/_/-/g" {} ; Change-Id: I15ee29a8c1f41074671bcd1b4d67810ab0670255 Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Luca Di Sera <luca.disera@qt.io> Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
* Silence synqt.cpp warnings-turned-errorsMarc Mutz2022-11-021-0/+4
| | | | | | | | | | Says syncqt.cpp: ERROR: [...]/render_widget_host_view_qt_delegate_quickwindow.h does not include QT_BEGIN_NAMESPACE Pick-to: 6.4 6.2 Change-Id: I4109c493bbf25a6f7c65e35e9c697f15c7f0ac3f Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Enable syncqt cppAlexey Edelev2022-11-011-0/+2
| | | | | | Change-Id: I7570ea4200c479fe38073719568b6ffa8c880a25 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Update dependencies on 'dev' in qt/qtwebengineQt Submodule Update Bot2022-11-011-4/+4
| | | | | Change-Id: Ie56505252b374de2d97bc01866c670ca64616d65 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Require minimum msvc version 14.29Michal Klocek2022-11-011-0/+7
| | | | | | | | | | Instead of fixing the code to compile with lower version, simply require at least version present on ci. Fixes: QTBUG-108029 Pick-to: 6.4 Change-Id: Ie6fbd7c3451a39c09dfb15e0cf9850672c9d4ea8 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Update ChromiumMichael Brüning2022-10-311-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Submodule src/3rdparty 546d8e05..24df9c9b: > [Backport] Security bug 1361627 > [Backport] Security bug 1361612 > [Backport] Security bug 1373314 > [Backport] CVE-2022-3661: Insufficient data validation in Extensions > [Backport] Security bug 1356234 > [Backport] CVE-2022-3656: Insufficient data validation in File System > [Backport] CVE-2022-3653: Heap buffer overflow in Vulkan > [Backport] CVE-2022-3654: Use after free in Layout > [Backport] CVE-2022-3652: Type Confusion in V8 > [Backport] CVE-2022-3445: Use after free in Skia > [Backport] CVE-2022-3450: Use after free in Peer Connection > [Backport] CVE-2022-3446 and CVE-2022-35737 > Reland two changes for establishing gpu channel > FIXUP: Stop using C++20 initialization > FIXUP: Legalize the bloody code > [Backport] CVE-2022-3308: Insufficient policy enforcement in Developer Tools (2/2) > [Backport] CVE-2022-3308: Insufficient policy enforcement in Developer Tools (1/2) > [Backport] Security bug 1360936 > [Backport] CVE-2022-3313: Incorrect security UI in Full Screen > [Backport] CVE-2022-3307: Use after free in Media. > [Backport] CVE-2022-3315: Type confusion in Blink > [Backport] CVE-2022-3201: Insufficient validation of untrusted input in Developer Tools (2/2) > [Backport] CVE-2022-3201: Insufficient validation of untrusted input in Developer Tools (1/2) > [Backport] CVE-2022-3304: Use after free in CSS > [Backport] CVE-2022-3373: Out of bounds write in V8 > [Backport] Security bug 1356308 > [Backport] CVE-2022-3370: Use after free in Custom Elements > [Backport] Security bug 1348283 > [Backport] Security bugs 1346938 and 1338114 > [Backport] CVE-2022-3200: Heap buffer overflow in Internals Pick-to: 6.4 Fixes: QTBUG-108104 Fixes: QTBUG-108105 Task-number: QTBUG-108106 Change-Id: I2766eec4f7d16b286e3b1ab6be07e9872cc52c19 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix compilation 6.3 against 6.4Michal Klocek2022-10-311-1/+7
| | | | | | | | | | Check if type registrations should be in Qt namespace. This amends 5208245d2ccabbc07ecf6b845cfa3d971d2ed7e5. Pick-to: 6.4 Change-Id: I3f349a4aedac4410b1a581264d1e8877ba0bcf44 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Blacklist certificate test and unblock integrationsMichal Klocek2022-10-311-0/+2
| | | | | | | | Certificate for revoked.badssl.com expired on 10/28/2022. Pick-to: 6.4 Change-Id: I06022bea1404bf5134f815067dcd2713790e5a23 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update dependencies on 'dev' in qt/qtwebengineQt Submodule Update Bot2022-10-261-4/+4
| | | | | Change-Id: I42f309a7acfb089798525b587831018aeb272ed4 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Fix inputFieldOverridesShortcuts unit testMichal Klocek2022-10-261-1/+1
| | | | | | | | | | | Since a818d49aa58c7ff871f89f7db4b1234402092994 in qtdeclarative we should explicitly ignore the event. Fixes: QTBUG-108008 Pick-to: 6.4 Change-Id: I1b9beabb39e19df8af86b8cadaafb21eef9dc4a8 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Various clean-ups in core/rendererPeter Varga2022-10-2015-76/+53
| | | | | Change-Id: I21fbbc639d6d321913b12ed856d98fdfa2d8f474 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Speculative fix for MSVCAllan Sandfeld Jensen2022-10-201-6/+0
| | | | | | | | | | Remove special code for MSVC, as it now produces warnings. Task-number: QTBUG-107778 Change-Id: I2b821693cb00ec5d1efc3cd7ed3a545e47a2b9d3 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Update dependencies on 'dev' in qt/qtwebengineQt Submodule Update Bot2022-10-201-4/+4
| | | | | Change-Id: Ie2d7b4c1ea62fe5600c498dfe9f536f84b87c7a5 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Fix build with disabled spellcheckerPeter Varga2022-10-181-1/+2
| | | | | | Change-Id: Ia85cbfb7def14710ed217feab0fa51f3230d4dd2 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Szabolcs David <davidsz@inf.u-szeged.hu>
* Only warn the user about conditions that are not metMichael Brüning2022-10-181-1/+4
| | | | | | | | | | | | | | | When loaded from a plugin, we printed a warning about setting the application attribute Qt::AA_ShareOpenGLContexts and choosing OpenGLRhi as the scene graph renderer interface even when those conditions were already met. This patch checks if these conditions are already met before printing the warning. Change-Id: Iee06fa4560e022f0611f07a082513dc91c8065c9 Pick-to: 6.4 6.3 Fixes: QTBUG-103958 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix bogus layouting of qwebengineviewMichal Klocek2022-10-171-4/+12
| | | | | | | | | | | | | | | | | | | | | | | | We did not really change pointers for doing a widget and a item delegate binding. This at some point was blowing up as we did not remove the old widget before inserting the new widget into the internal webengineview layout. The issue could get unnoticed for a while as the old widget got eventually removed on a destruction. However, at times when on the qlayout activation call the old widget was considered, resize event was triggered which was setting viewport to false value (minimum size to hold two webcontents). Make sure we remove widget before adding the new widget. This fixes the widget and the item bind, however this logic should be rewritten for dev branch as is get more and more complex. Fixes: QTBUG-107529 Pick-to: 6.4 Change-Id: I31d180b54f52e38b3c335cfa2bf3afa61e449677 Reviewed-by: Martin Negyokru <negyokru@inf.u-szeged.hu> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix fullscreen request blocking after running fileChooserMartin Negyokru2022-10-141-0/+4
| | | | | | | | | | | Chromium blocks fullscreen requests while the fileSelectListener is alive. Release it manually after the accept/reject signal. Fixes: QTBUG-106975 Pick-to: 6.3 6.4 Change-Id: Iac4868b8ab0268b8ddb94912286155af73ebd343 Reviewed-by: Szabolcs David <davidsz@inf.u-szeged.hu> Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Add devtools file system supportMartin Negyokru2022-10-145-11/+193
| | | | | | | | | | Use Chrome's DevToolsFileHelper implementation. Enable downloading contents from devtools. Enable editing and saving files with devtools workspace. Task-number: QTBUG-85171 Change-Id: I987c667a59c12792c35a802326596e5799f42290 Reviewed-by: Szabolcs David <davidsz@inf.u-szeged.hu>
* Fix GCC compiler warnings in auto testsPeter Varga2022-10-133-9/+13
| | | | | | Pick-to: 6.4 Change-Id: I9daae92749e7dbe0580c17e8f0325e2199b2ed17 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>