| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Change-Id: I81545b00dbfc94949dd5d8b2252c2230ca5d2601
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
|
|
|
|
|
|
| |
Make QtWebEngine 5.6 buildable as an upgrade to Qt 5.5
Change-Id: Ic5de7fc414374d8492434dd5b956cbb90fff2e3e
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Most page-state is set in webcontentsadapter::initialize except user
scripts and webchannel. This patch ensures those are initialized too
when changing to a new adapter during history restore.
Change-Id: I4dca23ddab50480b1a72252a038834ce1802ad77
Task-number: QTBUG-50751
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
Reviewed-by: David Rosca <nowrep@gmail.com>
|
|
|
|
|
|
|
|
|
| |
The default implementation of QWebEngineView::createWindow returns a
null pointer. Add missing null pointer check in adoptNewWindow.
Change-Id: Ia6138f372ff169b9d32764b15550939adc247a1c
Task-number: QTBUG-50718
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
|
|
|
|
|
|
|
|
| |
Use this signal to notify the user on JavaScript window move/resize
requests. It works only for windows opened by JavaScript (according to
the Chromium browser's behavior).
Change-Id: I7fdeda4c252cc4badb36b74ed61d947be690f45a
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
|\
| |
| |
| | |
Change-Id: I591be7a7131d85a269bf12fbd5c47a0ccf6ce574
|
| |
| |
| |
| |
| |
| |
| | |
This amends commit 3b4eec9b.
Change-Id: I19e8a295fa7e64ff83c26b6965097bd0ae3cbf73
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
|\ \
| |/
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
src/3rdparty
src/webenginewidgets/api/qwebenginepage.cpp
src/webenginewidgets/api/qwebenginepage_p.h
Change-Id: I050b4c7691a070e04cace2663ad633903f6d96a9
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When opening a new tab by middle clicking on a link in a web page, two
MouseMove events are sent to Chromium consecutively, without getting
proper acknowledgment events, which causes further move events not
to be handled properly.
Fix consists in preventing the second move event from being sent.
Change-Id: Ia0a64698476226e472faa53f75b51dfb6ed477c9
Task-number: QTBUG-50031
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
This means QtWebEngineWidgets no longer needs to depend on and link
to the QML API.
Change-Id: If59693bf0ae1fb43dc86c141daf4e09c8cc68c25
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
An application currently have to rely on suggested filename only to
guess the type of a download. This is often insufficient when the suffix
is misleading or missing.
This patch adds the mimetype to the reported metadata and also adds
a mimetype appropriate suffix to suggested filenames.
Task-number: QTBUG-48206
Change-Id: I4c70f076d6eb5ae820fd6b7f568515eeb7c18df5
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
| |
| |
| |
| |
| | |
Change-Id: I8f9a4c5c155a65ede24908799218fd867db0767c
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Make the signal distinct from the QObject destroyed signal and make sure
it is not documented and follows private signal naming.
Change-Id: If10a6e7fcee5e9ea4d3ed12ddb8e6ff3f1170adc
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
| |
| |
| |
| |
| | |
Change-Id: Ie8c6e4d9887d5169037e580db8a91c102009df5e
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
This makes the enum values available as strings in qDebug,
QCOMPARE and such.
Change-Id: Id57a2002451337fcc8aedac673f834445913895c
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Let QWebEngineFullScreenRequest be logically const-correct. It feels
weird to be allowed to call "accept()" or "reject()" on a constant
object.
Also allow the user to copy the request, but check whether the
page is still valid in the implementations of accept(), reject().
Change-Id: Ibf139a126734fc8e2db68ec26dc8f24cd4438942
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Change the behavior of QWebEnginePage/WebEngineView
to print JavaScript console.warn and console.error messages
by default in a 'js' logging category. This matches also
the behavior for QtQml, where console messages end up in
a 'qml' logging category by default.
So far access to the JavaScript console required either use
of the remote debugging functionality, subclassing of
QWebEnginePage, or implementing a custom handler.
Anyhow, even then writing a seamless forwarding of
the data and metadata to the Qt message handler is
difficult. This patches implements this forwarding by
default.
The behavior can be changed by either setting up rules
for the 'js' category, e.g.
setFilterRules("js.*=false");
or by implementing onJavaScriptConsoleMessage(),
or overriding QWebEnginePage::javaScriptConsoleMessage.
[ChangeLog] Unhandled JS console messages are now
forwarded to to the Qt message handler inside a 'js'
category.
Change-Id: I5480383a80dcf7a122496f9b7915264ef9036db3
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Forward WebEngineView visibility to WebContents visibility, and call
WebContentsView visibiliy on actual show/hide events to avoid a recursion
when WebContents visbility triggers it.
Change-Id: I0c336359fb35bf93874aa1092767177d7a5ce341
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
| |
| |
| |
| |
| | |
Change-Id: I9274a3cacaa04529152a5d827c47cf6fc831df19
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
|\ \
| |/
| |
| | |
Change-Id: Ibc8ec5ab77ef27bede6e4af1e6318378ac6b9899
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When an event filter is installed on the view, the right
mouse click event may trigger Chromium to request a context
menu even though the context menu events get filtered out.
Removes a Q_ASSERT that would now never be triggered.
Change-Id: I3ff496ec4e4ecbb4faa107f7e221765918c5fa06
Task-number: QTBUG-49092
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| | |
Change-Id: I937ce0daf2fa73d7179a5f62585abfb1acea7264
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
|
|\ \
| |/
| |
| |
| |
| |
| | |
Conflicts:
src/3rdparty
Change-Id: I49acdd9b5ca94f2807b0c13a97f508a67f1c5750
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The API had no way of setting off-the-record, because the constructor
meant for it set it to false. The patch fixes the constructor and
adds basic API tests for the QWebEngineProfiles.
Change-Id: I407eb4a4b0524b6c4eb944d17d744620dd9db6fb
Task-number: QTBUG-48724
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We can not add a new virtual method without breaking ABI on some
platforms, instead we need to use a setter.
The API now uses a request object, and a separate signal for canceling,
since canceling can not be rejected.
Change-Id: If8069c343e86926293c30e8de179bf4e3cbd5886
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The class has only setters and getters, except for the virtual
acceptCookie method. By replacing this method with a setCookieFilter
callback we can avoid the need of users to subclass the client.
Change-Id: Id78c01fc103b8d9cc267594527239b598e8975f1
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Remove the scheme from the url scheme handler constructor, this way
the same handler can handle multiple schemes, the API look more natural
and we can get rid of the private class.
Change-Id: I33906b8a5ea51641e28a53f93f4feb1472c24baf
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Web pages can set the onbeforeunload handler to let the user confirm
whether to leave the page or not. Until now, only when leaving the
page via a link, a confirmation was shown.
Before actually closing a web page, applications can now trigger
the RequestClose web action. This will give the use the chance to
confirm or deny the close request.
If the request is confirmed, the signal windowCloseRequested is
emitted.
Task-number: QTBUG-36155
Change-Id: Icc1fabc37a2ac537f674c2f00bc8966e4dc4e610
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| |
| |
| |
| |
| | |
Change-Id: I1040dab62b7c795dbaf3899304501917993b06d6
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
| |
| |
| |
| |
| | |
Change-Id: I055467595e6c922bc95fabf63555c7225de6d626
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
With QWebEngineSchemeHandler in QtWebEngineCore, we do not need the
indirection and delegation CustomUrlSchemeHandler provided. This
means the class can be removed and we can also store the handlers
directly in BrowserContextAdapter and save a copy of the installed
handlers in the QWebEngineProfile.
Change-Id: Iabb5cc9d364c2f2a879bc77bfb2ff14b3c2ff640
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When the QObject::destroyed signal is emitted the inherited class parts
have already been destroyed and thus it is no longer a
QWebEngineUrlSchemeHandler and qobject_cast will return 0, which is
asserted against.
Change-Id: I7130c60a26088067930499a30e0081ed297a92d9
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This fixes the assertion that occurs when the application should
show "Are you sure you want to leave this page?" dialog. We can
reuse the already existing confirm dialog implementations.
Change-Id: I22466d450f39b54d9becbb69e1ecadb3b98697b0
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
|\ \
| |/
| |
| | |
Change-Id: Ice3d6e88238940a62d75e7c67f63b626285fccb0
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We need to fully qualify enum parameters in signals/slots for the
meta-object system. Otherwise the old QObject connection syntax will
not work.
Task-number: QTBUG-48309
Change-Id: I7a99d8a924ed3566c410c1c0ee7392e863fb2030
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
|
| |
| |
| |
| |
| |
| | |
Change-Id: Id52add61d11723e8bb12957af2f319a7d85bc69c
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
Reviewed-by: Topi Reiniö <topi.reinio@digia.com>
|
| |
| |
| |
| |
| | |
Change-Id: I5db2aebf3cd300344bdafe8bba4169d54a0f3c24
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- Add missing documentation
- Edit for grammar and style
- Fix links
Change-Id: I9e8387fa08f8e7e73c636a516b1f87eb10973e73
Reviewed-by: Florian Bruhin <qt-project.org@the-compiler.org>
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
|
| |
| |
| |
| |
| | |
Change-Id: Ia7b160444a6c8902c6174d9859b3989a9442bc2e
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This allows users to implement a "sad tab" feature and/or track
rendering process crashes using a crash reporting service.
Task-number: QTBUG-48227
Change-Id: I97ef934fe5d0912cd0f41967a39052316b3c66b0
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| |
| |
| |
| |
| |
| | |
Change-Id: I522918064ef8139eff4efa0461030baeb7083b76
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
We should use a consistent naming format for the three download/save
web actions.
Change-Id: I54fabc88a7adbbf7d4f861b8ddde851ebf4ec872
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
|\ \
| |/
| |
| | |
Change-Id: Idafba4d47393638cfc72fd02be092b67bb8cbd8c
|
| |
| |
| |
| |
| |
| |
| |
| | |
Use same wording as for the QML type, where
appropriate.
Change-Id: Idb10f054f334056713bf902c68e567c70fe150f2
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| |
| |
| |
| |
| | |
Change-Id: I147f7e3da41804f7b28e08647a0b6d1756394e4f
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
... and the corresponding QQuickWebEngineSettings docs
- Add missing documentation
- Remove references to obsolete classes
- Edit for grammar and style
Change-Id: I368fff274609941d6435ddf3343b81bca6013945
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The new controller makes possible to handle authentication requests
asynchronously. This is essential for the authentication support in the
QtQuick API.
Change-Id: Ib60b58448a60e817e64477529ec4bfd1535b3d19
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Empty user and password fields are valid for HTTP and proxy
authentication. Thus it does not mean that the authentication
is cancelled. For informing the engine about the cancellation
of the authentication dialog make QAuthenticator instance null.
Change-Id: Iba1ce9d375b9b37c23f7a91fb583606d75d04af5
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Adds inspect element to the context menu when there is an attached
inspector on the page.
Change-Id: Id3c8a5be34318c12ab331b6611219bd59b7b70be
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Makes the custom URL scheme handler API public, and moves it to core
so that it may be shared with the QQuickWebEngine API.
Change-Id: I745cb088df6f4cd11b1ac7c8c3c76f112032cb38
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|