summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
...
* Guard against favicon provider being removed before ViewKirill Burtsev2022-01-281-1/+1
| | | | | | | | | | | Avoid using dangling pointer on view's destruction in case favicon provider was removed first by QML engine. Just use a QPointer since it's not used for anything much else internally in a WebEngineView. Pick-to: 6.2 6.3 Fixes: QTBUG-100032 Change-Id: I0560798a02bed02b0aabee61e1b0ae41a6e87d8a Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Use IsSameDocument() rather than IsLoadingToDifferentDocument()Benjamin Terrier2022-01-271-1/+1
| | | | | | | | | | | | | For certain types of redirect navigations (for example, with a non-default useragent set) 'IsLoadingToDifferentDocument()' can be unexpectedly false. In such cases 'navigation_handle->IsSameDocument()' also returns false. Fixes: QTBUG-94924 Pick-to: 6.3 6.2 5.15 Change-Id: Ie2c17127e1a00ffc515829526320ba2f71d45af5 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* QtPdf: Use QML_NAMED_ELEMENT and auto-generated pluginShawn Rutledge2022-01-268-132/+74
| | | | | | | | So we need to move the qmlmodule doc block to a qdoc file, now that there's no plugin.cpp. Change-Id: I2426ad12647ed65acc9f2e0c252b3b1af715d931 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* webenginequick: Avoid deprecated QQmlListReference ctorFabian Kosmale2022-01-262-3/+4
| | | | | | | | | This doesn't modify the signature of appendExtraItems (which no longer requires the engine pointer) to keep the change minimal. Pick-to: 6.3 Change-Id: I2a649cd8d8e68c4c6e1a607d881f9180ac931032 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Go back to using pointer handlers in Pdf(Multi)PageViewShawn Rutledge2022-01-202-18/+16
| | | | | | | | | | This reverts commit 1f785521ab6982e7395af223e28137d65f8ead12. As a drive-by, also stop using import version numbers in PdfPageView, and make document a required property. Change-Id: I23b4a369b8d5e213c4569de3cecade5000e320c8 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
* Widgets: Add FileSelectionMode::FileSelectSaveSzabolcs David2022-01-193-0/+4
| | | | | | | | | Now we have an example to trigger this type of dialog, we can expose this as public API. Pick-to: 6.3 Change-Id: If0964d07a532daaff5e798dac63dc02ec7781d4d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* QtPdf: remove TableViewExtraShawn Rutledge2022-01-195-208/+17
| | | | | | | | | | | 9e3c27595113dd07ad936e73696aee62db4c6f3f was a temporary solution to work around missing TableView features in Qt 5. Drive-by: remove import versions and use required property in PdfMultiPageView, since we're touching it anyway. Change-Id: I0b1f83b865671f6ea9f14bbf70d7e3972e20e354 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
* Add xkbfile to pkgconfigAllan Sandfeld Jensen2022-01-191-4/+3
| | | | | | | | | To get the correct includes if they are less standard Pick-to: 6.3 6.2 Fixes: QTBUG-99890 Change-Id: Ibd751d46dce7e00e4ce8433549e778d4814dae30 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Find GIO like qtbase doesAllan Sandfeld Jensen2022-01-191-2/+2
| | | | | | | | | | | Otherwise it can conflict and cause issue on reconfigure Change-Id: I3e7756b4720bc5a1e82ef0f327b8c9dbc76667ec Pick-to: 6.3 6.2 Fixes: QTBUG-99669 Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
* Doc: Fix find_package() call for Qt PDFKai Köhne2022-01-161-2/+2
| | | | | | Pick-to: 6.3 6.2 Change-Id: Id19aa463db605c861a1bd3502eb964c8f9340e4d Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix not working web ui popup (html comboboxes) due to focus out eventsMichal Klocek2022-01-131-1/+6
| | | | | | | | | | | | | | | | | | | | | | Recent change in qtdeclarative 42d411e2e8 causes a focus out event being delivered in case of popups to "root" item of quickwidget. This is not expected as events are forwarded to parent "view" and loosing a focus will hint Blink to trigger a pop up close request. As a communication with a render process is asynchronous this creates several race conditions in our tests and the Blink's popup close request can close unexpectedly windows creating dangling pointers. Moreover, the focus in never gained back leaving the Blink's logic in a limbo state. Simply ignore a focus out event in case of popups. Fixes: QTBUG-99215 Pick-to: 6.3 6.2 6.2.3 Change-Id: I5ca6eda227101d4f19f15735e41f066cfd8ccea0 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Minor. Fix cmake warningMichal Klocek2022-01-121-1/+1
| | | | | | Pick-to: 6.3 Change-Id: I940db4bc953db9e571370886f142387dce5f12bb Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Do not override signal handlersAllan Sandfeld Jensen2022-01-121-0/+1
| | | | | | | | | We used to have this, but it got dropped at some point in an adaptions. Pick-to: 6.3 6.2 6.2.3 5.15 Fixes: QTBUG-99263 Change-Id: I3bf86a1b42edca0cd792723c85d7dcb7877fea37 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Clean up devtools frontend implementationAllan Sandfeld Jensen2022-01-132-56/+53
| | | | | | | Following new code style Change-Id: If638675b5509a633977cd8f8164ac044e9d5a959 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Fix printing PDF filesSzabolcs David2022-01-123-10/+37
| | | | | | | | | | | Delegate printing task down to the guest WebContents if any is present. Also update PrintWebViewHelperDelegateQt to find the plugin element properly for printing. Task-number: QTBUG-98941 Pick-to: 6.3 6.2 6.2.3 5.15 Change-Id: I81004a2275e0870a17565af527b1450472afb24b Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Update ChromiumAllan Sandfeld Jensen2022-01-121-0/+0
| | | | | | | | | | | Submodule src/3rdparty 2335554cb..dd2725bea: > Do not overwrite signal handlers in the browser process. > Quiet false error message > FIXUP: Stop using C++20 initialization Pick-to: 6.3 Change-Id: I1d284f43d5042d094736b89385c638089b9c8c2f Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Un-export the value classesMarc Mutz2022-01-094-30/+34
| | | | | | | | | | | | | Value classes should not be exported wholesale, because that makes inline function part of the ABI on Windows debug builds, severely restricting what we can do to them going forward (e.g. removing). De-inline the QPdfSearchResult dtor as a drive-by. Fixes: QTBUG-98885 Pick-to: 6.3 Change-Id: If2a2c7bec2b99df7e33dfc008fd07e6edda5413c Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* Add objectName to webengine accessibility objectsAllan Sandfeld Jensen2022-01-074-19/+42
| | | | | | | | | This requires adding a QObject to represent the backing node. Pick-to: 6.3 Fixes: QTBUG-99485 Change-Id: I4d8c722a0dfb1f374995f3feab23b93ed5d8752a Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Fix inspector overlayAllan Sandfeld Jensen2022-01-061-0/+2
| | | | | | | | | Was missing resources that had moved Pick-to: 6.3 6.2 Fixes: QTBUG-99526 Change-Id: I68b05b9de3dbd6c6460e5495a939e2599623a047 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Always generate printing buildflagsAllan Sandfeld Jensen2022-01-051-3/+1
| | | | | | | | | We include them unconditionally Pick-to: 6.3 6.2 Fixes: QTBUG-99511 Change-Id: I4d9ebbf5777099ade38740ceb41532f0088df4c0 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Update SG backend codeAllan Sandfeld Jensen2022-01-041-53/+21
| | | | | | | | Correct the debug output and remove references to dead code like ANGLE. Pick-to: 6.3 Change-Id: I261ecf23a200c4328ea79514f7f75fce991960f5 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Cleanup code and clang build warningsKirill Burtsev2022-01-0216-62/+18
| | | | | | | | | Fix build noise as reported by clang for issues like api deprecation, unused variables, sign/unsigned mismatch and other non critical issues. Pick-to: 6.2 Change-Id: I4fba25406eea8170e3283c42e908ae86bd512e3a Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix crash on meet.google.comSzabolcs David2021-12-301-1/+7
| | | | | | | | | | Hangout Services extension has a background WebContents. Do not try to access its delegate and settings. Pick-to: 6.3 Task-number: QTBUG-99119 Change-Id: Ib46867ba98644e14af6263253daa253ef2e6b12a Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* FIXUP: Add onTouchSelectionMenuRequested QML handlerBalazs Egedi2021-12-234-4/+22
| | | | | | | | Fixed CodeChecker warnings, added missing documentation. Pick-to: 6.3 Change-Id: I723ea2b0952ded52f513a3cd53ac443b727f1e58 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix headers in GN sourcesAllan Sandfeld Jensen2021-12-211-4/+2
| | | | | | Pick-to: 6.3 6.2 Change-Id: Ib2faa3e0242799e1088d4ec7c610fa89a4d15bbb Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Update ChromiumMichael Brüning2021-12-181-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Submodule src/3rdparty 735b1a39..2335554c: > [Backport] Security bug 1259899 > [Backport] CVE-2021-4057: Use after free in file API > [Backport] CVE-2021-4078: Type confusion in V8 > [Backport] CVE-2021-4059: Insufficient data validation in loader > [Backport] CVE-2021-4062: Heap buffer overflow in BFCache > Fix crashes with MSVC > Bundle all localisation files for DevTools > Speculative fixes for build race conditions > Allow DevTools to download remote translations > FIXUP: Fix disabling reporting > Use wglSetPixelFormat directly only if in software mode > Fix jumbo build: syntax error in v8 token.h(211) > [Backport] CVE-2021-38017: Insufficient policy enforcement in iframe sandbox > [Backport] CVE-2021-37987 : Use after free in Network APIs > [Backport] CVE-2021-38015: Inappropriate implementation in input > [Backport] CVE-2021-38018: Inappropriate implementation in navigation > [Backport] CVE-2021-38021: Inappropriate implementation in referrer > [Backport] CVE-2021-38005: Use after free in loader (3/3) > [Backport] CVE-2021-38005: Use after free in loader (2/3) > [Backport] CVE-2021-38005: Use after free in loader (1/3) > [Backport] CVE-2021-38019: Insufficient policy enforcement in CORS > [Backport] CVE-2021-38007: Type Confusion in V8 > [Backport] CVE-2021-38009: Inappropriate implementation in cache > [Backport] Dependency for CVE-2021-38009 > [Backport] CVE-2021-38012: Type Confusion in V8 > [Backport] CVE-2021-38010: Inappropriate implementation in service workers > [Backport] Security bug 1252858 > [Backport] Security bug 1241912 > [Backport] CVE-2021-37994 : Inappropriate implementation in iFrame Sandbox > [Backport] Dependency for CVE-2021-37994 > [Backport] CVE-2021-37996 : Insufficient validation of untrusted input in Downloads > [Backport] CVE-2021-37989 : Inappropriate implementation in Blink > [Backport] CVE-2021-37985 : Use after free in V8 > [Backport] Security bug 1245870 > [Backport] CVE-2021-37992 : Out of bounds read in WebAudio > [Backport] CVE-2021-37993 : Use after free in PDF Accessibility Task-number: QTBUG-95568 Task-number: QTBUG-99099 Fixes: QTBUG-99282 Fixes: QTBUG-99285 Change-Id: I0b5d1fff98e1c83458a99d4badf40b7ef49cc660 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* QPdf namespace: export the staticMetaObjectMarc Mutz2021-12-131-1/+2
| | | | | | | | Otherwise users outside the module can't access it. Fixes: QTBUG-99144 Change-Id: I8348f64bca9a4cd9bcdbddb8fbfd7554c29f5357 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* Adopt modern QESDP usageAllan Sandfeld Jensen2021-12-094-40/+14
| | | | | | Change-Id: I654c07c3b9925977dd85821a36fd6f8130556cac Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Marc Mutz <marc.mutz@qt.io>
* QPdfSearchResult: std::move ctor argumentsMarc Mutz2021-12-082-5/+10
| | | | | | | | | | The ctor is a perfect sink for the arguments, and already took them by value. What was missing was to std::move them into place instead of using the copy ctor. Change-Id: I3a708bea2cdd8417ea3e604af2850d99a5966c3f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
* Replace GeolocationSystemPermissionManager with GeolocationManager after 94 ↵Peter Varga2021-12-084-17/+19
| | | | | | | | | | | | | adaptations This is necessary to fix crash with disabled geolocation on macOS. The change in upstream is: Use GeolocationManager in CoreLocationProvider https://chromium-review.googlesource.com/c/chromium/src/+/2779636 Change-Id: I97143886bc3c98ad880c3cfc739ef08e5bfa3e73 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix crash with disabled geolocation on macOSPeter Varga2021-12-084-2/+60
| | | | | | | | | | | | | | | | | QtWebEngine uses custom LocationProvider for geolocation. If geolocation is disabled, Chromium fallbacks to NetworkLocationProvider. NetworkLocationProvider uses GeolocationSystemPermissionManager and tThere is no nullptr check for the manager instance so QtWebEngine has to provide it. This fix implements a FakeSystemGeolocationPermissionManager what is meant to be used only on macOS if geolocation is disabled. LocationSystemPermissionStatus is always set to denied by the fake manager. Pick-to: 6.2 Change-Id: I25d51c9ce8911b95ff69cc72bc6aae7023e7edbe Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update documentationAllan Sandfeld Jensen2021-12-072-6/+0
| | | | | | | | | The signal is updated much faster for paused media now. Pick-to: 6.2 5.15 Fixes: QTBUG-98918 Change-Id: Ifa3b54e212436a7c93e101dc244d7edcbf473b63 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* qpdfX_p.h: include qpdfX.hMarc Mutz2021-12-073-0/+6
| | | | | | | | It's best practice, and will probably solve a linker failure/ODR issue in a subsequent patch. Change-Id: Ieff9d20ddc3b49286459d554a2ff6a706a41af2e Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* QQuickTableViewExtra: make ctor explicitMarc Mutz2021-12-071-1/+1
| | | | | | | | | It's a private class, but add the missing explicit keyword to avoid raised eyebrows in the next reader. Task-number: QTBUG-98796 Change-Id: I63bb45d840b8b09f2b1fe3343fd8fe83416fa60e Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* Make default ctors implicitMarc Mutz2021-12-076-6/+12
| | | | | | | | | | Default ctors should be implicit, because users expect '{}' to call them. If they're explicit, because they're folded into the (QObject* parent) ctors, then that no longer works. Fixes: QTBUG-98881 Change-Id: Ie52812ba76ee0b489c75ecf48b0c048025fde8c7 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* QPdf namespace: Q_DECLARE_OPERATORS_FOR_FLAGS inside the namepaceMarc Mutz2021-12-071-2/+1
| | | | | | | | Otherwise the operators aren't found by ADL. Task-number: QTBUG-98796 Change-Id: I9b80f59bf9f8c76234360f07add80528fc4ab326 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* Make dtors out-of-lineMarc Mutz2021-12-0714-0/+39
| | | | | | | | | | | Pins vtable to a single TU, instead of duplicating it across all TUs that use the class, possibly causing invalid dynamic_cast<>s and other bugs. Fixes: QTBUG-98880 Task-number: QTBUG-45582 Change-Id: Ic296f4583097181ac4d824fac6dab4671ae14a50 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* Mark implicitly-shared classes as Q_DECLARE_SHAREDMarc Mutz2021-12-063-0/+3
| | | | | | Task-number: QTBUG-98796 Change-Id: I2400ef5634ae3c263aaafe1526e843f542a73eef Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update ChromiumAllan Sandfeld Jensen2021-12-061-0/+0
| | | | | | | | | | | | | | | | | Submodule src/3rdparty be03c63b3..735b1a398: > [Backport] Handle long SIGSTKSZ in glibc > 2.33 > FIXUP: Fixes for jumbo build > Compile with GCC 11 -std=c++20 > FIXUP: Fix navigation when clicking on links in a PDF > FIXUP: Adapt accessibility code for our needs after chromium 90 > FIXUP: Add user script data mojo interface and traits > FIXUP: Make GpuSwitchingManager::RemoveObserver() thread safe > [Backport] Return proper value in GLES2DecoderImpl::GetUniformSetup > [Backport][Extensions] Remove string literal conversions by ASCIIToUTF16() > Disable debug info for crbug.com/1224432 Change-Id: I3ddb49ed6853fc78a2b857637888d66af950f8d9 Reviewed-by: Marc Mutz <marc.mutz@qt.io>
* Check if qt_internal_return_unless_building_tools presentMichal Klocek2021-12-061-2/+3
| | | | | | | | Fixes dev build with 6.2.2 Fixes: QTBUG-97944 Change-Id: I027a473bc7cf239610d2162abb697cf10a557f4a Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Fix race condition on layout (take2)Michal Klocek2021-12-062-26/+10
| | | | | | | | | | | | | | | | | | | | | Even if layout is 'meaningful' it can still require update before toPlainTextSync call can proceed. Simply wait for frame being loaded in stead of tracking layout update. Depending on DidLoadFinish will brake default toHtml call for empty not loaded page, therefore return expected value if there is no load. This fixes crashes/asserts on certificateError (stacktrace in bug report). Remove blacklist on certificateError as bad certificate is back on line and toPlainTextSync works without issues. Fixes: QTBUG-97414 Pick-to: 6.2 Change-Id: Ib702bbe813f6061eef446e2d87d7e9e455d715c5 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* QPdfSearchModel: take a QString arg by cref, not valueMarc Mutz2021-12-032-2/+2
| | | | | | | | The function is not a perfect sink for the argument, and the implementation wasn't moving from the argument, anyway, so do the common thing here and take by cref. Task-number: QTBUG-98796 Change-Id: I4237e50cf9c00817245ad8967bf7e2976ffb7085 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* Replace old Qt constexpr defines with constexprAllan Sandfeld Jensen2021-12-021-12/+12
| | | | | Change-Id: Ia68a080fcbf985e2a62178e5ca2722495799f9c9 Reviewed-by: Marc Mutz <marc.mutz@qt.io>
* Use up-to date LGPL license headerKai Köhne2021-12-0255-605/+770
| | | | | | | | Remove usages of outdated LGPL3 header that references LICENSES.LGPLv3 instead of LICENSES.LGPL3. For the examples, use BSD. Change-Id: I1fae49110160c1183327ec54c9dc447c69588a65 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Allow surface factory with no backendAllan Sandfeld Jensen2021-12-021-3/+6
| | | | | Change-Id: I5fef92c4cb0110e413a7af2d35f2e9cf02a5b16b Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Adaptations for Chromium 94Allan Sandfeld Jensen2021-12-0266-390/+473
| | | | | Change-Id: I9fb8998a3a7762b0aea70993ca231f0bbf4f7761 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Adaptations for Chromium 92Allan Sandfeld Jensen2021-12-0265-320/+363
| | | | | Change-Id: I1849c130ca75615802744275f6e4212a755c39b4 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Adaptations for Chromium 91Allan Sandfeld Jensen2021-12-0259-191/+175
| | | | | Change-Id: Ie0236697615fd67e4f53df3dca013ce39628cc29 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix build with the latest qtbasePeter Varga2021-11-301-0/+1
| | | | | | Pick-to: 6.2 Change-Id: I66a3536ecaa2d5dded5a645c46f05c559b90eda4 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix race condition on layoutMichal Klocek2021-11-252-5/+35
| | | | | | | | | | | | Calling some methods without 'meaningful' layout when render frame is visible tiggers at the best some DCHECKS. Therefore if frame is visible wait for 'meaningful' layout. This fixes some flaky tests on toPlainTextSync call. Pick-to: 6.2 Change-Id: I746a1c436798b440c59f9b8b4a1d297e3fa7e56d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
View Lorry Controller Status