summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
...
* Fix rpaths on mac framework buildsMichal Klocek2021-09-181-3/+6
| | | | | | | | | | | | | | | | | | In case of framework builds webengine process needs LC_RPATH with @loader_path or @executable_path which resolves to the absolute path of the webengine process executable so correct value is @loader_path/../../../../../../../ Do not try to resolve relative path in qtbase because for some reason it can give different result on different build setups use fixed INSTALL_RPATH property. Fixes: QTBUG-96539 Change-Id: I6e8f8c15ac40c261a4f5e3c6b9ed8b4c168a38ec Reviewed-by: Michael Brüning <michael.bruning@qt.io> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 310db2b8164fd2a8d9bed4bbf46faa674ff553cc) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix build when xcb only over egl/es2Michal Klocek2021-09-181-2/+3
| | | | | | | | | | | Qt's xcb can be compiled without the glx support, do not use Chromium flag to check that. Fixes: QTBUG-96398 Change-Id: Ie7f1fe74699cd83aee1f9e5aff59760d4d7a70bf Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 0fba07e0238a9ff0a1b496eae60ad92257ea76af) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Rename Quick examples' folder from webengine to webenginequickBalazs Egedi2021-09-136-7/+7
| | | | | | | | Fix webengine directory path in project files and comments Pick-to: 6.2 6.2.0 Change-Id: I06ed9ee41111e7135fa9feb152ad2a5eb2262b76 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Remove check for profile directory from favicon service factoryKirill Burtsev2021-09-111-3/+0
| | | | | | | | | | | | | Since the directory itself in initialized asynchronously this check may lead to desynchronization with how profile is considered to be off the record and what it really is. Subsequently, with a possible wrong initialization of a favicon service with invalid history service for non-otr profile. Pick-to: 6.2 6.2.0 Fixes: QTBUG-95580 Change-Id: I66fbb7914a303650490e1577989beee5cd883037 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix drag and drop againAllan Sandfeld Jensen2021-09-102-6/+6
| | | | | | | | | | Return the right QObjects Fixes: QTBUG-96308 Change-Id: If04be10fe19db6b8c0552c7df588961c711c1250 Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit e85e4ab275fb0a0c072f19ed3d5c5b5b46de8321) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Stop listing Adobe Flash as a featureAllan Sandfeld Jensen2021-09-091-47/+1
| | | | | | | | This has been removed Pick-to: 6.2 6.2.0 Change-Id: I9f4be83d584427935bccfff3f23419a49c1664a4 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Update ChromiumMichael Brüning2021-09-092-0/+5
| | | | | | | | | | | | | | | | | | Submodule src/3rdparty f8a944bb..202e3447: > [Backport] CVE-2021-30566: Stack buffer overflow in Printing > [Backport] CVE-2021-30618: Inappropriate implementation in DevTools > [Backport] CVE-2021-30616: Use after free in Media. > [Backport] Security bug 1227228 > [Backport] Security bug 1239116 > [Backport] Security bug 1216595 > [Backport] Security bug 1206289 > [Backport] CVE-2021-30613: Use after free in Base internals Pick-to: 6.2 6.2.0 Change-Id: I52c611ae7029baafcc182a6d66890f4bfff81d34 Fixes: QTBUG-96209 Task-number: QTBUG-96292 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Support more module flags for 'configure' scriptKirill Burtsev2021-09-094-11/+39
| | | | | | | | | | | | Support flags passed to main 'configure' and separate 'qt-configure-module' scripts with flags like '-no-build-qtpdf', '-webengine-full-debug-info', '-no-webengine-jumbo-build', etc. Fixes: QTBUG-95717 Pick-to: 6.2 6.2.0 Change-Id: Ia12602e9a9b31f4f2256f983f6c1e3fbe50cb9e3 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Disable FTP supportAllan Sandfeld Jensen2021-09-081-0/+1
| | | | | | | | Will be gone in 92 anyway, so avoid it in 6.x Change-Id: Idc1d58bcda6ee7edb81f7b468ff548cc370e40ec Pick-to: 6.2 6.2.0 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Add the documented configure commandline optionsJoerg Bornemann2021-09-071-0/+13
| | | | | | | | | | Add the missing src/core/api/qt_cmdline.cmake file that defines the commandline options that are documented in config_help.txt. Pick-to: 6.2 Task-number: QTBUG-95717 Change-Id: I54c88a5bfbfb1f497ee60f3e023b96317f385526 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Make configure -list-features workJoerg Bornemann2021-09-071-8/+11
| | | | | | | | | | | | | | | | | | To list features, qtbase's QtProcessConfigureArgs.cmake must include the configure.cmake files. It includes all configure.cmake files that are in directories that are registered with qt_commandline_subconfig in the repository's top-level qt_cmdline.cmake. Add such a qt_cmdline.cmake files and add only src/core/api, because its configure.cmake is the only one that lists public features. Guard find_package calls in that configure.cmake such that they are not executed when configure's initial feature gathering phase is run. Pick-to: 6.2 Fixes: QTBUG-96196 Change-Id: If61774f467c4df6138f9b63c4c1326a561178af6 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Extend cflags also for mcpuMichal Klocek2021-09-061-0/+0
| | | | | | | | | Updates Chromium with: * f8a944bbe5f Add support for mcpu Pick-to: 6.2 Change-Id: I3f9d31f3ec99badd62d82fca911bee22dde5985f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix handling of new window requestKirill Burtsev2021-09-054-40/+19
| | | | | | | | | | | | | | | | | | | | Fixes heap-use-after-free for WebContentsAdapter, which is replaced in the case, when new window set to be opened and adopted by the same page, which triggered this request: for example, when 'this' is returned by 'createWindow' override. Achieve this by scheduling 'deleteLater' on an old adapter. This was already implemented that way for internal 'adoptWebContents', but was overlooked for page's 'createWindow' API. So just unify handling logic. Also, adapt 'customUserAgentInNewTab' test, since adopting existing WebContents from different profile is not supposed to work, and now enforced by the check in 'adoptWebContents'. Unfortunately, test should also be blacklisted, since it's appeared that custom user agent is still not reliably set for newly created window. Task-number: QTBUG-76249 Fixes: QTBUG-94772 Pick-to: 6.2 Change-Id: Ic9dff33eae99cc242a294d45a92be96306cef93d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update ChromiumAllan Sandfeld Jensen2021-09-051-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Submodule src/3rdparty: 0fd1fa10..5b90394d > Bump V8_PATCH_LEVEL > [Backport] CVE-2021-30604: Use after free in ANGLE > [Backport] CVE-2021-30599: Type Confusion in V8 > [Backport] CVE-2021-30598: Type Confusion in V8 (2/2) > [Backport] CVE-2021-30598: Type Confusion in V8 (1/2) > [Backport] CVE-2021-30603: Race in WebAudio > [Backport] CVE-2021-30602: Use after free in WebRTC > [Backport] Security bug 1228036 > [Backport] Security bug 1221068 > [Backport] CVE-2021-30590: Heap buffer overflow in Bookmarks > [Backport] Security bug 1227933 > [Backport] CVE-2021-30591: Use after free in File System API > [Backport] CVE-2021-30585: Use after free in sensor handling > [Backport] Security bug 1205059 > [Backport] Security bug 1217598 > [Backport] CVE-2021-30588: Type Confusion in V8 > [Backport] CVE-2021-30587: Inappropriate implementation in Compositing on Windows > [Backport] CVE-2021-30582: Inappropriate implementation in Animation > [Backport] CVE-2021-30579: Use after free in UI framework > [Backport] CVE-2021-30573: Use after free in GPU > [Backport] CVE-2021-30569, security bugs 1198216 and 1204814 > [Backport] CVE-2021-30568: Heap buffer overflow in WebGL > [Backport] CVE-2021-30560: Use after free in Blink XSLT > [Backport] CVE-2021-30541: Use after free in V8 > [Backport] CVE-2021-30562: Use after free in WebSerial > [Backport] CVE-2021-30563: Type Confusion in V8 > [Backport] CVE-2021-30559: Out of bounds write in ANGLE > [Backport] Security bug 1184294 > [Backport] Security bug 1194689 > [Backport] CVE-2021-30547: Out of bounds write in ANGLE > [Backport] CVE-2021-30548: Use after free in Loader Pick-to: 6.2 Fixes: QTBUG-96210 Task-number: QTBUG-96209 Change-Id: I921920b5ec445b421af465b214a41f8a36d13e31 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Disable widgets and quick in case of no coreMichal Klocek2021-09-041-2/+5
| | | | | | | | No webengine build can be also specified from command line. Pick-to: 6.2 Change-Id: I812c871dfbab4b34c650e67344af835f421ea61c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix manifest and plist for render processMichal Klocek2021-09-042-22/+7
| | | | | | | | | | | | | | | | Add manifest file in case of windows build. Manifest verified with mt tool on windows: mt -inputresource:QtWebEngineProcess.exe -out:process.manifest For plist we use template MacOSXBundleInfo.plist.in and only CFBundleIdentifier was missing compared to our custom plist file. Pick-to: 6.2 Change-Id: Iafcc0d456ec43c6465eacd9a4719a388bf421f7c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Enable no opengl buildsMichal Klocek2021-09-046-5/+24
| | | | | | | | | | | | | By mistake opengl was marked as required library, but should be just optional. Fix compilation issues. This should enable build on yet another coin node. Pick-to: 6.2 Change-Id: Id87404928e6b042d902fcfe0a7fed99a6806456f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update ChromiumMichal Klocek2021-09-041-0/+0
| | | | | | | | | | | | Pulls in following changes: * f41bb66fa5f Fix build with MSVC 2019 * b0d6e444a0b [Backport] CVE-2021-30536: Out of bounds read in V8 * dcdec1a9807 Add pdf resources only if enable_pdf Pick-to: 6.2 Change-Id: I69558c72bdb9efd490ddbb0d50e1c9523643357f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add desginer plugin to cmake buildMichal Klocek2021-09-015-1/+27
| | | | | | | Fixes: QTBUG-95668 Pick-to: 6.2 Change-Id: If3613043bfad00871b847c57a3e0961a67cec89b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix indentationAllan Sandfeld Jensen2021-08-311-17/+17
| | | | | | Pick-to: 6.2 Change-Id: I70375cabda3282e9dc1aa1a8e0513522abbcd383 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Adjust install and copy path for locales and resourcesMichal Klocek2021-08-311-11/+19
| | | | | | | | | | | | In case of top level build with prefix, make sure we also copy resources and locales to build dir, so tests can be executed without installing. Pick-to: 6.2 Task-number: QTBUG-95590 Change-Id: Ie64e650259b2c38a6eda8d15a94f7101ad8380a8 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Use generator expression to get moc pathMichal Klocek2021-08-312-11/+2
| | | | | | | | | | | | | | | | | | We used IMPORTED_LOCATION for getting moc path, however this will not work in case of top level builds, since moc is not "imported", we can not use LOCATION due to https://cmake.org/cmake/help/latest/policy/CMP0026.html Use generator expression to set the moc path for gn. Clean up RSP_PREFIX leftover from previous gn version. Note QtPdf does not even need moc setup since we just need pdfium library. Pick-to: 6.2 Task-number: QTBUG-95590 Change-Id: Ief3dca96f65e198e9693293316b1a90007c56355 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Set right RUNPATH for QtWebEngineProcessAllan Sandfeld Jensen2021-08-301-3/+5
| | | | | | | | | Call qt_apply_rpath like for Qt tools or apps. Pick-to: 6.2 Fixes: QTBUG-96093 Change-Id: I22c670ede70ba52d1255bb362519d152a227f5f3 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix crash when clicking on a link in PDFSzabolcs David2021-08-301-1/+1
| | | | | | | | | Do not try to use WebContentsDelegate of a guest WebContents. Task-number: QTBUG-95269 Change-Id: If7bbd25bcac26c30a4ff1bee3f732ba01215ec4b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 7f4a6ff45743cecbfe0dd14ef29afd0874a2ed39)
* Update ChromiumMichal Klocek2021-08-291-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This pulls in the following changes: * 291982fed7c Use Chrome HSTS * a0947f39232 FIXUP: Fix printing sources for Qt and add them to the build. * dfacfba809d FIXUP: Stop sending ViewMsg_SetBackgroundOpaque to renderer * 4febbcfdaaa FIXUP: Add cookie filter to URL requests cookie headers * b814ac9c9b1 FIXUP: Fix building on macOS with Xcode * 27e9e7673eb FIXUP: Fix for our tests * 3c230af9b21 [Backport] Remove a local frame root usage in RenderFrameImpl * 7b06ec91336 [Backport] Remove unused variable in SourceBufferStream * fd1f81a69a3 Fix some compiler warnings * 62a8a367d4e FIXUP: Silence most warnings * 3f518b2824d Revert "Fix not working video in debug builds" * 43426393a42 [Backport] Gate breaking FreeType change in COLRv1 struct names * 190b2c47a54 Workaround debug iterator issues with MSVC * 9104847e516 Revert "Fix build with MSVC standard library" * 0a09f2e87b6 FIXUP: Forward cleared selections * c96e352f979 Revert "Protect against nullptr dereference in GetSelectedText" * 8535c9a306e Revert "Prepare net-internals for QtWebEngine usage" * b0b96e3c0ef [Backport] Remove unneeded includes from net_internals_ui.cc * 709aa60c812 Revert "Silence assert on MessageWindow::WindowClass destruction" * 7d02d54400d Fix navigation when clicking on links in a PDF * 556edad682b Add rsp target writer * 0fd1fa101f3 Remove obsolete cmake link writer Change-Id: If65fe84ffb7e5eaa2d43a545bb5f4c8ba1fec6d6 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add workaround for not working linking with bfd linkerMichal Klocek2021-08-291-0/+3
| | | | | | | | | | | | | | | | | Removal of external project removed also workaround for coin bug, which is still not fixed. Add linker launcher in case maximum number of open files is below 4096 on linux for WebEngineCore target. This launches bash script wrapper which sets ulimit. This is poor man workaround and requires cmake 3.21 to work. Task-number: COIN-699 Task-number: QTBUG-95590 Pick-to: 6.2 Change-Id: Ib9d0c4ced988d4692746e51f3abbe63ff5085836 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix installation paths of resources and localesMichal Klocek2021-08-291-2/+2
| | | | | | | Fixes: QTBUG-95231 Pick-to: 6.2 Change-Id: I9aa2c42f97b903d17a709767f26b0b4dde4db8b5 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Rewrite gn-cmake integrationMichal Klocek2021-08-2912-309/+393
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous gn-cmake integration was driven towards having the complete cmake build tree which included gn build artifacts. These were marked as IMPORTED in cmake build files, this way cmake "knew" all object files and static libs coming from gn. To achieve that we needed to run the cmake configure twice. First to feed gn with the build information from cmake and then the second run to import all the build information to cmake based on gn run. As a side effect of this the first run cmake was creating incomplete targets, so we could use generator expressions to gather all the data needed for gn run. The second run of cmake was able to create fully initialized targets. We used 'external project' to run cmake the second time. This approach worked well when doing "module" builds and having two targets, one in the main project and one in external was not an issue. Moreover, this approach could be integrated nicely since CI does only "module" builds. Unfortunately "top level" builds are implemented to import all qt targets into one build tree. This created issue for qtwebengine since fully initialized targets were 'hidden' by 'external project' and including half baked (dummy) targets from the main project resulted in bunch of issues related to the dependency tracking and build race conditions. Also using 'external project' complicated installation rules and in the end installation worked differently than in other modules. With current approach we use response files, so we hide all build artifacts coming from gn and feed cmake with those response files. This way we run the cmake configure once and we create all the targets once. Using rsp files hacks linker options in cmake, so this approach is sub-optimal, however allows to have working "top level" builds. It is worth mentioning here that the final module linking has to take place with cmake's part of build since doing one static lib in gn is not possible due to the toolchain limitation (msvc is not able to process static libs over 4Gb and has no support for thin archives, so only a shared lib is doable at time of writing) Following changes are made: * remove 'external project' for qtwebengine target, we keep it however for ninja ,gn and a host project * call gn from cmake in a scripting mode during build and not configure run, this way BUILD.gn is assembled as a build step so after generator expressions are executed * BUILD.gn is assembled now from 4 files: - root template BUILD.root.gn.in - compiler data gn_config_c.cmake, gn_config_cxx.cmake - sources data gn_cofnig_target.cmake * since we use gn wrapper script use gn.args file to pass arguments instead of a command line, so this file can be now easily modified when running gn and ninja 'manually' * since a script mode does not support handling of properties with TARGET as such, use the DIRECTORY scope in some of our functions which handle GN_TARGET * use qt_build_repo() in main CMakeFile and remove all coin and top level build hacks * remove 'external project' for examples and tests, this is no longer required as all qt targets are not hidden by external project * remove leftovers from gn feedback call used for GN_TARGET * improve installation rules, WebEgineCore target is not by default installed during build, therefore we need to copy resources and translations to root so tests and examples still can be built without a module being installed first * adjust GN lookup paths, we look for gn in main configure and during scripting mode when gn is executed Fixes: QTBUG-94349 Fixes: QTBUG-94709 Fixes: QTBUG-94922 Fixes: QTBUG-94997 Fixes: QTBUG-95051 Fixes: QTBUG-95152 Fixes: QTBUG-95158 Fixes: QTBUG-95972 Task-number: QTBUG-95231 Task-number: QTBUG-95590 Pick-to: 6.2 Change-Id: I5e7a34287ee59d904103fe310fc7c6a36a8dfbc9 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add 'amazing' windows linker workaround for rsp filesMichal Klocek2021-08-292-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This should be part of previous patch, however it deserved separate commit message with explanation. On windows cmake generates ninja rules with cmake wrapper for linker in form of: cmake.exe -E vs_link_dll vs_link_dll internal command unfortunately expands all rsp files passed to liker before calling it (it looks for '@') and also swaps the order. This ends in bogus linker call. Make a workaround based on: https://github.com/Kitware/CMake/blob/master/Source/cmcmd.cxx#L2102 Use response files prefixed with 'CMakeFiles' so internal command of cmake will skip the processing. Since rsp files must now start with filename and not with filepath we also need to copy them to directory where we call the linker. Task-number: QTBUG-95590 Pick-to: 6.2 Change-Id: I8e96ebf3a9ac7c7d751db6682ce37f38880be793 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Use rsp files directly from gnMichal Klocek2021-08-295-16/+16
| | | | | | | | | | | | | | | | | | Do not use gn created cmake files since this requires cmake configuration step, which currently ends up in duplicated targets in main and qtwebengine external project. Use response files instead, so we can remove duplicated targets in follow up patches. This approach unfortunately has downside of cmake not being aware of gn build artifacts and hacks directly linker command. For universal builds remove not needed rsp template, since we can now use rsp files directly generated by gn. Task-number: QTBUG-95590 Pick-to: 6.2 Change-Id: I83282ba68fa171cada7236d0587be27122315dec Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Restore enums for QQuickWebEngineView from old-new API classesKirill Burtsev2021-08-262-2/+51
| | | | | | | | | Restore SC, but at least deprecate these enums in view Pick-to: 6.2 Change-Id: Ic2a263b0ec175c56b8bf450fae9576bfefca2928 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Remove unneeded extension -> file access privilegeAllan Sandfeld Jensen2021-08-261-5/+1
| | | | | | | | | | It was hacked in before we got guest views working for the pdf viewer, but should no longer be needed. Pick-to: 6.2 Change-Id: I3085c1ba591c600942e488751ada12473c6454d0 Reviewed-by: Szabolcs David <davidsz@inf.u-szeged.hu> Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Update documented versionAllan Sandfeld Jensen2021-08-261-1/+1
| | | | | | | Pick-to: 6.2 Fixes: QTBUG-94408 Change-Id: I0aab0377878b7ba75e43ec329e7a9d1b02ab2021 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Enable touch events in webenginequick by defaultBalazs Egedi2021-08-261-0/+1
| | | | | | | Task-number: QTBUG-95924 Pick-to: 6.2 Change-Id: If6905e8c98c0468c74bb96f9a22267cb9ce4ed16 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add missing touch-related delegates to CMakeBalazs Egedi2021-08-261-0/+2
| | | | | | | Task-number: QTBUG-93666 Pick-to: 6.2 Change-Id: Id959077f4aeb8f6e4d619d88a683b8f5f7447775 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Doc: Fix remaining documentation warningsTopi Reinio2021-08-262-7/+6
| | | | | | | | | | | * WebEngineCertificateError::ignoreCertificateError() was renamed to acceptCertificate(). * Use correct \instantiates class for WebEngineNewWindowRequest. Pick-to: 6.2 Task-number: QTBUG-95860 Change-Id: I42cc4a8939625b432cb4c6f68b26423b6dc3fa7d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Doc: Remove unsupported customFiltersKai Köhne2021-08-252-8/+0
| | | | | | Task-number: QTBUG-95987 Change-Id: Ie762a1e45cf0e84951cf7c91bf2144f38ad55dd1 Reviewed-by: Paul Wicking <paul.wicking@qt.io>
* Fix devtools internal reattachAllan Sandfeld Jensen2021-08-241-1/+3
| | | | | | | | | We were replacing the devtools with a new one instead of reattaching. Pick-to: 6.2 Change-Id: I7729b2e1fcc2946d8d5d67acbf026a06e8cbdc06 Reviewed-by: Michal Klocek <michal.klocek@qt.io> Reviewed-by: Balazs Egedi <egedib@inf.u-szeged.hu>
* Doc: Fix documentation warnings for Qt WebEngineTopi Reinio2021-08-232-7/+3
| | | | | | | Pick-to: 6.2 Task-number: QTBUG-95860 Change-Id: I5b1fd6a6e5f172724fcfbde1a791b342a7e1ff92 Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
* Fix rendering and crash with popupsAllan Sandfeld Jensen2021-08-201-4/+4
| | | | | | | | | | Were not rendering right after the "Move scenegraph handling out of core" change. Pick-to: 6.2 Task-number: QTBUG-95924 Change-Id: I30e206084573a64aeb8a93ca54b46f8a23aa81b3 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Remove TODO commentAllan Sandfeld Jensen2021-08-201-2/+0
| | | | | | | | | The default settings make less sense now that we do not have the old default profile. Pick-to: 6.2 Change-Id: I9022bbe905eb06944646cd1b9813b48970c62ad7 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Move the rest of the super module documentation to core moduleAllan Sandfeld Jensen2021-08-199-0/+0
| | | | | | | | Previously parts were moved, but these were left behind in the quick module. Pick-to: 6.2 Change-Id: Icef469e14d073170ec5b2296048874d2b7439385 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Add QtWebEngine Qt6 migration guide to list of migration guidesAndreas Buhr2021-08-191-0/+1
| | | | | | | | Pick-to: 6.2 Task-number: QTBUG-94933 Change-Id: I92690535f839ef92e7464fa09f994fcd4f53d7e5 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Rename quick's 'newViewRequested' to 'newWindowRequested'Kirill Burtsev2021-08-188-52/+52
| | | | | | | | Match new api within the page API. Pick-to: 6.2 Change-Id: Ib2af2f5270f368813cecab8f1c6b7366d3b7172f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Document changes in qt6Allan Sandfeld Jensen2021-08-182-0/+153
| | | | | | | | Pick-to: 6.2 Fixes: QTBUG-94933 Change-Id: I8777b8136afad0e93c0762433471476840802ba6 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Clean up coding style in API header filesAllan Sandfeld Jensen2021-08-1833-73/+110
| | | | | | Pick-to: 6.2 Change-Id: Ifa5892415a1e0b8ce9b6bfa10719aba618e3b799 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Hide unneeded Quick C++ APIsKirill Burtsev2021-08-176-7/+7
| | | | | | | | They are not supposed to be a part of public Quick API Pick-to: 6.2 Change-Id: Ib04ea022192d0eec559c28a48bc87fabda932564 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update documentation notes for build with WebEngine modulesKirill Burtsev2021-08-1713-23/+72
| | | | | | | | | | Add cmake usage snippets for module's libraries. Remove quick version from code snippets. Fix minor documentation warnings. Fixes: QTBUG-94937 Pick-to: 6.2 Change-Id: I2e5c8616ceeab495f604e135bb2aa2261c50c68d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add QtPdf to cmake buildMichal Klocek2021-08-1755-77/+432
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Port QtPdf to Qt6: * QtPdf,QtPdfWidgets,QtPdfQuick libs * QtPdfQuickPlugin, QtPdfPlugin (imageformat) plugins * widget and quick examples * qtpdf tests To fit gn cmake integration and new repo layout code is a bit reshuffled. Compared to qmke build following features are not ported yet: * ios fat libs * qtbase 3rdparty static dependencies WebEngine build can be skipped with setting QT_FEATURE_qtwebengine_build=OFF Note this patch needs follow up for 6.2 branch to disable qtpdf builds by default, since this should not part of qt 6.2 release. Pick-to: 6.2 Task-number: QTBUG-95353 Change-Id: I4dd9f3934bdd478fb6d2fa686074a24d91f09953 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Refactor gn targetMichal Klocek2021-08-172-110/+54
| | | | | | | | | | | | | | | | | | | | Currently we get hangs on ci, to investigate the issue go through current cmake code and: * remove all dummy ninja targets * remove implicit dependencies * build dir in form of buildDir/config/arch * separate ninja call for sandbox * separate ninja call for covert_dict * clean up universal build * change handling of rsp files, so they are generated during build and not configure time * refactor functions so universal build can be easily used by follow up qtpdf patch Pick-to: 6.2 Change-Id: Id4a6c61b87fe76832232035fddf212b57051d0ec Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>