summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
...
| | * Leave room for the null-termination byte when checking remote drive pathMichael Brüning2021-01-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The implementation could lead to heap corruption because the drive letter string was not large enough for the drive letter plus the null- termination byte. Original patch by Tamas Karpati. Change-Id: I012057c48b071a453ef8cda926041d3e9db78555 Fixes: QTBUG-90347 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 3fb215dab139fd7b61473ce3fe1058b87a6b4fe3) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
| | * Do not extract download file names from certain url schemesMichael Brüning2021-01-221-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Chromium uses the default download file name if the scheme of a file to download is either about or data, as the file name extraction methods do not seems to work for those. Mimic this behavior in Qt WebEngine as well. Fixes: QTBUG-90355 Change-Id: I14b8c4f64559500d3f231dd26533a5947bf94bc3 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
| | * Support devtools close buttonAllan Sandfeld Jensen2021-01-221-0/+2
| | | | | | | | | | | | | | | Change-Id: Icad495c3bf144a4da53b2a60585dabb3fc36d3d6 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* | | Fix builds without printsupportAllan Sandfeld Jensen2021-02-031-1/+6
|/ / | | | | | | | | Change-Id: I213a56ddf4856168c9eb4d134369c8090ed5be0b Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | Merge remote-tracking branch 'origin/5.15' into devAllan Sandfeld Jensen2021-01-25131-1433/+1775
|\ \ | |/ | | | | | | | | Including update to 87-based Change-Id: I36b6054e00de97ab055d0bc800cff08d0408fac6
| * Allow to fallback to default locale for non existent data packsKirill Burtsev2021-01-201-1/+3
| | | | | | | | | | | | | | | | | | | | | | Fix crash for locales, for which there is no pak data file (like en-DE). Match original chromium's implementation for LocaleDataPakExists by checking if path for file exists in order to not to try to load invalid non-existent pack file. Change-Id: I47c5cc97c09bdf8e78dcff024d82796d4c419f2c Fixes: QTBUG-90490 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
| * Enable hangout services extensionPeter Varga2021-01-2024-51/+510
| | | | | | | | | | | | | | | | | | | | | | [ChangeLog] Enable hangout services extension and implement its WebRTC desktop capture extension API dependency. Fixes: QTBUG-85731 Task-number: QTBUG-51185 Task-number: QTBUG-61676 Change-Id: I7a659c2b0039243ac8d8c58685716ffc55265e3b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Update Chromium versionAllan Sandfeld Jensen2021-01-191-1/+1
| | | | | | | | | | | | | | Match the already used versions. Change-Id: I8ade97aa38fdc52337a32a0ca92664bb50a0e611 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
| * Update minimum windows sdkMichal Klocek2021-01-181-1/+1
| | | | | | | | | | | | | | 87-based requires 10.0.19041 windows sdk. Change-Id: I9c6d09e85836367ebcf9fbb2b8b4d574180d7de5 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Fix position of popup on qmlMichal Klocek2021-01-182-8/+6
| | | | | | | | | | | | | | | | | | | | | | In case there is no window system with qml simply use screen rect. This will also work well with rotated view (for non windowing system). Task-number: QTBUG-86034 Task-number: QTBUG-89358 Change-Id: Ic042d766d661c8322422b194c08b58609992961b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Fix blank popups in qmlMichal Klocek2021-01-181-0/+1
| | | | | | | | | | | | | | | | | | | | | | In qml when on platforms without windowing system we need to send show notification. Note this was not required with old compositor, since it was hooked up differently than viz. Task-number: QTBUG-86034 Change-Id: I3ecdc033802d59c15637bc0e48961cd7748b1c6b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Fix some warningsPeter Varga2021-01-162-2/+2
| | | | | | | | | | Change-Id: Ic7cff2556945272761288fedd271796dbf240cb5 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
| * Remove Java build dependencyAllan Sandfeld Jensen2021-01-151-2/+3
| | | | | | | | | | | | | | | | We were actually using closure compilation, let's disable it for now, until we have java build-time detection. Change-Id: Ie5fd0f397a773d38a1eb8a94ac2f186e9073ea6e Reviewed-by: Michal Klocek <michal.klocek@qt.io>
| * Remove configure options that doesn't workAllan Sandfeld Jensen2021-01-152-34/+0
| | | | | | | | | | | | | | They are just confusing users. Change-Id: I107b4212e425e77b892c1ce77ee0fbfb89a97c7f Reviewed-by: Michal Klocek <michal.klocek@qt.io>
| * Quiet log on webrtc usageAllan Sandfeld Jensen2021-01-151-2/+2
| | | | | | | | | | | | | | We now get permission requests for CAMERA_PAN_TILT_ZOOM Change-Id: I1a86a1aa4d8ec4e8c7f9c1842cd709425de9c954 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
| * Register PerformanceNode early enoughAllan Sandfeld Jensen2021-01-153-14/+13
| | | | | | | | | | | | | | Must be created before RenderFrame. Change-Id: I4ee121f6ad6a77fc48d12bc56b1fdb82ec97139b Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
| * Adaptations for Chromium 87Allan Sandfeld Jensen2021-01-1362-648/+625
| | | | | | | | | | Change-Id: Ic4ffd98e02f986dbaf986405360e727c813e696e Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
| * Adaptations for Chromium 86Allan Sandfeld Jensen2021-01-1351-338/+281
| | | | | | | | | | Change-Id: I7e0ebecdbb68cfff0b574c966f3fa80d28680e1c Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
| * Adaptations for Chromium 85Allan Sandfeld Jensen2021-01-1337-135/+158
| | | | | | | | | | Change-Id: I33c1af7c431055d95e0fb540246765cce684de15 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
| * Adaptations for Chromium 84Allan Sandfeld Jensen2021-01-1341-256/+235
| | | | | | | | | | Change-Id: I359805d0bea84147fca6de2e2c7b17b4dcb17bc7 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* | Leave room for the null-termination byte when checking remote drive pathMichael Brüning2021-01-201-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | The implementation could lead to heap corruption because the drive letter string was not large enough for the drive letter plus the null- termination byte. Original patch by Tamas Karpati. Change-Id: I012057c48b071a453ef8cda926041d3e9db78555 Pick-to: 5.15 Fixes: QTBUG-90347 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Merge branch '5.15' into devAllan Sandfeld Jensen2021-01-1932-505/+476
|\ \ | |/ | | | | | | | | Last commits before 87 update. Change-Id: Id156b0199a8fd354c946cfe604ae8541ba554658
| * Fix leak in QQuickWebEngineViewPrivate::contextMenuRequestedAllan Sandfeld Jensen2021-01-121-1/+1
| | | | | | | | | | Change-Id: Idb41daa68709c769330527a713689241ac073359 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
| * Suppress error pages also for http errors if they are disabledKirill Burtsev2021-01-063-7/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Load with client or server http error results in successful navigation, which leads to 'true' loadFinished result, and subsequent chromium's error page load and display with second set of loadStarted/loadFinished signals. This effectively ignores QWebEngineSettings::ErrorPageEnabled. Fixing it requires submodule change to ask embedder if error pages should also be suppressed for http errors. Also update chromium for required change, which pulls in the following changes: * e71010069b4 Fix embedded builds with printing enabled * f5a93d251cc Allow the embedder to suppress an error page for http errors Change-Id: I731678575439a6dad90dfb89e79b0083c63b49c2 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Fix crash on linkedin.comAllan Sandfeld Jensen2021-01-051-0/+3
| | | | | | | | | | | | | | | | | | Disable the InstallApp feature, which we have disabled as it integrates with the payment subsystem. Fixes: QTBUG-89740 Change-Id: I212bad785294a70812385e96d5f7e300f5806f87 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
| * Update ChromiumMichal Klocek2020-12-111-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | Pulls in the following changes: * dfe93385f41 [Revert] Don't use harfbuzz-subset * 9087c921839 Add user script data mojo interface and traits * 25db271c9b5 Add WebEnginePageRenderFrame mojo interface Change-Id: I3bf77b63acb3dab3113f70105d3dd304d2d34b95 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Migrate render_view_observer_qt to mojoMichal Klocek2020-12-1111-130/+152
| | | | | | | | | | | | | | | | | | | | | | | | Since mojo interface no longer works on render view, but on render frame rename the class to be WebEnginePageHost and WebEnginePageRenderFrame Keep SetBackgroundColor render message, since it is required to things work. Change-Id: I4d6b70dd448926f8ac2d75d2b87f3d490a4cfefb Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Cache mojo interface bindings for WebChannelIPCTransportMichal Klocek2020-12-114-16/+49
| | | | | | | | | | Change-Id: Ica6b794e16aecc60dc2c39d31750acc6b25410df Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Cache mojo interface bindings to UserResourceControllerRenderFrameMichal Klocek2020-12-112-30/+40
| | | | | | | | | | Change-Id: If9394dbfe49adf7330558eac194a0ec643eb8ee6 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Remove RenderViewObserverHelper from UserResourceControllerMichal Klocek2020-12-113-72/+35
| | | | | | | | | | | | | | | | | | | | | | After site isolation we observe render frames and we do not need render view observer any longer. Remove RenderViewObserverHelper and track user script per render frame. This approach is more intuitive since we run those scripts on frames, subframes and not on render views, which can span over few frames. Change-Id: Ife02d8a4dbecc884cfdc667b1a16dfbdd866367a Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Minor. RenderThreadObserverQt is really a RenderConfigurationMichal Klocek2020-12-116-30/+34
| | | | | | | | | | | | | | | | Follow same naming as in UserResourceController, which also implements RenderThreadObserver. Change-Id: I8a8386e6fb9fcc52826da1d0eef6efa97fd475e9 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Minor. Fix namespace for user resource controllerMichal Klocek2020-12-113-5/+9
| | | | | | | | | | Change-Id: If9a6b2ceca41534f28ec1d87093778f16fc31ff0 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Fix crashes in user resource controller when single processMichal Klocek2020-12-115-32/+52
| | | | | | | | | | | | | | | | | | Mojo interface when running in single process was not correctly destructed, since we used user resource controller as global static object. Move user resource controller to content render client. Change-Id: I219510c9bc382545174aa5aae99ac8282a2049e6 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Migrate user script IPC to mojoMichal Klocek2020-12-1112-241/+156
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use mojo instead of old IPC, keep current design and use two interfaces one global and one per frame for now, also use in both cases associated interface with ipc channel otherwise script can be added during the page load, which will radomly brake tests. This change moves UserDataScript to chromium since mojo binding generation did not work correctly. Use StructTraits when serializing the class. Change-Id: I7073fb831c96849e47864382188300db3c9137d9 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Merge remote-tracking branch 'origin/5.15' into devAllan Sandfeld Jensen2020-12-1117-144/+372
|\ \ | |/ | | | | Change-Id: Id1a1f4ca84697ba18e2604090e3154295fe1858b
| * Update minimum HarfBuzz version to 2.4.0Peter Varga2020-12-081-2/+2
| | | | | | | | | | | | | | | | | | Chromium uses HarfBuzz only for font subsetting since the 83-based update and it can't be built with older HarfBuzz version than 2.4.0. Task-number: QTBUG-88976 Change-Id: Ibcea31b487c3f8d1b3f9b8566b95ddf2a35987bb Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Fix building against 5.12 on most CIsAllan Sandfeld Jensen2020-12-082-1/+2
| | | | | | | | | | Change-Id: I4c4bbc75b9f6346a446f8094f669d142f76c164a Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
| * Add QtZlib as static dependencyMichal Klocek2020-12-083-1/+17
| | | | | | | | | | | | | | | | | | | | | | QtZlib is a semi private module, headers are installed as Qt5Zlib, however all object are in QtCore. Add support to compile against Qt5Zlib when doing static build. Task-number: QTBUG-87154 Change-Id: I74d1b217725b37781808a54902f9acbee41c50c4 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Update ChromiumMichal Klocek2020-12-081-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pulls in the following changes: * f830b86ef77 [Backport] mac: make find_sdk.py work when the sdk goes to 11 * 9236b21c883 Fix build with system ICU 68 * 138a7203f16 Fix build with msvc2019 16.8.0 * 1ca6cb93ca8 Add qt static dependencies: qtfreetype, qtharfbuzz * 29b90d82710 Add qt static dependencies: qtlibpng * da115b70738 Add qt static dependencies: qtlibjpeg * bb90182aa90 Add qt static dependencies: qtzlib Change-Id: Ib986dde7db99c7d6663d12f933ddbb4acc4e79e1 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
| * Add qt static deps when doing static buildMichal Klocek2020-12-083-0/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add qtfreetype, qthurfbuzz, qtlibpng, qtlibpng static 3rdparty libs. If qtbase has some 3rdaprty libs, which are also present in chromium. This leads to duplicated symbols and can lead to unexpected issues with application. Currently we do only static builds for qtpdf, therefore this changes only affects qtpdf builds. If qtfreetype is used, hurfbuzz dependency is not used, qtlibpng is only used when pdf compiled with xfa. Task-number: QTBUG-87154 Change-Id: Ibba528268d9c989a2c63c1a7881ba0c95c325437 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Stabilize load signals emittingTamas Zakor2020-12-032-15/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make the WebContentsDelegateQt::EmitLoadStarted() and the WebContentsDelegateQt::EmitLoadFinished() independent from the WebContentsDelegateQt::LoadProgressChanged() by removing m_lastLoadProgress. Adapt the WebContentsDelegateQt::LoadProgressChanged() to send signal only if load is in progress. Add a new test based on the bugreport. Fix qmltests::WebEngineViewSource::test_viewSourceURL() flaky tests. Fixes: QTBUG-65223 Fixes: QTBUG-87089 Change-Id: I90af4d2e85105dba801beb8102991eb4ef14c6a3 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Fix handling of more than one finger for touch eventKirill Burtsev2020-12-021-27/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change addresses following wrong assumptions implemented earlier: * fix assert condition for custom MotionEventQt: pointer index is only reserved only for two distinct events POINTER_UP and POINTER_DOWN, which represent one single non first/last pointer up and down event. * MotionEvent API doesn't support delivering multiple touch point changes at once, hence code should send every touch point's up/down step by step to not confuse gesture detection classes in chromimum (ultimately fixing arising asserts which old code was triggering before). * MotionEvent shouldn't contain more touch points then were already forwarded or reported released, hence every step should contain only part of all touch points received in handleTouchEvent. Fixes: QTBUG-86389 Change-Id: I62275dc295494f88a6e44f36fe72f5f8227e37d4 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
| * Forward modifier flags for lock keysPeter Varga2020-12-021-1/+25
| | | | | | | | | | | | Fixes: QTBUG-89001 Change-Id: I9f336313b075ad0cb3115975afc410beb415e4a0 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * QtPdf: Fix for loading local .pdf files on WindowsMiika Pernu2020-12-011-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | QQuickPdfDocument passed source QUrl::path() to QPdfDocument::load. QUrl::path() output gets "/" as prefix on Windows preventing the file from being found so this needs to be accounted for by changing it to QUrl::toLocalFile(). Fixes: QTBUG-88938 Change-Id: I52ed44f67c22bea31637050442487e1914011de9 Reviewed-by: Andy Shaw <andy.shaw@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry picked from commit 5852716178972dd34df34dabc52a6616eead0aca) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
| * Set custom headers from QWebEngineUrlRequestInfo before triggering redirectKirill Burtsev2020-12-011-14/+13
| | | | | | | | | | | | Fixes: QTBUG-88861 Change-Id: I7091aca70aaf87edf0b1e67ec3fa705a59c8192c Reviewed-by: Michal Klocek <michal.klocek@qt.io>
| * Touch handling: fix mapped ids cleanup for TouchCancel eventKirill Burtsev2020-11-282-25/+26
| | | | | | | | | | | | | | | | | | | | TouchCancel may come with empty points list, so previous one (from TouchBegin) is used. Therefore it should be cleaned independently on leaving the scope. Thus unify common code cleanup in the end of handleTouchEvent and ensure TouchCancel's ids remove from mapping. Change-Id: I1ef2baa5f920fa9096ddac2ddd5d4ac70ab6e218 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Touch handling: provide id mapping without modifying TouchPoint instanceKirill Burtsev2020-11-282-40/+37
| | | | | | | | | | | | | | | | | | This api was made private in dev 4e400369c0 and currently has side effects, which lead to touch malfunction and test failures. Task-number: QTBUG-88001 Change-Id: Ie84e770a229f58704363448df116aedbc3e8eb82 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Use the module's version number for QtWebEngineProcessNils Jeisecke2020-11-271-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | When built against a Qt version different from the module version, all QtWebEngine libraries will be versioned with MODULE_VERSION. QtWebEngineProcess as part of the module should be handled in the same way. Change-Id: I34073337e813baac46f207443bf54ca78d879ea6 Reviewed-by: Andy Shaw <andy.shaw@qt.io> (cherry picked from commit c636e88bc49f59548e1ac3401ae547e2ae9d2570) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
| * Look for resources in macOS standard Resources dirKeith Kyzivat2020-11-251-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | When on macOS, with a frameworkless build, WebEngine resources are stored in a Resources directory named with a capital R. This is the standard directory name for resources on macOS, however Qt WebEngine was expecting to find resources in a directory named `resources` (no capitalized first letter). Task-number: QTBUG-72368 Change-Id: I2106a50a63c6d812dc6ad649645e3b6b9e0471e2 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
| * Merge remote-tracking branch 'origin/5.15.2' into 5.15Allan Sandfeld Jensen2020-11-244-15/+14
| |\ | | | | | | | | | Change-Id: I516761e18c03c6cfd4d44a6ee176a2add9a5b022