summaryrefslogtreecommitdiff
path: root/tests
Commit message (Collapse)AuthorAgeFilesLines
* Test WebWindowType parameter in CreateWindow()Anu Aliyas2023-05-081-0/+74
| | | | | | | | | | - Added testcase to test WebWindowType parameter in CreateWindow. Fixes: QTBUG-112645 Change-Id: I4f6bf452afcceeaa67ff07b879a2acd836bd8fac Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit db21f13e77982623b8342f981f31d8fa2ea12434) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix user script management when subframes are presentAllan Sandfeld Jensen2023-04-301-0/+33
| | | | | | | | | | | Only the main frames should administer scripts associated with it. Fixes: QTBUG-113109 Change-Id: Ibda66f55ef99da632134a9de1425797262faba9b Reviewed-by: Michael Brüning <michael.bruning@qt.io> Reviewed-by: Martin Negyokru <negyokru@inf.u-szeged.hu> (cherry picked from commit 17c64fd5d2778df4a52849e8942104d4d9555a1e) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Minor. Small clean up of qmake leftoversMichal Klocek2023-04-223-17/+0
| | | | | | | Change-Id: I0ef7f97b3d76c43e815daeb7d6782215c08e4f7d Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit 67eb9e151f75ff1fc570c27ede7868f40ed299ff) Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Better handling of interrupted PDF printingSzabolcs David2023-04-051-0/+14
| | | | | | | | | | | | | | | | | | | | | | - Document the fact Stop WebAction can interrupt the in-progress PDF generation. - Update PrintViewManagerQt::PrintPreviewDone(): Normally IsPrintRenderFrameConnected() implies IsRenderFrameLive(), but we have to check both to avoid crash when render process exits. (Like Chrome does.) - Update PrintViewManagerQt::RequestPrintPreview(): Handle that case when print preview params were sent between processes at the beginning, but it was interrupted before RequestPrintPreview() could start PDF generation. - Add a simple auto test to catch crashes Task-number: QTBUG-108154 Change-Id: I8a4f9cc97ddcf9a165d66a5981d93a023858fbc1 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit c3ed0e176ccda503c968626010ca36f1f3961fce) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Replace WebEngineAction example with a snippetMichael Brüning2023-04-047-0/+220
| | | | | | | | | | Also moves the example to the manual tests directory. Task-number: QTBUG-108751 Change-Id: Ie3fa492cfcaf61ee26ed65fa22954bb6a6532d6e Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit 23d1131577e1780de0552211a84357bcb1f63de5) Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Minor. Fix namespace issues of inputmethods manul testMichal Klocek2023-03-253-1/+8
| | | | | | | Change-Id: Ic0f318aa63cab901b979d76a34e329b2ab8359cf Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit cec2d7602709dae40a172b4adcf1c76bcf258f9c) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Move custom touch handles example to manual testsMichal Klocek2023-03-246-0/+167
| | | | | | | | | | | | Move and add missing parts as snippet. Task-number: QTBUG-108751 Change-Id: I25849941700337626ca46e399fdb52264bc4659a Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Yigit Akcay <yigit.akcay@qt.io> (cherry picked from commit 55f9fc348278b2aa8985ec9c1e7e092f88f68f83) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Move custom dialogs example to manual testsMichal Klocek2023-03-2430-0/+1557
| | | | | | | | | | | | | This example shows how to use dialogs, however documentation already provides snippets for that added in 3cbe59e29a. The only missing one was tooltip, therefore add missing snippet and move example to manual tests. Task-number: QTBUG-108751 Change-Id: I84eda805455fb0276046ed1089389d605a8af672 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 6bf30525ee49d270dae6a6440bc607513f21237c) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Move quick minimal example to manual testsMichal Klocek2023-03-247-0/+89
| | | | | | | | Task-number: QTBUG-108751 Change-Id: I0998c46f051908855e0406e5fc7c0a422dc3eef0 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit ed76eef004dbac15f4740d33d06d2b271bf770d4) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Move widgets minimal example to manual testsMichal Klocek2023-03-246-0/+63
| | | | | | | | | Task-number: QTBUG-108751 Change-Id: I6e237b04d1f6a19f64516cd45aabe4d28099abd5 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 34ebe8be93ab10766d034e5a3943a12c8de3a58e) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix not working password test for QPdfQuickMichal Klocek2023-03-211-5/+0
| | | | | | | | | | | | | In qml url can have different schemas like 'qrc' 'file' 'assets'. Make correct conversion so file can be loaded. Note check isLocalFile() is not true for qrc scheme. Fixes: QTBUG-106072 Change-Id: I4dcc969e4c6d9b3f58ea5d81d20d8e81b55edfde Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry picked from commit efbb12954cf6e581b6b29bed2fa2bb26e1cfab71)
* Add TESTDATA to qtpdf tests and fix data urlMichal Klocek2023-03-205-4/+15
| | | | | | | | | | | | Make cmake aware of test data, this will make data deployable on android. Task-number: QTBUG-83459 Change-Id: Id4271f54f8351e955a6ee57c3a36656d69a2a682 Reviewed-by: Michael Brüning <michael.bruning@qt.io> Reviewed-by: Alexey Edelev <alexey.edelev@qt.io> (cherry picked from commit 404edc4e655701b21bb52835536a0fadf8269ce7) Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* Increase timeout in proxy pac testMichal Klocek2023-03-201-1/+1
| | | | | | | | | According to ci this test would succeed in 13000ms on qemu. Fixes: QTBUG-111939 Pick-to: dev Change-Id: I21911920961a885eee38dcd3261e46b497a1c251 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Blacklist mulipageview tests on androidMichal Klocek2023-03-201-0/+9
| | | | | | | | | | | | | | | | | | | Password test does not pass on emulator, the same issue exists already on windows. Navigation uses hardcoded values for event which ends with "Mouse event at 465, 65 occurs outside target window (320x616)" due to smaller screen of android emulator. Blacklist tests for now. Task-number: QTBUG-83459 Task-number: QTBUG-106072 Task-number: QTBUG-111306 Change-Id: Iacc4c7711d58b0ffb6cdda3474b4d59b628ca5f7 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 3a1d4eac6f1c2ce38b66c2a1ca3525ee34e2cf4a) Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* Fix initialization of QWebEngineDownloadRequest::totalBytes for WidgetsPeter Varga2023-03-071-2/+2
| | | | | | | | | | | | | QQuickWebEngineProfile already initializes totalBytes. Also clean up QWebEngineDownloadRequestPrivate and fix typo in documentation. Fixes: QTBUG-104869 Change-Id: I8c4b79c076ddc63180960e22a9488b45ff6c4402 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 496647f7647571ca3cdf81b10ba418de0f06f34d) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Add qml filesystem api testsMichal Klocek2023-03-014-0/+200
| | | | | | | | | | | | | | | | | | | There are three functions we use within file systems API, which trigger dialogs: * window.showSaveFilePicker * window.showOpenFilePicker * window.showDirectoryPicker Only first one was tested with widgets, therefore add tests which cover use of api, and also test cover the found issues in previous commits. Note we have separate test to cover file system dialogs coming from <input> html tags in tst_filePicker Change-Id: I4616efa84688ed471fb8c4566e49262bce945638 Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit 1a291c5579122e520af1a2cec263ebd12dcd2407)
* Retire the qt_parse_all_argumentsAmir Masoud Abdol2023-02-101-2/+2
| | | | | | | | | | | | | To do so, we need to deal with the macros a bit differently, so here, I replaced the macros with available utility functions, and added one for the QTWEBENGINEPROCESS_NAME. Fixes: QTBUG-110873 Task-number: QTBUG-99238 Change-Id: I29b41ffb8059511d2d93bfc01d40308aedaa8ad4 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 1f4fdb06b13f0a9400f16313aad9296f019d2fc9) Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Blacklist tests blocking integrationsAllan Sandfeld Jensen2023-02-082-0/+5
| | | | | | | | Task-number: QTBUG-110578 Change-Id: Ic063d08246351709d02642abc0747b5fbe9e2ef7 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 585cf7cc793bb25158c2cf72fe61e7894ef9de11) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Remove quicktestbrowserPeter Varga2023-02-0212-1069/+0
| | | | | | | | | | | | | | It is not maintained for a while and most probably also not used because it is not working since Qt6. QuickNanoBrowser example should be used instead, because it implements most of the quicktestbrowser features. Change-Id: I330e1c6e0f4bf81c0bce0e6d70d47a513f63d8c7 Reviewed-by: Michal Klocek <michal.klocek@qt.io> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 756b8d63ac1710dc3661c1900a0a90ae3b0db926) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Replace uses of deprecated _qs with _sPeter Varga2023-02-021-7/+9
| | | | | | | | Task-number: QTBUG-101408 Change-Id: Ie8a7944c3ded5662953bed00f022905f5805275e Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit b4cf9c2e0520ec39ef064955ec025f5941e4c04a) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Add InputEventObserver to child framesMartin Negyokru2023-02-011-0/+108
| | | | | | | | | | | | | | | | | | | | | RenderWidgetHostViewChildFrame does not Ack mouse wheel events. RenderWidgetHostViewQt::handleWheelEvent expects Ack on every event. Origin-Agent-Cluster is a HTTP response header that instructs the browser to prevent synchronous scripting between same-site cross-origin pages. Chromium also uses this header as a hint that an origin should get its own separate resources, such as a dedicated process. That's where child frames are created. This feature is implemented in chromium 88. Add observer to child frames that responds to wheel events. Add test for wheel/scroll events on child frames. Fixes: QTBUG-109348 Change-Id: I20439a9068c5c2f8416a350891a6cf8830e1a5d6 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit e70f53df4d189fa832e3cd6bb729a00c5b6d52ea) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Skip favicon database QML tests on High DPI screensPeter Varga2023-01-181-0/+6
| | | | | | | | | | | | | | The tests use the middle pixel's value of an image to check if a certain icon is loaded. The images are scaled on High DPI screens and the pixel values are changed due to interpolation. It cannot be expected to have the same pixel values for different device-pixel-ratio settings, thus rather skip the test than maintaining a list of pixel values for different scales. Change-Id: I8d142de0106167a5d16c540fa468003b36c95317 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 86da28c5658230a361cd94a514d500c3ad3a7de9) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Quick: Fix file selection modes in the default UI delegateSzabolcs David2023-01-163-1/+20
| | | | | | | | | | | Our implementation of QML file picker was outdated. Now directory picker is a separate type of dialog and other file selection modes are set in FileDialog.fileMode property. Change-Id: Icc62369539c56666e596e5ee6f1b3068a43acd81 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 35d4b0b1d1c723e32d589b3dfddfe96eaa8e5568) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix contentsSize and scrollPosition on High DPI screensPeter Varga2023-01-132-7/+7
| | | | | | | | | Provide the same values what are available from JavaScript. Change-Id: I9e047d749279934d0c8ccd45710571e8c7745859 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit dcbcb44f0b5fb5c901594d9b0e6c4c5476709a10) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix build with -no-accessibilityPeter Varga2023-01-101-1/+9
| | | | | | | Change-Id: I7128608467e4d0ce1b04efa9b82a98f78942d4db Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit a4342183199ba9fbd6c86939cf9748e069a09f9c) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Adaptations for 108-basedAllan Sandfeld Jensen2023-01-062-2/+2
| | | | | | | | Fixes: QTBUG-105147 Change-Id: I0022964903f3443cc97843c62468ab9be8ae2ed8 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> (cherry picked from commit 5121effa745cf88b6d50630249570113941c2ca2) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix creation of nssdb for certificate store unit testMichal Klocek2023-01-032-7/+13
| | | | | | | | | | | | | | In case there is no nssdb in system create empty database. This got unnoticed as running webengine creates one, however when doing test configuration on fresh system without one pk12utils fails. Move 'nickname' to certificate otherwise clean job does not work. Task-number: QTBUG-109179 Change-Id: I401ffab62dd13d7aa1459672b1170afcde3cde83 Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit b3b4aef1d67096632c703adca6fdfb2b676bdc0a) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Remove setPushServiceEndpoint from APIMichal Klocek2022-12-221-2/+2
| | | | | | | | | | | Use setPushServiceEnabled instead. Update also getter and documentation. Task-number: QTBUG-107442 Change-Id: I299ce88b06edef0f1a0088fb10f4a142056039be Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit 4bedbe65c8af21e29e3ed274334ce1d32c8f9279) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Recreate response head objects on multiple redirectMichael Brüning2022-12-143-0/+55
| | | | | | | | | | | | The previous response head gets moved when redirecting, which lead to dereferencing a null pointer on the next redirect. Fixes: QTBUG-109357 Change-Id: Iaad1c46b8d4ca9720f1749980a9e06337ca0f3d8 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit c6b2b5d8038b3ec0de6233c1e21df60ade11c81b) Reviewed-by: Marc Mutz <marc.mutz@qt.io> Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Route Qt::TimeSpec usage via QTimeZoneEdward Welbourne2022-12-121-2/+6
| | | | | | | | QTimeZone now packages Qt::TimeSpec details, unifying QDateTime APIs. Task-number: QTBUG-108199 Change-Id: I62d9837fac01b5d95e9fd0cff034cb450854c9e7 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* Disable V8 sandbox for QEMU arm64 CIPeter Varga2022-12-091-3/+0
| | | | | | | | | | | | | | | | | After the 106-based adaptations V8 sandbox is enabled by default. It cannot be disabled runtime anymore. The initialization of the sandbox has significant overhead in a qemu-aarch64 environment, at least 5sec. This makes most of our auto tests timeout. The sandbox is not supported on 32bit platforms. The detection of the QEMU target relies on the environment variable TARGET_OSVERSION_COIN=qemu on the CI. Fixes: QTBUG-108993 Change-Id: I45961bc2e8a0af505113777f2b26f10b93b7477f Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Rewrite mixedSchemes testMichal Klocek2022-12-091-86/+142
| | | | | | | | | | | | | | Follow the same 'test' pattern we have in other tests. Note that this and previous change make test suite for tst_origin execute faster form ~170s to ~60s for desktop linux and from ~320s to ~140s for qemu. Task-number: QTBUG-105342 Pick-to: 6.4 Change-Id: I5cd0aa0a76fcc2d005cee398a88ba4099f9881c3 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Reduce slowness and flakiness of tst_originMichal Klocek2022-12-095-22/+45
| | | | | | | | | | | | | | | | | | | | | | This test runs very slow and it is flaky. Make it run faster by: * instead of doing timeout checks for "cannotLoad", introduce <image> element add use 'onload' and 'onerror' handlers before doing actual <iframe> load, this dropps a need for hardcoded delay/deadline for ifrme being loaded. * do not evaluate JavaScript in try wait loop , use JavaScript messages instead. Note that using <img> or <script> element to perform the test (which have onload and onerros handler unlike iframe) ie. loading cross origin scripts or images instead of iframes is a dead-end as it has different results and "canLoadButNotAccess" can not be tested as origin BAR can load a script from origin FOO, but it still works in BAR‘s context. Task-number: QTBUG-105342 Pick-to: 6.4 Change-Id: I180aea801cedb0f97b96cb90a54b793d0a7c1a7f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Deprecate Quota Permission Request APIPeter Varga2022-12-081-27/+26
| | | | | | | | | | | | | | | | | | | | | | | | Requesting host quota is no longer supported by Chromium. navigator.webkitPersistentStorage has became an alias for navigator.webkitTemporaryStorage after the Chromium 106 update. Requesting quota for temporary storage is needless because the allocation is automatic and storage can't be requested beyond the maximum limit. The logic of the persistent storage will be entirely removed in the next Chromium update so just deprecate the API and remove the corresponding implementations. [ChangeLog][QtWebEngineCore] Deprecate QWebEnginePage::quotaRequested() signal and QWebEngineQuotaRequest class. The signal is not emmitted anymore. [ChangeLog][QtWebEngineQuick] Deprecate QWebEngineView.quoataRequested() signal. The signal is not emitted anymore. Task-number: QTBUG-56354 Change-Id: Ie397598c416d9e811270ba56a97f8984948277f7 Reviewed-by: Szabolcs David <davidsz@inf.u-szeged.hu> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Disable nss test on yoctoMichal Klocek2022-12-071-1/+1
| | | | | | | | | As pk12util call fails disable the test. Fixes: QTBUG-109179 Pick-to: 6.4 Change-Id: I4149c77a86c3c1df8b34ed9b641eae916e688ecc Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
* Add Support for Client Hints HeadersAllan Sandfeld Jensen2022-12-041-0/+28
| | | | | | | | | [ChangeLog][WebEngineCore] Client hint headers now added to HTTP requests Fixes: QTBUG-107451 Change-Id: I450fe1fe782b702fc81a3d90c82c0ece6a19ea45 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Add auto tests for fragment navigation on custom URL schemesSzabolcs David2022-11-282-1/+188
| | | | | | | | | | | Since the corresponding third party fix involves making difference depending on the URL syntax, and the issue mentions different behavior in case of relative and absolute URLs, test all four syntax with all four types of URL with both relative and absolute links. Task-number: QTBUG-102058 Change-Id: Idfcc899e33241f42c588b9aae04c5b42b0e07ccd Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Skip tests on qemu arm64Allan Sandfeld Jensen2022-11-281-0/+3
| | | | | | | | Just too slow Task-number: QTBUG-108993 Change-Id: I907118e2d72ae6e2c1b6953ff692d7b922cef74f Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Adaptations for 106-basedAllan Sandfeld Jensen2022-11-287-13/+15
| | | | | | Change-Id: I2fe91c06ce91dfaace7825a0589b56ee375479b6 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Return both application and system certificatesAllan Sandfeld Jensen2022-11-225-8/+143
| | | | | | | | | | | | | | | | | | | | | | | | | For the certificate choice return both application and system certificates. Add unit test to cover the case on Linux. Unfortunately it requires adding the user certificate to the nss data store, which is not not nice, however porting the certificate manger from Chromium is a bigger task. Test runs only if the machine has pk12utils installed. During the test the user certificate is imported into the nss database with the nickname 'qwebengineclientcertificatestore'. This can be removed later with: ninja remove-user-personal-certificate and verified with: certutil -d sql:$HOME/.pki/nssdb -L Pick-to: 6.4 Change-Id: I475fddc68ea56304980f6c835ed4cfed4b093ad4 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Add client SSL authentication testMichal Klocek2022-11-2210-6/+200
| | | | | | | | | | | | | | | | Our qwebenginecertificatestore unit test so far only tested adding/removing custom certificates into the memory. However, it never actually initialized certificate store and did not test if ssl certificate client authentication really works. Cover that case and client authentication test. Note ca and client certificates in the test are self signed to be able to run test without network connection, however we ignore the errors. Pick-to: 6.4 Change-Id: I4df4fdfabed5abd8f8bde7d4c0c79b5fd7f6f3a9 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Use QSslServer in certificate testMichal Klocek2022-11-173-37/+31
| | | | | | | | | | | | | | | | | We had our own implementation for the HTTPS server. However, the way it worked involved adding for every incoming connection a socket to the list of pending connections, which resulted in unnecessary logging noise due to socket connect/disconnected signals during the SSL handshake negotiations. It also resulted in memory leaks. Since 6.4 we have now QSslServer which adds socket to the pending connection list only after encryption got established. Pick-to: 6.4 Change-Id: I3c8a2a0684e3f0760a56d4b4aaf7b777700e334b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Monthly re-run of clang-tidy qt-* checks (11/2022)Marc Mutz2022-11-111-21/+21
| | | | | Change-Id: Ife7ebf1bf0b1db867e0ea195d9a8a3b4abd9a1b7 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Blacklist certificate test and unblock integrationsMichal Klocek2022-10-311-0/+2
| | | | | | | | Certificate for revoked.badssl.com expired on 10/28/2022. Pick-to: 6.4 Change-Id: I06022bea1404bf5134f815067dcd2713790e5a23 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix GCC compiler warnings in auto testsPeter Varga2022-10-133-9/+13
| | | | | | Pick-to: 6.4 Change-Id: I9daae92749e7dbe0580c17e8f0325e2199b2ed17 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Port from container::count() and length() to size() - V4Marc Mutz2022-10-1128-741/+741
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8, but extended to handle typedefs and accesses through pointers, too: const std::string o = "object"; auto hasTypeIgnoringPointer = [](auto type) { return anyOf(hasType(type), hasType(pointsTo(type))); }; auto derivedFromAnyOfClasses = [&](ArrayRef<StringRef> classes) { auto exprOfDeclaredType = [&](auto decl) { return expr(hasTypeIgnoringPointer(hasUnqualifiedDesugaredType(recordType(hasDeclaration(decl))))).bind(o); }; return exprOfDeclaredType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes)))); }; auto renameMethod = [&] (ArrayRef<StringRef> classes, StringRef from, StringRef to) { return makeRule(cxxMemberCallExpr(on(derivedFromAnyOfClasses(classes)), callee(cxxMethodDecl(hasName(from), parameterCountIs(0)))), changeTo(cat(access(o, cat(to)), "()")), cat("use '", to, "' instead of '", from, "'")); }; renameMethod(<classes>, "count", "size"); renameMethod(<classes>, "length", "size"); a.k.a qt-port-to-std-compatible-api V4 with config Scope: 'Container'. Change-Id: I3e6fef8eca212da0c4f0b464545ba96183b4476f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Port from qAsConst() to std::as_const()Marc Mutz2022-10-075-6/+6
| | | | | | | | | | | | | | We've been requiring C++17 since Qt 6.0, and our qAsConst use finally starts to bother us (QTBUG-99313), so time to port away from it now. Since qAsConst has exactly the same semantics as std::as_const (down to rvalue treatment, constexpr'ness and noexcept'ness), there's really nothing more to it than a global search-and-replace. Task-number: QTBUG-99313 Change-Id: I4b5f85df579532c2af938fe70db945ba273782fb Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add missing header to tst_qwebenginepageMichal Klocek2022-10-062-2/+3
| | | | | | | Fixes: QTBUG-107113 Change-Id: I53a540d05bcafefad282ee00091eb421d07992c6 Reviewed-by: Michael Brüning <michael.bruning@qt.io> Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
* Stop using deprecated QMouseEvent constructorShawn Rutledge2022-10-061-2/+5
| | | | | | | | | Followup to qtbase 6b2c9b81afdb3d1d9b7a2e87819e9545b14810f3 Pick-to: 6.4 Change-Id: Ib879ee176c4fd1fc4bdbac7161ea20cf5c59a247 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix locally falling tst_qpdfdocument on qemuMichal Klocek2022-09-151-1/+1
| | | | | | | | | | Use name for temporary file otherwise is can not be opened on qemu. Task-number: QTBUG-105342 Pick-to: 6.4 6.3 Change-Id: I7f9ed244c32b866ead6832ed942e2293be24811b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
View Lorry Controller Status