From f393443d607a8c095334ffc5965e50871b260846 Mon Sep 17 00:00:00 2001 From: Peter Varga Date: Thu, 8 Dec 2022 13:48:55 +0100 Subject: Remove webengine-v8-snapshot-support feature The correspdonding v8_use_snapshot gn argument has been already removed in the Chromium 79 adaptations. It is useless since then. Change-Id: Ied1df9e8ed3149a0309d90fc026f4158627c0bcc Reviewed-by: Michal Klocek --- src/core/api/configure.cmake | 13 ------------- src/core/configure.json | 15 --------------- 2 files changed, 28 deletions(-) diff --git a/src/core/api/configure.cmake b/src/core/api/configure.cmake index 333039a42..a35651b8b 100644 --- a/src/core/api/configure.cmake +++ b/src/core/api/configure.cmake @@ -62,10 +62,6 @@ qt_feature("webengine-system-alsa" PRIVATE LABEL "Use ALSA" CONDITION UNIX AND TEST_alsa ) -qt_feature("webengine-v8-snapshot-support" PRIVATE - LABEL "Building v8 snapshot supported" - CONDITION NOT UNIX OR NOT QT_FEATURE_cross_compile OR ( TEST_architecture_arch STREQUAL arm64 ) OR TEST_webengine_host_compiler -) qt_feature("webengine-geolocation" PUBLIC LABEL "Geolocation" CONDITION TARGET Qt::Positioning @@ -187,10 +183,6 @@ qt_configure_add_summary_entry( ARGS "webengine-vulkan" CONDITION QT_FEATURE_vulkan ) -qt_configure_add_summary_entry( - ARGS "webengine-v8-snapshot-support" - CONDITION UNIX AND cross_compile -) qt_configure_add_summary_entry( ARGS "webengine-system-alsa" CONDITION UNIX @@ -211,11 +203,6 @@ if(CMAKE_CROSSCOMPILING) AND NOT armThumb ) endif() -qt_configure_add_report_entry( - TYPE WARNING - MESSAGE "V8 snapshot cannot be built. Most likely, the 32-bit host compiler does not work. Please make sure you have 32-bit devel environment installed." - CONDITION UNIX AND cross_compile AND NOT QT_FEATURE_webengine_v8_snapshot_support -) qt_configure_add_report_entry( TYPE WARNING MESSAGE "WebRTC requires XDamage with qpa_xcb." diff --git a/src/core/configure.json b/src/core/configure.json index 9e39ae59a..e73f471cf 100644 --- a/src/core/configure.json +++ b/src/core/configure.json @@ -106,11 +106,6 @@ "condition": "config.unix && libs.webengine-alsa", "output": [ "privateFeature" ] }, - "webengine-v8-snapshot-support": { - "label" : "Building v8 snapshot supported", - "condition": "!config.unix || !features.cross_compile || arch.arm64 || tests.webengine-host-compiler", - "output": [ "privateFeature" ] - }, "webengine-geolocation": { "label": "Geolocation", "condition": "module.positioning", @@ -221,11 +216,6 @@ "type": "warning", "condition": "config.linux && features.webengine-embedded-build && !features.webengine-system-ffmpeg && arch.arm && !features.webengine-arm-thumb", "message": "Thumb instruction set is required to build ffmpeg for QtWebEngine." - }, - { - "type": "warning", - "condition": "config.unix && config.cross_compile && !features.webengine-v8-snapshot-support", - "message": "V8 snapshot cannot be built. Most likely, the 32-bit host compiler does not work. Please make sure you have 32-bit devel environment installed." } ], @@ -252,11 +242,6 @@ "args": "webengine-ozone", "condition": "config.unix" }, - { - "type": "feature", - "args": "webengine-v8-snapshot-support", - "condition": "config.unix && config.cross_compile" - }, { "type": "feature", "args": "webengine-alsa", -- cgit v1.2.1