diff options
| author | Julien Chaffraix <jchaffraix@webkit.org> | 2013-02-06 18:12:45 +0100 |
|---|---|---|
| committer | The Qt Project <gerrit-noreply@qt-project.org> | 2013-02-07 19:21:27 +0100 |
| commit | e08d860b281521970867f9f8d0b1c5541cbc5717 (patch) | |
| tree | 8e62f376bb7e187750457053f89b5f24ad1cb63b | |
| parent | a135670457d4124569d2beeb3935d0763d047a20 (diff) | |
| download | qtwebkit-e08d860b281521970867f9f8d0b1c5541cbc5717.tar.gz | |
REGRESSION (r132591): Underpainting @ uofmchildrenshospital.org
https://bugs.webkit.org/show_bug.cgi?id=105861
Reviewed by David Hyatt.
Test: fast/repaint/overhanging-float-detach-repaint.html
The issue comes from overhanging float not contributing to their containing block's
overflow. This meant that repaint() would ignore them leading to an under-repaint.
The fix is simple: force all the overhanging floats to repaint themselves.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Change-Id: I7555f2929578291c08a4d05e1b350a73ec10abff
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
| -rw-r--r-- | Source/WebCore/ChangeLog | 18 | ||||
| -rw-r--r-- | Source/WebCore/rendering/RenderObject.cpp | 4 |
2 files changed, 20 insertions, 2 deletions
diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog index 1d256fe87..cb9bcd6a9 100644 --- a/Source/WebCore/ChangeLog +++ b/Source/WebCore/ChangeLog @@ -185,6 +185,22 @@ * dom/Document.cpp: (WebCore::Document::takeDOMWindowFrom): +2013-01-14 Julien Chaffraix <jchaffraix@webkit.org> + + REGRESSION (r132591): Underpainting @ uofmchildrenshospital.org + https://bugs.webkit.org/show_bug.cgi?id=105861 + + Reviewed by David Hyatt. + + Test: fast/repaint/overhanging-float-detach-repaint.html + + The issue comes from overhanging float not contributing to their containing block's + overflow. This meant that repaint() would ignore them leading to an under-repaint. + The fix is simple: force all the overhanging floats to repaint themselves. + + * rendering/RenderObject.cpp: + (WebCore::RenderObject::destroyAndCleanupAnonymousWrappers): + 2012-12-12 Allan Sandfeld Jensen <allan.jensen@digia.com> [Qt] Animation fails on large layers @@ -225,7 +241,7 @@ * platform/graphics/texmap/TextureMapperImageBuffer.h: (BitmapTextureImageBuffer): - 2012-12-06 Andras Becsi <andras.becsi@digia.com> +2012-12-06 Andras Becsi <andras.becsi@digia.com> [Qt][Mac] Fix libxslt and libxml2 config tests https://bugs.webkit.org/show_bug.cgi?id=104164 diff --git a/Source/WebCore/rendering/RenderObject.cpp b/Source/WebCore/rendering/RenderObject.cpp index 110467ad5..b3f325e2a 100644 --- a/Source/WebCore/rendering/RenderObject.cpp +++ b/Source/WebCore/rendering/RenderObject.cpp @@ -2505,8 +2505,10 @@ void RenderObject::destroyAndCleanupAnonymousWrappers() if (destroyRoot->everHadLayout()) { if (destroyRoot->isBody()) destroyRoot->view()->repaint(); - else + else { destroyRoot->repaint(); + destroyRoot->repaintOverhangingFloats(true); + } } destroyRoot->destroy(); |