diff options
| author | Rob Buis <rwlbuis@webkit.org> | 2013-08-09 23:30:32 +0000 |
|---|---|---|
| committer | Allan Sandfeld Jensen <allan.jensen@theqtcompany.com> | 2016-01-05 15:11:15 +0000 |
| commit | 5fff3df31cfa18682fc061a31267fdd3c302ed01 (patch) | |
| tree | 10f7b229a5ed42cc99de052d6ecec022519b5cee | |
| parent | 7f70d2b795976c1ddbe9c2866012f91b7e0eafd0 (diff) | |
| download | qtwebkit-5fff3df31cfa18682fc061a31267fdd3c302ed01.tar.gz | |
ASSERTION FAILED: stroke->opacity != other->stroke->opacity in WebCore::SVGRenderStyle::diff
https://bugs.webkit.org/show_bug.cgi?id=119623
Reviewed by Dirk Schulze.
Source/WebCore:
Include all the stroke attributes in the style diff comparison, the visited links ones were missing.
Test: svg/animations/animate-stroke-crasher.html
* rendering/style/SVGRenderStyle.cpp:
(WebCore::SVGRenderStyle::diff):
LayoutTests:
Add testcase from bug with small adjustments.
* svg/animations/animate-stroke-crasher-expected.txt: Added.
* svg/animations/animate-stroke-crasher.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153914 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Change-Id: I71ff999dab89127600b4a57b5cee58a6fa4687fd
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
| -rw-r--r-- | Source/WebCore/rendering/style/SVGRenderStyle.cpp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/Source/WebCore/rendering/style/SVGRenderStyle.cpp b/Source/WebCore/rendering/style/SVGRenderStyle.cpp index cbd16cd42..aca245aef 100644 --- a/Source/WebCore/rendering/style/SVGRenderStyle.cpp +++ b/Source/WebCore/rendering/style/SVGRenderStyle.cpp @@ -183,7 +183,10 @@ StyleDifference SVGRenderStyle::diff(const SVGRenderStyle* other) const || stroke->paintUri != other->stroke->paintUri || stroke->miterLimit != other->stroke->miterLimit || stroke->dashArray != other->stroke->dashArray - || stroke->dashOffset != other->stroke->dashOffset) + || stroke->dashOffset != other->stroke->dashOffset + || stroke->visitedLinkPaintColor != other->stroke->visitedLinkPaintColor + || stroke->visitedLinkPaintUri != other->stroke->visitedLinkPaintUri + || stroke->visitedLinkPaintType != other->stroke->visitedLinkPaintType) return StyleDifferenceLayout; // Only the stroke-opacity case remains, where we only need a repaint. |