| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes one occasion of the EFAIL vulnerability [1] for Trojitá
e-mail client. It fixes a privacy leak where malicious HTML content used
to be able to re-enable DNS prefetch.
Patch is straight from WebKit upstream [2] [3], written by Milan Crha
<mcrha@redhat.com> on 2018-02-27. Reviewed by Michael Catanzaro.
[1] https://efail.de/
[2] https://git.webkit.org/?p=WebKit.git;a=commitdiff;h=24e5a4ed218697eb20064e0c14c9e9767f197dbd
[3] https://bugs.webkit.org/show_bug.cgi?id=182924
Task-number: QTBUG-67068
Change-Id: Iec52181c8c77c89e3b8248fa60f5834aa6777458
Reviewed-by: Konstantin Tokarev <annulen@yandex.ru>
|
|
|
|
|
|
|
|
|
|
|
| |
Reduced the high prevision time's resolution to 1ms, the same
precision as Date.now().
Based on upstream commit http://trac.webkit.org/changeset/226495
by Ryosuke Niwa <rniwa@webkit.org>.
Change-Id: I0311c49774b55c40a6ee5c1de97aee022e3b9142
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://bugs.webkit.org/show_bug.cgi?id=146531
rdar://problem/20116796
Reviewed by Simon Fraser.
Source/WebCore:
Test: http/tests/misc/webtiming-resolution.html
* page/Performance.cpp:
(WebCore::Performance::now):
Floor the time returned by performance.now to the nearest 5 microseconds.
LayoutTests:
* http/tests/misc/webtiming-resolution-expected.txt: Added.
* http/tests/misc/webtiming-resolution.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@186208 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Change-Id: I24763f8f5d01e4b9c7c92041f981d53d88a0654d
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
<https://webkit.org/b/144616>
Reviewed by Geoffrey Garen.
This is a merge of Blink's r156613 by simonjam@chromium.org.
Cache a copy of the DocumentLoader's reference timestamp when constructing
the Performance object. That way we don't have to jump through a bunch of scary
hoops to access it when now() is called later on.
* page/Performance.cpp:
(WebCore::Performance::Performance):
(WebCore::Performance::now): Deleted.
* page/Performance.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@183795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Change-Id: Ic875df50eb309a98ac74e50715649574e7efa7ab
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GraphicsContext::endPlatformTransparencyLayer() crashes when called from
destructor if alpha mask layers are at the bottom of layers stack.
While this looks like a violation of endPlatformTransparencyLayer's
premise that there should be at least on opacity layer remaining, I don't
see a better way to avoid code duplication without massive refactoring.
Also fixes crash in svg/clip-path/mask-nested-clip-path-010-expected.svg
Change-Id: I5c8cfc2f447c6a0fc6f37d5792375fa123761928
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
| |
Original commit:
https://github.com/annulen/webkit/commit/3e4b4a4eb1e8ac6d0feb4efa8341212519547296
Change-Id: I335512455c25a8555370eb4ed484d2fdfbf383d4
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QByteArray::{from,to}Base64 are prone to integer overflow when input data
is large, which causes segfaults. We have to set threshold on data size
to prevent this from happening.
Also, changed data URL construction code to do less intermediate memory
reservations. Though biggest offender is QUrl constructor and it has to
stay.
Original commit:
https://github.com/annulen/webkit/commit/535c062962e3e0f425848e6b32ad1c95d25bec4b
Change-Id: Ieaf4c914fdff086e15d2358bdb19d378f2a11feb
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
| |
Partial cherry-pick of r159377 by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=124442
Change-Id: I2ce9aaa5d05304132fa21e3c6d36c06e1f89e5f0
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://bugs.webkit.org/show_bug.cgi?id=173407
Reviewed by Andreas Kling.
JSTests:
* stress/string-repeat-copy-chars-crash.js: Added.
(shouldBe):
Source/WTF:
With GCC 7, StringImpl::copyChars() behaves as unexpected.
This function violates strict aliasing rule.
This optimization is originally introduced to improve performance
in SunSpider's string tests in 2008. When running it in my Linux
box, it no longer causes any observable difference. So, we just
remove this optimization.
baseline patched
string-base64 7.7544+-0.1761 7.6138+-0.2071 might be 1.0185x faster
string-fasta 10.5429+-0.2746 ? 10.7500+-0.2669 ? might be 1.0196x slower
string-tagcloud 14.8588+-0.2828 14.8039+-0.3039
string-unpack-code 36.1769+-0.4251 35.3397+-0.5398 might be 1.0237x faster
string-validate-input 8.5182+-0.2206 8.3514+-0.2179 might be 1.0200x faster
* wtf/text/StringImpl.h:
(WTF::StringImpl::copyChars):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@219182 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Change-Id: I15556f5fae6c7499a83b30486584274a339b3db1
Reviewed-by: Florian Bruhin <qt-project.org@the-compiler.org>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
| |
Change-Id: I81477b1586f2eef7e3659269de75b95914add4fe
|
|
|
|
|
|
|
|
| |
Upstream fix: https://bugs.webkit.org/show_bug.cgi?id=171612
Task-number: QTBUG-60532
Change-Id: I6014feea213aa70ebe40b09d9d1a03fd1ed3c843
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
| |
Change-Id: Iea424015dab142e2f5f32655190885d146c64df7
|
|\
| |
| |
| | |
Change-Id: Ib8d14ead6c781186d2519366552b896327d4f715
|
| |
| |
| |
| |
| |
| |
| | |
qrect.h(670): error #1572: floating-point equality and inequality comparisons are unreliable
Change-Id: I27b55fdf514247549455fffd14b1cb335fe33f63
Reviewed-by: Konstantin Tokarev <annulen@yandex.ru>
|
| |
| |
| |
| |
| |
| |
| |
| | |
We should not convert null to undefined when returning JS values from JSC
to QJSEngine.
Change-Id: I20f5638fe9104341e1a0878fdbdbc49e5fa8d2e1
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: If478dd4aa9fc4492c3999f03e5f66811c9e6b41f
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I638ac5e76f087b2af9211a1bfc1ceb3441626419
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
This patch adds the missing QRegExp includes and removes them when
not used in prevision of the qtbase include cleanup.
Change-Id: Ibb70e9aab72619f6de13b0c0a5e929e5552d1aaa
Reviewed-by: Konstantin Tokarev <annulen@yandex.ru>
|
| |
| |
| |
| |
| |
| |
| | |
It's going to be deprecated.
Change-Id: I2cc901cd2b66330b1beca16c865b6259c3bab949
Reviewed-by: Konstantin Tokarev <annulen@yandex.ru>
|
|\ \
| |/
| |
| |
| |
| |
| | |
Conflicts:
.qmake.conf
Change-Id: Id65b546f295897cd386125d2d3d4160051cc7d22
|
| |
| |
| |
| |
| | |
Change-Id: I2ec38c9a2c1072127b25510cc4b3daa9e1847352
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
This is particularly important for Inspector, which lacks a lot of
useful context menu actions without this patch.
Change-Id: I8170c806028ff140206f13e5e1de0409e945e905
Reviewed-by: Konstantin Tokarev <annulen@yandex.ru>
|
| |
| |
| |
| |
| | |
Change-Id: Ie6ca8f40a7512e37e0b2efc94706242c9f323686
Reviewed-by: Konstantin Tokarev <annulen@yandex.ru>
|
| |\
| | |
| | |
| | | |
Change-Id: Iac71a5d02bdec7a00d17136048e6379c32c53d24
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
It turns out that qt_developer_build is never used anyway.
I did some git archeology and it looks like it was nuked when doing the
5.2 merge from upstream. The original purpose was apparently to control
-Werror, which is nowadays controlled by CONFIG -= production_build.
This actually fixes the build, as the QT_FOR_CONFIG += core-private which
would have been required for qtConfig(private_tests) is missing.
Task-number: QTBUG-55950
Change-Id: Iaaaad184b29b523ce4a4ed8afec2ac527d8f93e3
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
Reviewed-by: Konstantin Tokarev <annulen@yandex.ru>
Reviewed-by: Jan Kundrát <jkt@kde.org>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
otherwise it won't have access to private features like private_tests.
doing it centrally also makes it unnecessary to explicitly load() it
from the configure testcases themselves.
Task-number: QTBUG-57431
Change-Id: I025b01f37265e90c7611e2af939ca83ac13049d2
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
It is enabled when xlibAvailable() returns true, but this
test function was forgotten to be ported to use qtConfig()
and works incorrectly.
Change-Id: I62793aeed4ffa78a68c1f35d07c88c6c9eea71cf
Reviewed-by: Konstantin Tokarev <annulen@yandex.ru>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Checkboxes without State_Active flag are missplaced on macOS.
Set this flag by default to paint checkboxes in correct positions.
Task-number: QTBUG-42948
Task-number: QTBUG-43070
Change-Id: Ie86f3dec156e31c90e454d8f1b41e4d4ec68c8b0
Reviewed-by: Konstantin Tokarev <annulen@yandex.ru>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Some sites doing UA sniffing don't recognize our default UA string
without "Version/x.y" component, corresponding to version number of
Safari.
Task-number: QTBUG-38211
Change-Id: Ic5082a938f639502bb2c11c7df2538584b5f77ee
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
https://bugs.webkit.org/show_bug.cgi?id=70610
Patch by Magnus Granberg <zorry@gentoo.org> on 2014-08-19
Reviewed by Darin Adler.
Source/JavaScriptCore:
Setup %ebx so we can use the plt.
* jit/ThunkGenerators.cpp:
Source/WTF:
Add PLT if we're building with PIC.
* wtf/InlineASM.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@172759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Change-Id: I7524a662f76f75f8dee0a07bf2360420d7b23d2d
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
https://bugs.webkit.org/show_bug.cgi?id=99683
Reviewed by Anders Carlsson.
* jit/ThunkGenerators.cpp:
* tools/CodeProfile.cpp:
(JSC::symbolName):
(JSC::CodeProfile::sample):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162266 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Change-Id: Ia5b36b80ba095dbf0de4430137dc8133d0c06a8e
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | | |
Change-Id: I631efa59c63f8cc414d4ef52138ce772d489a44b
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
MSYS's Python is compiled as a POSIX environment, which means
subprocess.Popen cannot be passed just a single string (to be given to
CreateProcess). Instead, pass the split args and let the underlying
system re-merge them. This is harmless with a pure Windows Python.
MSYS python also changes parameters starting with / to a pathname, so
use the equivalent -directives (dumpbin.exe accepts them).
Change-Id: Id50531a20e40adb71a40525cf714d05c22959fb0
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |\
| | |
| | |
| | | |
Change-Id: Ib843c048b13865645d397428d31eac4f5bd52270
|
| | |\
| | | |
| | | |
| | | | |
Change-Id: I8ffa0181ef59a4fcec216f15413171cbc5b1daed
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This code was all wrong. The dereferencing of the pointer was missing,
so QDataStreamCoder::encodeBytes was encoding pointers (cast to
something, though unclear what), while the decoder was decoding them one
byte at a time
This clearly has never worked. So just use writeRawData and readRawData.
Change-Id: Ic46ff326a6ba46bc877cfffd1483240963ec5ee0
Reviewed-by: Konstantin Tokarev <annulen@yandex.ru>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
It happens that m_formElements can be null in some cases when
FormDataIODevice::reset() is invoked.
Change-Id: I92113588db57c9687bc20d331ba2f5ed8f9eec54
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
the CI obtains them from the qt5 super repo nowadays.
Change-Id: I1a981272cff5cca5d72b22b31a8c8f13a363330d
Reviewed-by: Konstantin Tokarev <annulen@yandex.ru>
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@qt.io>
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Change-Id: Ic8f0fc6fe055cd432aaff8e46d62c0f8d41e61f8
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Change-Id: I2ab9287f17155b18f8caee3866d4125d4451a078
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Change-Id: I1f24a218c1d93306a96a1c577957530e7f5cd807
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
the simulator_and_device CONFIG flag is now gone. this also implies that
we can set the debug_and_release and build_all flags based on the same
condition.
Change-Id: I6203c4b7f64584c06739a9aad1fb7201f2a3628a
Reviewed-by: Jake Petroules <jake.petroules@qt.io>
|
| |\ \ \
| | |/ /
| | | |
| | | | |
Change-Id: I0cb01e653bf640a929c26c771eebedc9e6656b14
|
| | |\ \
| | | |/
| | | |
| | | | |
Change-Id: I124ff77524133fb9b88e76c4af99efb2aa1ff6c8
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
When layout rect is smaller than indicator its edges may not be
repainted properly. Now we center indicator repsectively to layout rect
and inflate repaint rect to cover edges.
Also, when layout rect is larger than indicator, QStyle code paints it
at the top-left corner of given rect. Now indicator is centered, like
other browser engines do.
Note that when layout has auto size for checkbox or radiobutton, their
sizes are adjust beforehand in RenderThemeQStyle::computeSizeBasedOnStyle().
This code path is require only when layout forces checkbox or radiobutton
to be smaller than optimal indicator size.
Task-number: QTBUG-56302
Change-Id: Idaefffc5775055514a430216ea265af2b3a039b4
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Task-number: QTBUG-37899
Change-Id: Idcd92196a44cfac26c6943832bf8971ad70aec5e
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We should not convert Latin1 to UTF16 and back for each header of each
HTTP request and response. In older WebKit versions String was always
16-bit, but now 8-bit is used wherever possible, and this is usually the
case for HTTP headers.
Change-Id: I642f65c614702aca4ad7a673f5073a8eaed5b46d
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
https://bugs.webkit.org/show_bug.cgi?id=98420
Reviewed by Benjamin Poulain.
Source/WebCore:
Remove the need for a "-webkit-" prefix on flexbox
and related properties. This includes:
- align-content
- align-items
- align-self
- flex-basis
- flex-direction
- flex-wrap
- flex-grow
- flex-shrink
- flex
- flex-flow
- justify
- order
... as well as the display keyword values "flex" and
"inline-flex".
* css/CSSComputedStyleDeclaration.cpp: Change names.
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSParser.cpp: Ditto.
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFlex):
* css/CSSPrimitiveValueMappings.h: Since we need to still handle the old
keywords for display, this has added two new keywords.
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EDisplay): If the older keywords were used in
content, map them to the new value names.
* css/CSSPropertyNames.in: Add aliases for the prefixed properties.
* css/CSSValueKeywords.in: Add "flex" and "inline-flex".
* css/DeprecatedStyleBuilder.cpp: Change names.
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
* css/StyleProperties.cpp: Change names.
(WebCore::StyleProperties::getPropertyValue):
(WebCore::StyleProperties::asText):
* css/StylePropertyShorthand.cpp: Rename shorthand methods to remove the prefix.
(WebCore::flexFlowShorthand):
(WebCore::flexShorthand):
(WebCore::shorthandForProperty):
(WebCore::matchingShorthandsForLonghand):
(WebCore::webkitFlexFlowShorthand): Deleted.
(WebCore::webkitFlexShorthand): Deleted.
* css/StylePropertyShorthand.h:
* css/StyleResolver.cpp:
(WebCore::equivalentBlockDisplay):
(WebCore::StyleResolver::applyProperty):
* page/animation/CSSPropertyAnimation.cpp: Change names.
(WebCore::PropertyWrapperFlex::PropertyWrapperFlex):
* rendering/RenderElement.cpp:
(WebCore::RenderElement::createFor): Handle the two new display values (the same way as
the old values).
* rendering/style/RenderStyleConstants.h: Add constants for the new display values.
LayoutTests:
Now that we return "flex" instead of "-webkit-flex" (and similar
changes) update the tests that rely on this. Other than that,
we're still testing the prefixed content. A followup patch
will add tests for non-prefixed content.
* css3/flexbox/display-flexbox-set-get-expected.txt:
* css3/flexbox/display-flexbox-set-get.html:
* css3/flexbox/flexitem.html:
* fast/css-grid-layout/grid-item-display.html:
* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* fast/css/getComputedStyle/resources/property-names.js:
* fast/css/inherit-initial-shorthand-values-expected.txt:
* fast/css/inherit-initial-shorthand-values.html:
* svg/css/getComputedStyle-basic-expected.txt:
* transitions/flex-transitions-expected.txt:
* transitions/flex-transitions.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@173572 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Change-Id: If273fd32d5165e8fa504cdfd5b591a17d61f4bbc
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
https://bugs.webkit.org/show_bug.cgi?id=134886
rdar://problem/17663561
Reviewed by Chris Dumez.
Source/WebCore:
Test: fast/css/calc-binary-operation-crash.html
* css/CSSCalculationValue.cpp:
(WebCore::determineCategory):
Ensure that both axis are within the addSubtractResult table.
Remove unneeded CalcOther test. The call site guarantees it doesn't happen and the normal cases would handle it anyway.
Also strengthen some asserts.
LayoutTests:
* fast/css/calc-binary-operation-crash-expected.txt: Added.
* fast/css/calc-binary-operation-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@177089 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Change-Id: Iaf7199800b78c1397da9335bb3420ab6784f9227
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
https://bugs.webkit.org/show_bug.cgi?id=134059
Source/WebCore:
The expression 'calc((100% - 20px) / 3' did not work properly after r168685,
because primitiveType() function in CSSCalculationValue.cpp has handled
CalcPercentLength and CalcPercentNumber categories as if they were angles.
The patch fixes this incorrect behavior.
Reviewed by Simon Fraser.
Test: fast/css/calc-percentage-pixel.html
* css/CSSCalculationValue.cpp:
LayoutTests:
Added test demonstrates that expressions like
'calc((100% - 20px) / 3' work correctly again.
Reviewed by Simon Fraser.
* fast/css/calc-percentage-pixel-expected.html: Added.
* fast/css/calc-percentage-pixel.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@170544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Change-Id: I2cebbb43b511c8c3634c55a97598d362ae0a1ab3
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|