summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'release' into old/5.0old/5.0Oswald Buddenhagen2013-04-117-14/+13
|\ | | | | | | Change-Id: I65984878e44a88eb1f4266a15060162f53e89e64
| * ASSERTION FAILED: m_repaintRect == ↵v5.0.2Simon Fraser2013-03-302-6/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | renderer()->clippedOverflowRectForRepaint(renderer()->containerForRepaint()) after r135816 https://bugs.webkit.org/show_bug.cgi?id=103432 Remove optimization added in r99752 that attempted to avoid clip rect updates for table cells. As the assertions show, this optimization is not always correct, so remove it. Bug 108272 tracks adding it back in. * rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::updateLayerPositionsAfterScroll): Remove m_canSkipRepaintRectsUpdateOnScroll check when updating clip rects. * rendering/RenderLayer.h: Remove the m_canSkipRepaintRectsUpdateOnScroll bit. Task-number: QTBUG-29214 Change-Id: I453ad4db59218631e236e938c2392a444840df64 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com> Reviewed-by: Jonathan Liu <net147@gmail.com>
| * Crash at JSC::call when loading www.gap.com with JSVALUE32_64 EnabledMichael Saboff2013-03-271-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=108991 Reviewed by Oliver Hunt. Changed the restoration from calleeGPR to nonArgGPR0 because the restoration of the return location may step on calleeGPR is it happen to be nonArgGPR2. * dfg/DFGRepatch.cpp: (JSC::DFG::dfgLinkClosureCall): Change-Id: I2d27a111ae1edbfea9335f3a06c5cc53e065a673 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141951 268f45cc-cd09-0410-ab3c-d52691b4dbfc Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
| * Fails to start QtWebProcess.exe if installed in a path containing spaces ↵Andras Becsi2013-03-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=113328 We use QProcess::start() with a commandline string to start the web process and the string is treated by QProcess as a whitespace delimeted list of the command and the arguments, thus we have to escape the path to the web process binary so that if the path contains spaces we still run the appropriate command. * UIProcess/Launcher/qt/ProcessLauncherQt.cpp: (WebKit::ProcessLauncher::launchProcess): Task-number: QTBUG-30249 Change-Id: Ic72cc58d57201381e0b269ff26edf97fea998bbe Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
| * QML WebView asserts when double clicking a link ↵Andras Becsi2013-03-261-1/+0
| | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=113329 Remove an erroneous assert which is no longer valid if mouse gestures are enabled. Task-number: QTBUG-30288 Change-Id: I3c5dc65d55790b1e97924fe674d26e9587557d92 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
| * [Qt] Flash objects won't load until scrolling pageAllan Sandfeld Jensen2013-03-221-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=110149 Reviewed by Simon Hausmann. Revert r134222. The issue from bug 101836 is no longer reproducable, and the fix was causing flash objects to not load properly. * plugins/PluginPackage.cpp: (WebCore::PluginPackage::determineQuirks): Change-Id: If204d409a6d425022a4f7d21135803bb6f4c309d git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144191 268f45cc-cd09-0410-ab3c-d52691b4dbfc Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
| * Workaround for MSVC 2012 64 bit optimizer bug.Michael Brüning2013-03-211-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Having optimization turned on for the VS 2012 build causes a crash in RenderTableSection::paintObject. The workaround for this is to turn optimization off for this method until a fix in the compiler has been provided. This is tracked in bug https://bugs.webkit.org/show_bug.cgi?id=112900 for the upstream version of WebKit. Please be aware that this is a work around for QtWebKit and did not go through the WebKit review process and is therefore not part of WebKit trunk as of now. Task-number: QTBUG-30117 Change-Id: I76139eaa4c0f07de2d90d197c0b07ef4a576e585 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | Source/WebCore: Crash in WebCore::FrameLoader::checkCompleted()Nate Chapin2013-03-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=110237 Reviewed by Abhishek Arya. Test: http/tests/misc/delete-frame-during-readystatechange.html * loader/FrameLoader.cpp: (WebCore::FrameLoader::checkCompleted): Protect before setReadyState() is called. Change-Id: Ibdbd4027708cc942a8658980b5badba1ffcae09e git-svn-id: http://svn.webkit.org/repository/webkit/trunk@143514 268f45cc-cd09-0410-ab3c-d52691b4dbfc Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | Change RenderFrameSet::paint to use m-rows/m_cols directly.Emil A Eklund2013-03-191-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=108503 Source/WebCore: Reviewed by Eric Seidel. Test: fast/frames/invalid-frameset.html * rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::paint): LayoutTests: Reviewed by Eric Seidel. Add test for how we render an invalid frameset. * fast/frames/invalid-frameset-expected.html: Added. * fast/frames/invalid-frameset.html: Added. Change-Id: I95906b47706f629b087130c1db97918e181c9642 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142539 268f45cc-cd09-0410-ab3c-d52691b4dbfc Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | Crash due to intruding float not removed after writing mode changed.Abhishek Arya2013-03-181-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=100149 Reviewed by Levi Weintraub. Source/WebCore: When RenderView writing mode changes, make sure to mark all descendants with floats for layout. Test: fast/block/float/intruding-float-not-removed-writing-mode.xhtml * rendering/RenderBox.cpp: (WebCore::RenderBox::styleDidChange): LayoutTests: * fast/block/float/intruding-float-not-removed-writing-mode-expected.txt: Added. * fast/block/float/intruding-float-not-removed-writing-mode.xhtml: Added. Change-Id: If2a66e57253ec46643d4a8149f7c5947524581dd git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136253 268f45cc-cd09-0410-ab3c-d52691b4dbfc Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | Fix sync.profile to point to stable for the stable branch.Frederik Gladhorn2013-03-161-3/+3
| | | | | | | | | | | | | | | | This went wrong in the last merge. Change-Id: I856b6b878af216342bc7ac84ca77254de6f192e8 Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com> Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
* | Merge remote-tracking branch 'origin/release' into stableFrederik Gladhorn2013-03-145-5/+32
|\ \ | |/ | | | | Change-Id: I338406ae18d738c2eb84e9946e09c031b9332ced
| * Work around a MSVC 2012 Update 1 bug causing a crash on x86jocelyn.turcotte@digia.com2013-03-011-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=110488 Reviewed by Anders Carlsson. The crash happens when building with /O2, where TextEncodingNameHash::equal is incorrectly optimized with the inlined toASCIILower and uses a register already in use. The function returns false incorrectly, causing a mismatch of text encoding name which then results in a null pointer access. Slightly rewording the use of the inline function lets the compiler produce correct code. The bug has already been reported and should be fixed in the next release of MSVS later this year. https://connect.microsoft.com/VisualStudio/feedback/details/777533/vs2012-c-optimizing-bug-when-using-inline-and-char-return-type-x86-target-only * platform/text/TextEncodingRegistry.cpp: Task-number: QTBUG-29719 Change-Id: I9fda5528ba3aefcd7c6b6c1042cf3ceb5e325b06 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144042 268f45cc-cd09-0410-ab3c-d52691b4dbfc Reviewed-by: Simon Hausmann <simon.hausmann@digia.com> Reviewed-by: Iikka Eklund <iikka.eklund@digia.com> Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
| * Fix massive parallel buildshausmann@webkit.org2013-03-012-2/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reviewed by Tor Arne Vestbø. There exists a race condition that LLIntDesiredOffsets.h is written to by two parllel instances of the ruby script. This patch ensures that similar to the output file, the generated file is also prefixed according to the build configuration. * LLIntOffsetsExtractor.pro: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144168 268f45cc-cd09-0410-ab3c-d52691b4dbfc Change-Id: Ibf60cf455c342fce5a4244aba788a2ad8e18e136 Reviewed-by: Iikka Eklund <iikka.eklund@digia.com>
| * define MODULE_VERSIONOswald Buddenhagen2013-02-271-0/+2
| | | | | | | | | | | | | | | | Task-number: QTBUG-29838 Change-Id: I33e8ca6d8f084f72fb0c80a993276bd0ec2dcfad Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> Reviewed-by: Simon Hausmann <simon.hausmann@digia.com> Reviewed-by: Iikka Eklund <iikka.eklund@digia.com>
| * Merge branch 'stable' into releaseJohanna Aijala2013-02-2195-494/+1942
| |\ | | | | | | | | | Change-Id: I5f9488665e344d270d876075e4a78d472e12a66f
* | | [Qt] Flash objects won't load until scrolling pageAllan Sandfeld Jensen2013-03-041-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=110149 Reviewed by Simon Hausmann. Revert r134222. The issue from bug 101836 is no longer reproducable, and the fix was causing flash objects to not load properly. * plugins/PluginPackage.cpp: (WebCore::PluginPackage::determineQuirks): Change-Id: If204d409a6d425022a4f7d21135803bb6f4c309d git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144191 268f45cc-cd09-0410-ab3c-d52691b4dbfc Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | | [TexMap] REGRESSION(144183): It make negative delay tests failsAllan Sandfeld Jensen2013-03-011-2/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=110989 Reviewed by Noam Rosenthal. Do not apply a negative offset to the animation starttime send to the GraphicLayerClient, it needs the actual animation start not a virtual start. * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp: (WebCore::GraphicsLayerTextureMapper::addAnimation): Change-Id: I29824c949eb3975aa3ef56a966296e1fac436b50 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144204 268f45cc-cd09-0410-ab3c-d52691b4dbfc Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | | [TexMap] Flickering after transitions on Apple HTML5 demoAllan Sandfeld Jensen2013-03-012-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=102501 Reviewed by Noam Rosenthal. Notify about animation start after the new animation is actually commited. * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp: (WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper): (WebCore::GraphicsLayerTextureMapper::commitLayerChanges): (WebCore::GraphicsLayerTextureMapper::addAnimation): * platform/graphics/texmap/GraphicsLayerTextureMapper.h: (GraphicsLayerTextureMapper): Change-Id: Iee72191e03d2dba4c90e7d3ba70e0be3f165aead git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144183 268f45cc-cd09-0410-ab3c-d52691b4dbfc Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | | Revert "[TexMap] Flickering after transitions on Apple HTML5 demo"Allan Sandfeld Jensen2013-03-013-91/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 99be50464a52281c481dd8221144603fed582aa0. This change caused a regression and was undone in trunk. Change-Id: Ic04eb4a5b49c354c129ed5d8c4bbe8cc579dc8f1 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | | [SVG] OOB access in SVGListProperty::replaceItemValues()Allan Sandfeld Jensen2013-02-287-54/+107
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=109293 Source/WebCore: Replacing a list property item with itself should be a no-op. This patch updates the related APIs and logic to detect the self-replace case and prevent removal of the item from the list. To avoid scanning the list multiple times, removeItemFromList() is updated to operate on indices and a findItem() method is added to resolve an item to an index. Reviewed by Dirk Schulze. No new tests: updated existing tests cover the change. * svg/properties/SVGAnimatedListPropertyTearOff.h: (WebCore::SVGAnimatedListPropertyTearOff::findItem): (SVGAnimatedListPropertyTearOff): (WebCore::SVGAnimatedListPropertyTearOff::removeItemFromList): * svg/properties/SVGAnimatedPathSegListPropertyTearOff.h: (WebCore::SVGAnimatedPathSegListPropertyTearOff::findItem): (SVGAnimatedPathSegListPropertyTearOff): (WebCore::SVGAnimatedPathSegListPropertyTearOff::removeItemFromList): Add a findItem() delegating method, and update removeItemFromList() to use the new index-based API. * svg/properties/SVGListProperty.h: (WebCore::SVGListProperty::insertItemBeforeValues): (WebCore::SVGListProperty::insertItemBeforeValuesAndWrappers): (WebCore::SVGListProperty::replaceItemValues): (WebCore::SVGListProperty::replaceItemValuesAndWrappers): (SVGListProperty): Updated to handle the no-op case for insertItemBefore() & replaceItem(). * svg/properties/SVGListPropertyTearOff.h: (WebCore::SVGListPropertyTearOff::findItem): (WebCore::SVGListPropertyTearOff::removeItemFromList): Index-based API updates. (WebCore::SVGListPropertyTearOff::processIncomingListItemValue): (WebCore::SVGListPropertyTearOff::processIncomingListItemWrapper): * svg/properties/SVGPathSegListPropertyTearOff.cpp: (WebCore::SVGPathSegListPropertyTearOff::processIncomingListItemValue): Detect the self-replace case and return without removing the item from the list. * svg/properties/SVGPathSegListPropertyTearOff.h: (WebCore::SVGPathSegListPropertyTearOff::findItem): (WebCore::SVGPathSegListPropertyTearOff::removeItemFromList): (SVGPathSegListPropertyTearOff): (WebCore::SVGPathSegListPropertyTearOff::processIncomingListItemWrapper): * svg/properties/SVGStaticListPropertyTearOff.h: (WebCore::SVGStaticListPropertyTearOff::processIncomingListItemValue): (WebCore::SVGStaticListPropertyTearOff::processIncomingListItemWrapper): Index-based API updates. Change-Id: I6afa8ff964eaccd1337156af41c5ded07e3b4b7d git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142759 268f45cc-cd09-0410-ab3c-d52691b4dbfc Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | | Regression(r131539): Heap-use-after-free in ↵Allan Sandfeld Jensen2013-02-285-36/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | WebCore::RenderBlock::willBeDestroyed https://bugs.webkit.org/show_bug.cgi?id=107189 Reviewed by Abhishek Arya. Source/WebCore: Test: fast/dynamic/continuation-detach-crash.html This patch reverts r131539 and the following changes (r132591 and r139664). This means we redo detaching from the bottom-up which solves the regression. It fixes the attached test case as we re-attach child nodes before detaching the parent. It seems wrong to do but this avoid a stale continuation. * dom/ContainerNode.cpp: (WebCore::ContainerNode::detach): Detach the children first, then ourself. * dom/Node.cpp: (WebCore::Node::detach): Clear the renderer instead of ASSERT'ing. * rendering/RenderObject.cpp: (WebCore::RenderObject::willBeDestroyed): Removed the code to clear the associated node's renderer. (WebCore::RenderObject::destroyAndCleanupAnonymousWrappers): * rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::removeChildNode): Moved the repainting logic back into removeChildNode from destroyAndCleanupAnonymousWrappers. (WebCore::RenderObjectChildList::destroyLeftoverChildren): Re-added the code to clear the associated node's renderer. * rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::setText): Re-added the code to set the associated node's renderer. * dom/ContainerNode.cpp: (WebCore::ContainerNode::detach): * dom/Node.cpp: (WebCore::Node::detach): * rendering/RenderObject.cpp: (WebCore::RenderObject::willBeDestroyed): (WebCore::RenderObject::destroyAndCleanupAnonymousWrappers): * rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::destroyLeftoverChildren): (WebCore::RenderObjectChildList::removeChildNode): * rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::setText): Change-Id: I5c4df1881f041ecd80180cb1638cd811d0972189 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142500 268f45cc-cd09-0410-ab3c-d52691b4dbfc Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | | ASSERTION FAILED: !object || object->isBox(), UNKNOWN in ↵Levi Weintraub2013-02-282-7/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | WebCore::RenderListItem::positionListMarker https://bugs.webkit.org/show_bug.cgi?id=108699 Reviewed by Abhishek Arya. Source/WebCore: RenderListItems performs special management of its children to maintain list markers. Splitting a flow through a list item results in assumptions made inside RenderListItem failing, so for now, avoid splittin flows when inside one. Test: fast/multicol/span/list-multi-column-crash.html * rendering/RenderBlock.cpp: (WebCore::RenderBlock::containingColumnsBlock): LayoutTests: * fast/multicol/span/list-multi-column-crash-expected.txt: Added. * fast/multicol/span/list-multi-column-crash.html: Added. Change-Id: If570c787773fbc69cecbb60833be32c445f2dc2b git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142657 268f45cc-cd09-0410-ab3c-d52691b4dbfc Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | | REGRESSION (r135628-135632): Double box shadow failure to renderjunov2013-02-282-24/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=107833 Reviewed by Simon Fraser. Source/WebCore: Regression caused by http://trac.webkit.org/changeset/135629 The regression was due to faulty occlusion logic that was assuming that drawing the background color of a render box background layer could be skipped when the same layer also has an opaque image attached. In the case where the background color is drawn for the purpose of rendering a box shadow, the shadow is typically not completely occluded by the background image because of the shadow blur and/or offset. This patch fixes the problem by not culling a background draw if it is used to draw a box shadow. Test: fast/backgrounds/gradient-background-shadow.html * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): Changing occlusion culling test to never cull background color draw if it is used to draw a box shadow. This is because box shadows can draw outside the border fill region. LayoutTests: New ref test verifies that box shadow is drawn when background is an opaque image. Test uses an blue gradient as background image. Reference uses blue background color. * fast/backgrounds/gradient-background-shadow-expected.html: Added. * fast/backgrounds/gradient-background-shadow.html: Added. Change-Id: I81e3271f1fdc312fd54dcd9de81903b12b1a9903 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141160 268f45cc-cd09-0410-ab3c-d52691b4dbfc Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | | remove obsolete DEPENDPATH assignmentOswald Buddenhagen2013-02-211-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | qmake now adds CONFIG+=depend_includepath by default, making manual DEPENDPATH setup unnecessary. Change-Id: I8fc3af40b91deae28872ea50e3d853f2f6f429cd Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@digia.com> Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
* | | fix pkg-config dependenciesOswald Buddenhagen2013-02-211-4/+0
| |/ |/| | | | | | | | | | | | | | | don't override QMAKE_PKGCONFIG_REQUIRES needlessly. Task-number: QTBUG-29453 Change-Id: Ib680caca686b6bc59e05ff5118cdbf7c53f32df5 Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@digia.com> Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
* | [Qt] Fix compilation if Qt was configured with -no-rtti ↵Andras Becsi2013-02-202-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=110234 Backport of https://trac.webkit.org/r143350. Reviewed by Noam Rosenthal. Availability of dynamic_cast should be checked. Task-number: QTBUG-29723 * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp: (WebCore::GraphicsLayerTextureMapper::updateBackingStoreIfNeeded): Change-Id: I983d17256164e86b2db3bad98093429e0469a9aa Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
* | Skip the build with a warning if certain tools cannot be found in the PATH ↵hausmann@webkit.org2013-02-193-3/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=110215 Reviewed by Tor Arne Vestbø. Check that gperf, python, ruby, perl, bison and flex are in the PATH before continuing the build. Otherwise skip with an error message explaining which programs are missing from the build. * qmake/mkspecs/features/configure.prf: * qmake/mkspecs/features/functions.prf: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@143326 268f45cc-cd09-0410-ab3c-d52691b4dbfc Change-Id: Iff2331e681d421c1ef0f476c73c9a05ebcfcbec1 Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
* | [TexMap] Flickering after transitions on Apple HTML5 demoAllan Sandfeld Jensen2013-02-193-6/+91
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=102501 Patch by Alexander Paschenko <alexander.pashenko@lge.com> on 2013-01-25 Reviewed by Noam Rosenthal. The problem is caused by inconsistent state of TextureMapperLayer's transformation matrix and opacity data during and after the end of animation. This patch solves the problem by introducing three additional private flags to TextureMapperLayer: m_shouldUpdateCurrentTransformFromGraphicsLayer, m_shouldUpdateCurrentOpacityFromGraphicsLayer, and m_shouldUpdateCurrentFiltersFromGraphicsLayer. The latter has been introduced in order to avoid similar future problems with m_currentFilters. On these flags' basis, TextureMapperLayer is able to decide whether to update its inner state or not. These flags themselves are set based on GraphicsLayerTextureMapper's changeMask which indicates what details of the state have been changed since the last sync. No new tests - this doesn't expose any testable surface. Eyes-only check has been made to ensure that the problem is gone now. * platform/graphics/texmap/TextureMapperLayer.cpp: (WebCore::TextureMapperLayer::setAnimatedTransform): sets m_shouldUpdateCurrentTransformFromGraphicsLayer to false and updates m_currentTransform based on the updated state from GraphicsLayerAnimation. (WebCore): (WebCore::TextureMapperLayer::setAnimatedOpacity): sets m_shouldUpdateCurrentOpacityFromGraphicsLayer to false and updates m_currentOpacity based on the updated state from GraphicsLayerAnimation. (WebCore::TextureMapperLayer::setAnimatedFilters): sets m_shouldUpdateCurrentFiltersFromGraphicsLayer to false and updates m_currentFilters based on the updated state from GraphicsLayerAnimation. (WebCore::TextureMapperLayer::flushCompositingStateForThisLayerOnly): sets m_shouldUpdateCurrent* flags based on GLTM's changeMask. Also illegal modification of m_currentTransform that caused flickering has been removed from this method. (WebCore::TextureMapperLayer::syncAnimations): updates m_currentTransform and/or m_currentOpacity and/or m_currentFilters if corresponding flags allow to do so. * platform/graphics/texmap/TextureMapperLayer.h: (WebCore::TextureMapperLayer::TextureMapperLayer): aforementioned flags get initialized in ctor. (TextureMapperLayer): aforementioned flags are declared in the class. Change-Id: I550dfbd523e59d366dc6e52400d9e8b1d636635d git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140825 268f45cc-cd09-0410-ab3c-d52691b4dbfc Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | Disable the build if certain configure checks fail ↵commit-queue@webkit.org2013-02-182-3/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=110094 Patch by Simon Hausmann <simon.hausmann@digia.com> on 2013-02-18 Reviewed by Tor Arne Vestbø. Allow for the build to be skipped (clear out SUBDIRS) if certain configure conditions aren't met. * qmake/mkspecs/features/configure.prf: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@143201 268f45cc-cd09-0410-ab3c-d52691b4dbfc Change-Id: I4ceb213c728dd42391a3920073fe5cda9a279a0c Reviewed-by: Tobias Koenig Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
* | [Qt] Don't crash on exit when encountering uninitialized WebView.Milian Wolff2013-02-151-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=107812 When a WebView is never shown it will not initialize its root layer and can thus crash on exit when trying to clean up said layers children. This was fixed properly upstream in commit 18ac4c73a2 but according to Jocelyn it cannot be cherry-picked easily due to dependencies on other changes. Change-Id: I58f5df8d3cd2756ac4f0b0c6a60b19c5c5ef27e8 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | Changing WebView.contentY and WebView.contentX does not redraw contentAndras Becsi2013-02-141-5/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=108337 https://bugreports.qt-project.org/browse/QTBUG-29557 Reviewed by Jocelyn Turcotte. We should not ignore content position changes unless pinch zoom or bounce-back animation is ongoing. This way we notify the web process about visible rect changes if the contentX and contentY properties are used to programmatically scroll the content from QML. One important usecase for this is when implementing scrollbars. Change-Id: If54453081debee7ad9f8c003b1bd54c5b0927fc9 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com> Reviewed-by: Andras Becsi <andras.becsi@digia.com>
* | [Qt][WK2] Pages / resources cannot be loaded from qrc files.michael.bruning@digia.com2013-02-137-0/+98
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=107031 Reviewed by Jocelyn Turcotte. Enables WebKit2 Qt applications to load files from the bundled qrc files. This is achieved by adding a url scheme handler for the "qrc" scheme using the application scheme handler and ignoring all handlers for the qrc application scheme that the application might set. * UIProcess/API/qt/qquickurlschemedelegate.cpp: (QQuickQrcSchemeDelegate::QQuickQrcSchemeDelegate): (QQuickQrcSchemeDelegate::readResourceAndSend): * UIProcess/API/qt/qquickurlschemedelegate_p.h: (QQuickQrcSchemeDelegate): * UIProcess/API/qt/qquickwebview.cpp: (QQuickWebViewPrivate::initialize): (QQuickWebViewExperimental::schemeDelegates_Append): (QQuickWebViewExperimental::invokeApplicationSchemeHandler): * UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml: * UIProcess/API/qt/tests/qmltests/common/qrctest.html: Added. * UIProcess/API/qt/tests/qmltests/resources.qrc: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140676 268f45cc-cd09-0410-ab3c-d52691b4dbfc Change-Id: Ia1cbd499ff9d1ca03373f6fb542d41f25231d656 Reviewed-by: Andras Becsi <andras.becsi@digia.com>
* | [JSC] REGRESSION(r135093): A form control with name=length overrides length ↵Ryosuke Niwa2013-02-123-1/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | property on form.elements https://bugs.webkit.org/show_bug.cgi?id=105775 Reviewed by Sam Weinig. Source/WebCore: Fixed the bug by respecting properties on ancestor classes. Test: fast/dom/collection-length-should-not-be-overridden.html * bindings/js/JSDOMBinding.h: (WebCore::getStaticValueSlotEntryWithoutCaching): Added. * bindings/scripts/CodeGeneratorJS.pm: (GenerateGetOwnPropertySlotBody): Use getStaticValueSlotEntryWithoutCaching to climb up the class hierarchy. Change-Id: Ib7520fc576d355978f56371e38b616633b2d1143 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139278 268f45cc-cd09-0410-ab3c-d52691b4dbfc Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | REGRESSION: ChildrenAffectedBy flags lost between siblings which have child ↵Allan Sandfeld Jensen2013-02-074-11/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | elements sharing style https://bugs.webkit.org/show_bug.cgi?id=105672 Reviewed by Andreas Kling. Change in how childrenAffectedBy bits were stored made it easier to trigger an issue where childrenAffectedBy bits were not set due to sharing of styles between cousin elements. This patch fixes the issue by not sharing styles from children with parents who prevent sharing. Tests: fast/selectors/cousin-stylesharing-adjacent-selector.html fast/selectors/cousin-stylesharing-last-child-selector.html * css/StyleResolver.cpp: (WebCore::parentElementPreventsSharing): (WebCore::StyleResolver::locateCousinList): * dom/Element.cpp: (WebCore::Element::hasFlagsSetDuringStylingOfChildren): * dom/Element.h: (Element): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141093 268f45cc-cd09-0410-ab3c-d52691b4dbfc Change-Id: I333eb08622790a1be96287abca38e0d1efb49de6 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | Regression(r129944): Heap-use-after-free in ↵Xianzhu Wang2013-02-072-0/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | WebCore::computeNonFastScrollableRegion https://bugs.webkit.org/show_bug.cgi?id=99515 Reviewed by Simon Fraser. The object used-after-freed is a destructed FrameView that is still in the m_scrollableAreas set of the parent FrameView. Actually it has been removed from m_scrollableAreas when setParent(0), but then is added back in updateScrollableAreaSet() because its frameViewParent() is still not 0 (though parent() is already 0). No new tests. The heap-use-after-free doesn't always cause crash so it can't be stably tested with a test case. Memory analysis tools like asan discovered the heap-use-after-free and verified that the patch can fix the issue. * page/FrameView.cpp: (WebCore::FrameView::parentFrameView): Checks if the FrameView has been removed from the parent. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138850 268f45cc-cd09-0410-ab3c-d52691b4dbfc Change-Id: I545d8815badad8d72781751e877f933ca8d31365 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | REGRESSION (r132591): Underpainting @ uofmchildrenshospital.orgJulien Chaffraix2013-02-072-2/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=105861 Reviewed by David Hyatt. Test: fast/repaint/overhanging-float-detach-repaint.html The issue comes from overhanging float not contributing to their containing block's overflow. This meant that repaint() would ignore them leading to an under-repaint. The fix is simple: force all the overhanging floats to repaint themselves. * rendering/RenderObject.cpp: (WebCore::RenderObject::destroyAndCleanupAnonymousWrappers): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139664 268f45cc-cd09-0410-ab3c-d52691b4dbfc Change-Id: I7555f2929578291c08a4d05e1b350a73ec10abff Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | SVG <use> element inside an svg-as-image failsStephen Chenney2013-02-072-8/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=104007 Reviewed by Eric Seidel. Upon redraw, SVGImage calls layout on the document it is drawing into the image if the image, provided it believes the redraw does not need to be delayed. Unfortunately, when an SVG <use> element is modified (by animation, say) and regenerates its shadow tree, the destructors invoke redraw, causing the SVGImage to call layout on something that is in the process of being deleted. That's bad. This change causes SVGImage to always delay the redraw. It is the most robust way to protect against this problem, as there may be any number of ways to cause this issue (a node being deleted in an svg-as-image target) and this protects against them all. The test case crashes in Asan Chromium. Source/WebCore: Test: svg/as-image/animated-use-as-image-crash.html * svg/graphics/SVGImageCache.cpp: (WebCore::SVGImageCache::imageContentChanged): Always redraw on the timer. LayoutTests: * platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.png: Changed as a result of this change. * svg/as-image/animated-use-as-image-crash-expected.txt: Added. * svg/as-image/animated-use-as-image-crash.html: Added. * svg/as-image/resources/animated-href-on-use.svg: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136845 268f45cc-cd09-0410-ab3c-d52691b4dbfc Change-Id: I83b299c26582db115bc921435f2c96da42f761d3 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | SVG pattern data deleted while in useFlorin Malita2013-02-073-67/+94
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=103415 Reviewed by Dirk Schulze. Various calls in RenderSVGResourcePattern::applyResource() can trigger invalidations, which may end up deleting our current pattern data (via removeAllClientsFromCache). To avoid this, we should add the pattern data to the cache only after it is fully built. For clarity, the patch also refactors the pattern setup code into a separate method. Test: svg/custom/large-image-pattern-crash.html * rendering/svg/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::buildPattern): (WebCore::RenderSVGResourcePattern::applyResource): * rendering/svg/RenderSVGResourcePattern.h: (RenderSVGResourcePattern): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136250 268f45cc-cd09-0410-ab3c-d52691b4dbfc Change-Id: I1ad128e056f7825727e2d1a9f365dd5f1aa2e4fa Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | [Qt][WK1] Remember denied permission for notificationsAllan Sandfeld Jensen2013-02-066-9/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=107694 Reviewed by Jocelyn Turcotte. Store denied permissions. According to the specification, we should ask the user again if he has already granted or denied permission. * WebCoreSupport/NotificationPresenterClientQt.cpp: (WebCore::NotificationPresenterClientQt::requestPermission): (WebCore::NotificationPresenterClientQt::setNotificationsAllowedForFrame): * WebCoreSupport/NotificationPresenterClientQt.h: (NotificationPresenterClientQt): * WebCoreSupport/QWebPageAdapter.cpp: (QWebPageAdapter::setNotificationsAllowedForFrame): * WebCoreSupport/QWebPageAdapter.h: * WidgetApi/qwebpage.cpp: (QWebPage::setFeaturePermission): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141233 268f45cc-cd09-0410-ab3c-d52691b4dbfc Change-Id: I71896cb6e91531aec32e5f55c2224783a391a110 Reviewed-by: jocelyn.turcotte@digia.com Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | [Qt][WK1] Permission request callbacks for non-legacy notificationsAllan Sandfeld Jensen2013-02-063-5/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=107438 Reviewed by Jocelyn Turcotte. Tracks the new callbacks the same way legacy callbacks are tracked. No test affected yet as we are still lacking support for testing feature permission callbacks. * WebCoreSupport/NotificationPresenterClientQt.cpp: (WebCore::NotificationPresenterClientQt::requestPermission): (WebCore::NotificationPresenterClientQt::allowNotificationForFrame): * WebCoreSupport/NotificationPresenterClientQt.h: (NotificationPresenterClientQt): (CallbacksInfo): Change-Id: Ia01ec54c2d55fac59c6a245757f44ce507a3ef19 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140330 268f45cc-cd09-0410-ab3c-d52691b4dbfc Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | [Qt] Box shadows on a transparency layer is very slowAllan Sandfeld Jensen2013-02-062-3/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=107547 Reviewed by Noam Rosenthal. Include the window boundaries in the clip returned by GraphicsContext, since QPainter may remember clips larger than the destination, but ShadowBlur uses the clipBounds to determine the size of the shadow layer. * platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clipBounds): Change-Id: Icb53ad7001420bd3bd9c2105c3ae8dcc7bc49d8c git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141413 268f45cc-cd09-0410-ab3c-d52691b4dbfc Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | Restrictions on oversize CopiedBlock allocations should be relaxedMark Hahnenberg2013-02-0610-27/+81
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=105339 Reviewed by Filip Pizlo. Currently the DFG has a single branch in the inline allocation path for property/array storage where it checks to see if the number of bytes requested will fit in the current block. This does not match what the C++ allocation path does; it checks if the requested number of bytes is oversize, and then if it's not, it tries to fit it in the current block. The garbage collector assumes that ALL allocations that are greater than 16KB are in oversize blocks. Therefore, this mismatch can lead to crashes when the collector tries to perform some operation on a CopiedBlock. To avoid adding an extra branch to the inline allocation path in the JIT, we should make it so that oversize blocks are allocated on the same alignment boundaries so that there is a single mask to find the block header of any CopiedBlock (rather than two, one for normal and one for oversize blocks), and we should figure out if a block is oversize by some other method than just whatever the JSObject says it is. One way we could record this info Region of the block, since we allocate a one-off Region for oversize blocks. * heap/BlockAllocator.h: (JSC::Region::isCustomSize): (Region): (JSC::Region::createCustomSize): (JSC::Region::Region): (JSC::BlockAllocator::deallocateCustomSize): * heap/CopiedBlock.h: (CopiedBlock): (JSC::CopiedBlock::isOversize): (JSC): * heap/CopiedSpace.cpp: (JSC::CopiedSpace::tryAllocateOversize): (JSC::CopiedSpace::tryReallocate): (JSC::CopiedSpace::tryReallocateOversize): * heap/CopiedSpace.h: (CopiedSpace): * heap/CopiedSpaceInlines.h: (JSC::CopiedSpace::contains): (JSC::CopiedSpace::tryAllocate): (JSC): * heap/CopyVisitor.h: (CopyVisitor): * heap/CopyVisitorInlines.h: (JSC::CopyVisitor::checkIfShouldCopy): (JSC::CopyVisitor::didCopy): * heap/SlotVisitorInlines.h: (JSC::SlotVisitor::copyLater): * runtime/JSObject.cpp: (JSC::JSObject::copyButterfly): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138067 268f45cc-cd09-0410-ab3c-d52691b4dbfc Change-Id: Icebcfe83d82ace7c3e1db6a979306f604459c5ae Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | Butterfly::growArrayRight shouldn't be called on null Butterfly objectsMark Hahnenberg2013-02-064-3/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=105221 Reviewed by Filip Pizlo. Currently we depend upon the fact that Butterfly::growArrayRight works with null Butterfly objects purely by coincidence. We should add a new static function that null checks the old Butterfly object and creates a new one if it's null, or calls growArrayRight if it isn't for use in the couple of places in JSObject that expect such behavior to work. * runtime/Butterfly.h: (Butterfly): * runtime/ButterflyInlines.h: (JSC::Butterfly::createOrGrowArrayRight): (JSC): * runtime/JSObject.cpp: (JSC::JSObject::createInitialIndexedStorage): (JSC::JSObject::createArrayStorage): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137961 268f45cc-cd09-0410-ab3c-d52691b4dbfc Change-Id: I643bc988f3e25b6f05be4e99f19fd2dc609152e4 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | substitute fixed version numbers in qdocconf files with variablesOswald Buddenhagen2013-02-061-2/+2
| | | | | | | | | | Change-Id: I132cd94b9507ee55c8421b7297c4a38fb3b7fd04 Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
* | Merge branch 'release' into stableSergio Ahumada2013-01-313-3/+18
|\ \ | |/ | | | | | | | | | | | | Conflicts: Source/WebCore/ChangeLog Source/WebKit/qt/ChangeLog Change-Id: Id01082a2a19811f59b08068331a658afe9eefbdb
| * [Qt] Crash in gmail on enabling desktop notificationsv5.0.1Allan Sandfeld Jensen2013-01-281-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=106699 Patch by David Rosca. Reviewed by Jocelyn Turcotte. Protect against callback that may be null. This also matches WebKit2 behaviour. * WebCoreSupport/NotificationPresenterClientQt.cpp: (WebCore::NotificationPresenterClientQt::allowNotificationForFrame): Change-Id: Ic8e421c4c6948b6dc5578355b41e754b5beca723 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
| * [Qt] Horizontal scrollbars events are offseted making them difficult to useMichael Brüning2013-01-286-1/+113
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=105014 Reviewed by Allan Sandfeld Jensen. Patch co-authored by Simon Hausmann. Only copy the layout direction from the facade options if the current option is Qt::LayoutDirectionAuto in order to prevent misinterpretations as different layout direction when hit testing. Tests added to tst_qwebview and tst_qgraphicswebview to verify that the view actually is scrolled in the right direction. * WidgetSupport/QStyleFacadeImp.cpp: (WebKit::initGenericStyleOption): * tests/qgraphicswebview/resources/scrolltest_page.html: Added. * tests/qgraphicswebview/tst_qgraphicswebview.cpp: (tst_QGraphicsWebView): (tst_QGraphicsWebView::horizontalScrollbarTest): * tests/qgraphicswebview/tst_qgraphicswebview.qrc: * tests/qwebview/resources/scrolltest_page.html: Added. * tests/qwebview/tst_qwebview.cpp: (tst_QWebView): (tst_QWebView::horizontalScrollbarTest): * tests/qwebview/tst_qwebview.qrc: [Qt] Apply correct patch for the scrolling issue from bug 105014 https://bugs.webkit.org/show_bug.cgi?id=106219 Correct the if condition when overwriting the layout direction option with the values from the facade options to only overwrite if the facade direction is not equal to LayoutDirectionAuto. Reviewed by Allan Sandfeld Jensen. * WidgetSupport/QStyleFacadeImp.cpp: (WebKit::initGenericStyleOption): Change-Id: I8a8c8d483beabf304cb2cdf63276cba61600138d Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
| * [Qt] Fix a crash when the QQuickWebPage is destroyed between the scene graph ↵Jocelyn Turcotte2013-01-283-14/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | sync and render. https://bugs.webkit.org/show_bug.cgi?id=106018 Reviewed by Simon Hausmann. The main and rendering threads are only guaranteed to be synchronised in the updatePaintNode call. In every other cases, QQuickItems cannot be safely accessed from the rendering thread. Do as the first patch version in https://bugs.webkit.org/show_bug.cgi?id=104574 was doing and copy the ratio value directly to fix the issue. Also add a note about the threading issue in QQuickWebPage::updatePaintNode. * UIProcess/API/qt/qquickwebpage.cpp: (QQuickWebPage::updatePaintNode): * UIProcess/qt/QtWebPageSGNode.cpp: (WebKit::QtWebPageSGNode::QtWebPageSGNode): * UIProcess/qt/QtWebPageSGNode.h: (QtWebPageSGNode): (WebKit::QtWebPageSGNode::devicePixelRatio): (WebKit::QtWebPageSGNode::setDevicePixelRatio): Change-Id: I2ef35f357c56c251033573d4435ddd7768a4422f Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
| * [Qt] Webkit debug build links against release binaries of ANGLE libEGL, ↵michael.bruning@digia.com2013-01-242-1/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | libGLESv2 https://bugs.webkit.org/show_bug.cgi?id=106217 Patch by Kai Koehne <kai.koehne@digia.com> on 2013-01-24 Reviewed by Jocelyn Turcotte. Use libEGLd, libEGLSv2d if qtbase was compiled with ANGLE. * WebCore.pri: Mirror logic of qtbase\mkspecs\features\win32\opengl.prf Change-Id: Iad260dbc0bd85ba45c4cd8ccfd5e12f5bef52998 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140675 268f45cc-cd09-0410-ab3c-d52691b4dbfc Reviewed-by: Michael Bruning <michael.bruning@digia.com> Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
View Lorry Controller Status