summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Doc: Added detailed description for WebViewstableVenu2014-06-163-22/+39
| | | | | | | | | | | Moved the description from the overview page to the WebView type documentation. Also added an image corresponding to the snippet used. Task-number: QTBUG-36179 Change-Id: Iaf4207a36f774d93af9a881eae2162d44837eeee Reviewed-by: Jerome Pasion <jerome.pasion@digia.com> Reviewed-by: Topi Reiniö <topi.reinio@digia.com>
* [mips] Add floating point absolute support in JavaScriptCore.Julien Brianceau2014-06-102-3/+16
| | | | | Change-Id: I8b03fb0380fa444a6da239d8ddb19bdbe6b3d061 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
* Prevent register clobbering to fix negative zero check in SoftModulo.Julien Brianceau2014-06-061-1/+7
| | | | | | | | This fix is not relevant for x86 architectures. Covered by integer-division-neg2tothe32-by-neg1 JavaScript test. Change-Id: I8ffd1280063305bc98c564f5df57c76cc5b1d7a6 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
* [mips] Fix branchTruncateDoubleToUint32 implementation in macro assembler.Julien Brianceau2014-06-051-1/+1
| | | | | | | Test dfg-uint32array-overflow-values fails without this patch. Change-Id: Ia186ab5c3fbc19fd7621f5cc60678b82a6424641 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
* Do not crash or assert on SVG font fallbacksAllan Sandfeld Jensen2014-06-051-2/+2
| | | | | | | | | Fonts falling back to SVG fonts may not have a rendering context, so just skip kerning in this case. Task-number: QTBUG-38356 Change-Id: I9d1473bbb8517bfae927e7b020a9c2102c6497b4 Reviewed-by: Michael Bruning <michael.bruning@digia.com>
* Avoid deep copy when updating BitmapTextureGLAllan Sandfeld Jensen2014-06-051-1/+12
| | | | | | | | | | | Since we use a ImageBuffer to paint into a BitmapTextureGL, and ImageBuffer's always have an active painter, the convertion from QPixmap to QImage causes a deep copy of the content before it is uploaded to OpenGL. This copy is unnecessary and can be avoided by temporarily redirecting the QPaintDevice. Change-Id: I0106c0f6dfb9cc3fbbee943411fc8f6853df4f98 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* Ensure replaced tiles are repaintedAllan Sandfeld Jensen2014-06-042-8/+13
| | | | | | | | | | If a layer with a backing store is resized, we may replace some tiles that were not at maximum size. When that happens we need to ensure the replaced area is repainted, otherwise the content disappears until refreshed. Change-Id: Ie2f7796a2493a56ed5fc6cc4cea55f4ab9f38bbe Reviewed-by: Michael Bruning <michael.bruning@digia.com>
* Account for extra uncommitted memory size also in ASSERTs.Michael Brüning2014-06-041-1/+3
| | | | | | | | | | The fix for the stack layout in applications that are loading .NET libraries in addition did not update the assertions that make sure that the actual end of the stack is where it should be. Task-number: QTBUG-38067 Change-Id: Ib8be1228bc9f10baf8d3484bb280a3a5c8021ab8 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
* CopyLinkToClipboard should copy the URL onlyAllan Sandfeld Jensen2014-06-042-3/+4
| | | | | | | | | | | | | The addition of title information to the dragged or copied links, has caused the clipboard after CopyLinkToClipboard to paste the link title instead of the link URL when doing a simple paste. This paste removes the title from the MimeData so that QMimeData must return the text version of the URL when pasting text. Task-number: QTBUG-39341 Change-Id: Ia28ea0f0eda07a4133c5628b60db624a16ed9931 Reviewed-by: Michael Bruning <michael.bruning@digia.com>
* [CoordinatedGraphics] Segmentation fault at ↵Edit Balint2014-06-031-0/+4
| | | | | | | | | | | | | | | | | | | CoordinatedGraphicsScene::clearImageBackingContents https://bugs.webkit.org/show_bug.cgi?id=125776 Patch by Edit Balint <edbalint@inf.u-szeged.hu> on 2014-01-20 Reviewed by Csaba Osztrogonác. Unexpected behavior occurs in some test cases which leads to segmentation fault. * platform/graphics/texmap/coordinated/CompositingCoordinator.cpp: (WebCore::CompositingCoordinator::removeImageBacking): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162329 268f45cc-cd09-0410-ab3c-d52691b4dbfc Task-number: QTBUG-38841 Change-Id: I85699c26f9ec78d97d66cf734188ba7da7e2233e Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
* Deploy QML plugin type information to correct directory.Michael Brüning2014-05-162-1/+3
| | | | | | | | | | | | | This adds the plugins.qmltypes file to the list of files that are deployed to the qml/QtWebKit directory. This is needed e.g. for auto-completion in Creator. Patch co-authored with Fawzi Mohamed. Task-number: QTBUG-39013 Change-Id: Icce9a168a0558652b810ad16c89895e24a6fc6ef Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
* Images wastes time on prescaling before OpenGL paintingAllan Sandfeld Jensen2014-05-141-0/+4
| | | | | | | | | | | | WebCore prescale images under cirtain circumstances to work-around poor downscaling in the raster QPainter. This is however unnecessary and harmful to performance when using a OpenGL paint engine. This patch makes sure the prescaling logic is only used for the raster paint engine. Change-Id: I321894ee6adec097d827e9997ebf951960ee91a4 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* Fix animation errors with radio buttons and checkboxes on Windows.Michael Brüning2014-05-141-0/+3
| | | | | | | | | | The QWindowsVistaStyle used the animation state of the control's style object. Since this is the QWebView for controls used in QtWebKit, this leads to unpredictable painting behavior. Task-number: QTBUG-30072 Change-Id: I1ba572bfbf56745b8e85fd631a596c43aa2ba25a Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
* Fix scrollbar handles so it follows cursor position when on a pageAndy Shaw2014-05-131-1/+1
| | | | | | | | | | When a webpage contains a scrollbar as part of an element inside it then the scrollbar handle should be in sync with the cursor when the handle is moved. Task-number: QTBUG-38360 Change-Id: I1f5474ad9b5e8dc232b307f4c5927833577afe1b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
* Stop the clearContentsTimer when removing an image backing.Michael Brüning2014-05-091-1/+3
| | | | | | | | | | It creates a race condition that can lead to crashes when the WebView's visible property is set to false and the image backing is removed shortly after. Task-number: QTBUG-38841 Change-Id: I0775ba33fda9cee5f86ef50a4fbe048602564296 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* Fix leak of QSensors on QWebPage creationAllan Sandfeld Jensen2014-05-092-7/+16
| | | | | | | | | The WebCore page supplements are not deleted when the page is, so we need to track them in QWebPageAdapter and delete them there. Task-number: QTBUG-38857 Change-Id: Ib3e41074de3bebf00f017523d28efc1c923250f3 Reviewed-by: Michael Bruning <michael.bruning@digia.com>
* Fix crash in pixmapToImageData bindingAllan Sandfeld Jensen2014-05-081-2/+6
| | | | | | | | | | | | | The result of JSContextGetGlobalObject is a wrapper-object not a direct pointer to the global object. Instead access the global object directly since we are already using other parts of the internal JS API. The patch also adds a missing API shim that should be held when using the internal JS API. Task-number: QTBUG-38809 Change-Id: I76eccbbd6cb1b9fd3322596bb7d6a3f9b0e694b8 Reviewed-by: Michael Bruning <michael.bruning@digia.com>
* Origin spoofing possible due to inappropriate URL escape sequence decodingdarin@apple.com2014-05-071-1/+1
| | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=131837 rdar://problem/15211936 Reviewed by Anders Carlsson and Dave Hyatt. Tests: fast/dom/DOMURL/parsing.html fast/dom/HTMLAnchorElement/anchor-element-href-parsing.html * platform/URL.cpp: (WebCore::URL::host): Removed unnecessary call to decodeURLEscapeSequences, which caused problems and was not needed. Change-Id: Idddc6efe310389b8e68db2d8c312c2098121e6d9 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167480 268f45cc-cd09-0410-ab3c-d52691b4dbfc Reviewed-by: Michael Bruning <michael.bruning@digia.com>
* Fix problems with divot and lineStart mismatches.Mark Lam2014-05-0613-589/+529
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=118662. Reviewed by Oliver Hunt. Source/JavaScriptCore: r152494 added the recording of lineStart values for divot positions. This is needed for the computation of column numbers. Similarly, it also added the recording of line numbers for the divot positions. One problem with the approach taken was that the line and lineStart values were recorded independently, and hence were not always guaranteed to be sampled at the same place that the divot position is recorded. This resulted in potential mismatches that cause some assertions to fail. The solution is to introduce a JSTextPosition abstraction that records the divot position, line, and lineStart as a single quantity. Wherever we record the divot position as an unsigned int previously, we now record its JSTextPosition which captures all 3 values in one go. This ensures that the captured line and lineStart will always match the captured divot position. * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitCall): (JSC::BytecodeGenerator::emitCallEval): (JSC::BytecodeGenerator::emitCallVarargs): (JSC::BytecodeGenerator::emitConstruct): (JSC::BytecodeGenerator::emitDebugHook): - Use JSTextPosition instead of passing line and lineStart explicitly. * bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::emitExpressionInfo): - Use JSTextPosition instead of passing line and lineStart explicitly. * bytecompiler/NodesCodegen.cpp: (JSC::ThrowableExpressionData::emitThrowReferenceError): (JSC::ResolveNode::emitBytecode): (JSC::BracketAccessorNode::emitBytecode): (JSC::DotAccessorNode::emitBytecode): (JSC::NewExprNode::emitBytecode): (JSC::EvalFunctionCallNode::emitBytecode): (JSC::FunctionCallValueNode::emitBytecode): (JSC::FunctionCallResolveNode::emitBytecode): (JSC::FunctionCallBracketNode::emitBytecode): (JSC::FunctionCallDotNode::emitBytecode): (JSC::CallFunctionCallDotNode::emitBytecode): (JSC::ApplyFunctionCallDotNode::emitBytecode): (JSC::PostfixNode::emitResolve): (JSC::PostfixNode::emitBracket): (JSC::PostfixNode::emitDot): (JSC::DeleteResolveNode::emitBytecode): (JSC::DeleteBracketNode::emitBytecode): (JSC::DeleteDotNode::emitBytecode): (JSC::PrefixNode::emitResolve): (JSC::PrefixNode::emitBracket): (JSC::PrefixNode::emitDot): (JSC::UnaryOpNode::emitBytecode): (JSC::BinaryOpNode::emitStrcat): (JSC::BinaryOpNode::emitBytecode): (JSC::ThrowableBinaryOpNode::emitBytecode): (JSC::InstanceOfNode::emitBytecode): (JSC::emitReadModifyAssignment): (JSC::ReadModifyResolveNode::emitBytecode): (JSC::AssignResolveNode::emitBytecode): (JSC::AssignDotNode::emitBytecode): (JSC::ReadModifyDotNode::emitBytecode): (JSC::AssignBracketNode::emitBytecode): (JSC::ReadModifyBracketNode::emitBytecode): (JSC::ForInNode::emitBytecode): (JSC::WithNode::emitBytecode): (JSC::ThrowNode::emitBytecode): - Use JSTextPosition instead of passing line and lineStart explicitly. * parser/ASTBuilder.h: - Replaced ASTBuilder::PositionInfo with JSTextPosition. (JSC::ASTBuilder::BinaryOpInfo::BinaryOpInfo): (JSC::ASTBuilder::AssignmentInfo::AssignmentInfo): (JSC::ASTBuilder::createResolve): (JSC::ASTBuilder::createBracketAccess): (JSC::ASTBuilder::createDotAccess): (JSC::ASTBuilder::createRegExp): (JSC::ASTBuilder::createNewExpr): (JSC::ASTBuilder::createAssignResolve): (JSC::ASTBuilder::createExprStatement): (JSC::ASTBuilder::createForInLoop): (JSC::ASTBuilder::createReturnStatement): (JSC::ASTBuilder::createBreakStatement): (JSC::ASTBuilder::createContinueStatement): (JSC::ASTBuilder::createLabelStatement): (JSC::ASTBuilder::createWithStatement): (JSC::ASTBuilder::createThrowStatement): (JSC::ASTBuilder::appendBinaryExpressionInfo): (JSC::ASTBuilder::appendUnaryToken): (JSC::ASTBuilder::unaryTokenStackLastStart): (JSC::ASTBuilder::assignmentStackAppend): (JSC::ASTBuilder::createAssignment): (JSC::ASTBuilder::setExceptionLocation): (JSC::ASTBuilder::makeDeleteNode): (JSC::ASTBuilder::makeFunctionCallNode): (JSC::ASTBuilder::makeBinaryNode): (JSC::ASTBuilder::makeAssignNode): (JSC::ASTBuilder::makePrefixNode): (JSC::ASTBuilder::makePostfixNode): - Use JSTextPosition instead of passing line and lineStart explicitly. * parser/Lexer.cpp: (JSC::::lex): - Added support for capturing the appropriate JSTextPositions instead of just the character offset. * parser/Lexer.h: (JSC::Lexer::currentPosition): (JSC::::lexExpectIdentifier): - Added support for capturing the appropriate JSTextPositions instead of just the character offset. * parser/NodeConstructors.h: (JSC::Node::Node): (JSC::ResolveNode::ResolveNode): (JSC::EvalFunctionCallNode::EvalFunctionCallNode): (JSC::FunctionCallValueNode::FunctionCallValueNode): (JSC::FunctionCallResolveNode::FunctionCallResolveNode): (JSC::FunctionCallBracketNode::FunctionCallBracketNode): (JSC::FunctionCallDotNode::FunctionCallDotNode): (JSC::CallFunctionCallDotNode::CallFunctionCallDotNode): (JSC::ApplyFunctionCallDotNode::ApplyFunctionCallDotNode): (JSC::PostfixNode::PostfixNode): (JSC::DeleteResolveNode::DeleteResolveNode): (JSC::DeleteBracketNode::DeleteBracketNode): (JSC::DeleteDotNode::DeleteDotNode): (JSC::PrefixNode::PrefixNode): (JSC::ReadModifyResolveNode::ReadModifyResolveNode): (JSC::ReadModifyBracketNode::ReadModifyBracketNode): (JSC::AssignBracketNode::AssignBracketNode): (JSC::AssignDotNode::AssignDotNode): (JSC::ReadModifyDotNode::ReadModifyDotNode): (JSC::AssignErrorNode::AssignErrorNode): (JSC::WithNode::WithNode): (JSC::ForInNode::ForInNode): - Use JSTextPosition instead of passing line and lineStart explicitly. * parser/Nodes.cpp: (JSC::StatementNode::setLoc): - Use JSTextPosition instead of passing line and lineStart explicitly. * parser/Nodes.h: (JSC::Node::lineNo): (JSC::Node::startOffset): (JSC::Node::lineStartOffset): (JSC::Node::position): (JSC::ThrowableExpressionData::ThrowableExpressionData): (JSC::ThrowableExpressionData::setExceptionSourceCode): (JSC::ThrowableExpressionData::divot): (JSC::ThrowableExpressionData::divotStart): (JSC::ThrowableExpressionData::divotEnd): (JSC::ThrowableSubExpressionData::ThrowableSubExpressionData): (JSC::ThrowableSubExpressionData::setSubexpressionInfo): (JSC::ThrowableSubExpressionData::subexpressionDivot): (JSC::ThrowableSubExpressionData::subexpressionStart): (JSC::ThrowableSubExpressionData::subexpressionEnd): (JSC::ThrowablePrefixedSubExpressionData::ThrowablePrefixedSubExpressionData): (JSC::ThrowablePrefixedSubExpressionData::setSubexpressionInfo): (JSC::ThrowablePrefixedSubExpressionData::subexpressionDivot): (JSC::ThrowablePrefixedSubExpressionData::subexpressionStart): (JSC::ThrowablePrefixedSubExpressionData::subexpressionEnd): - Use JSTextPosition instead of passing line and lineStart explicitly. * parser/Parser.cpp: (JSC::::Parser): (JSC::::parseInner): - Use JSTextPosition instead of passing line and lineStart explicitly. (JSC::::didFinishParsing): - Remove setting of m_lastLine value. We always pass in the value from m_lastLine anyway. So, this assignment is effectively a nop. (JSC::::parseVarDeclaration): (JSC::::parseVarDeclarationList): (JSC::::parseForStatement): (JSC::::parseBreakStatement): (JSC::::parseContinueStatement): (JSC::::parseReturnStatement): (JSC::::parseThrowStatement): (JSC::::parseWithStatement): (JSC::::parseTryStatement): (JSC::::parseBlockStatement): (JSC::::parseFunctionDeclaration): (JSC::LabelInfo::LabelInfo): (JSC::::parseExpressionOrLabelStatement): (JSC::::parseExpressionStatement): (JSC::::parseAssignmentExpression): (JSC::::parseBinaryExpression): (JSC::::parseProperty): (JSC::::parsePrimaryExpression): (JSC::::parseMemberExpression): (JSC::::parseUnaryExpression): - Use JSTextPosition instead of passing line and lineStart explicitly. * parser/Parser.h: (JSC::Parser::next): (JSC::Parser::nextExpectIdentifier): (JSC::Parser::getToken): (JSC::Parser::tokenStartPosition): (JSC::Parser::tokenEndPosition): (JSC::Parser::lastTokenEndPosition): (JSC::::parse): - Use JSTextPosition instead of passing line and lineStart explicitly. * parser/ParserTokens.h: (JSC::JSTextPosition::JSTextPosition): (JSC::JSTextPosition::operator+): (JSC::JSTextPosition::operator-): (JSC::JSTextPosition::operator int): - Added JSTextPosition. * parser/SyntaxChecker.h: (JSC::SyntaxChecker::makeFunctionCallNode): (JSC::SyntaxChecker::makeAssignNode): (JSC::SyntaxChecker::makePrefixNode): (JSC::SyntaxChecker::makePostfixNode): (JSC::SyntaxChecker::makeDeleteNode): (JSC::SyntaxChecker::createResolve): (JSC::SyntaxChecker::createBracketAccess): (JSC::SyntaxChecker::createDotAccess): (JSC::SyntaxChecker::createRegExp): (JSC::SyntaxChecker::createNewExpr): (JSC::SyntaxChecker::createAssignResolve): (JSC::SyntaxChecker::createForInLoop): (JSC::SyntaxChecker::createReturnStatement): (JSC::SyntaxChecker::createBreakStatement): (JSC::SyntaxChecker::createContinueStatement): (JSC::SyntaxChecker::createWithStatement): (JSC::SyntaxChecker::createLabelStatement): (JSC::SyntaxChecker::createThrowStatement): (JSC::SyntaxChecker::appendBinaryExpressionInfo): (JSC::SyntaxChecker::operatorStackPop): - Use JSTextPosition instead of passing line and lineStart explicitly. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153477 268f45cc-cd09-0410-ab3c-d52691b4dbfc Task-number: QTBUG-38708 Change-Id: Ic6a65e8915c634dffe76b7181b38d6be0ab4a45d Reviewed-by: Michael Bruning <michael.bruning@digia.com>
* Update RenderImage when the image src is clearedspartha2014-05-063-4/+9
| | | | | | | | | | | | | | | When the src is removed via JavaScript, the image loader now updates the renderer. BUG=123017 Review URL: https://chromiumcodereview.appspot.com/20473002 git-svn-id: svn://svn.chromium.org/blink/trunk@155294 bbb929c8-8fbe-4397-9dbb-9b2b20218538 Task-number: QTBUG-38287 Change-Id: I49c353cfa4ad1f7c1ceac80df81b8cb713d291df Reviewed-by: Michael Bruning <michael.bruning@digia.com>
* Zooming transforms results in blurry backgroundsAllan Sandfeld Jensen2014-05-061-1/+1
| | | | | | | | | | | | | | An optimization to speedup pattern transforms results in blurry background images when using CSS transforms. This patch disables the optimization when QPainter already has a transform, and the optimization would be both wrong and probably slower. Test: svg/as-background-image/svg-transformed-background.html Task-number: QTBUG-38588 Change-Id: I58739e21fd925048bc91f0ac973fae2036bcf713 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* Reduce the command line length when generating bindingsJocelyn Turcotte2014-05-051-0/+8
| | | | | | | | | | | | | | | | | | With a working directory of only a few characters longer than our build machines it's easy to end up getting a "NMAKE : fatal error U1095" on Windows. Unlike when invoking the compiler or the linker, we do not use response files to pass to perl when generating JavaScript bindings. Reduce the likeliness of getting this error for people building QtWebKit themselves by avoiding specifying disabled features. The binding generators do not include Platform.h like the normal code does. Task-Number: QTBUG-38632 Change-Id: Iaa1a1c75e8f6a6391f896067adbc5f3b55b59007 Reviewed-by: Michael Bruning <michael.bruning@digia.com>
* Fix stack initialization when running under .NET.Sergio Martins2014-04-271-1/+8
| | | | | | | | | | | | | Under .NET, on WinXP and sometimes on Win7 we will have two blocks of uncommited memory before the guard page, so look one block further. In debug mode it would crash due to assert guardPage.Protect & PAGE_GUARD In release mode it would crash due to only using a 4K stack. Change-Id: If9f2c84122ba95a18403a8f413d080dd5cc58250 Reviewed-by: Michael Bruning <michael.bruning@digia.com>
* Merge "Merge remote-tracking branch 'origin/release' into stable" into ↵Jani Heikkinen2014-04-246-7/+8
|\ | | | | | | refs/staging/stable
| * Merge remote-tracking branch 'origin/release' into stableJani Heikkinen2014-04-236-7/+8
| |\ | | | | | | | | | Change-Id: Icd2b7e87cdd837d76f9bc11c65f6ee5a90407312
| | * Fix cast from QByteArray to QStringv5.3.0-rc1v5.3.0release5.3.0Allan Sandfeld Jensen2014-04-161-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | QUrl::toEncoded() returns a QByteArray which we should not try to append directly to a QString. Instead convert it first from ascii/latin1. Change-Id: I54fd1ef939cf25c81ad4f4ceab91fc4053b627ba Reviewed-by: Michael Bruning <michael.bruning@digia.com>
| | * Flash of garbage pixels when playing a show on HuluSimon Fraser2014-04-162-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | <https://webkit.org/b/119871> Source/WebCore: Reviewed by Tim Horton. When starting a show on Hulu, there's a layer that gets marked as opaque because it has a child RenderLayer whose background fills the compositing layer. That child RenderLayer was recently position:fixed but outside the viewport, so its viewportConstrainedNotCompositedReason was set to a non-zero value. However, we failed to clear the viewportConstrainedNotCompositedReason when the layer became non-fixed. This caused painting the opaque layer to bail in RenderLayer::paintLayer(), leaving garbage. Test: compositing/contents-opaque/fixed-to-nonfixed.html * rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): Add an assertion to catch this error in future. * rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateBacking): Make sure we clear the ViewportConstrainedNotCompositedReason if the layer is no longer fixed. Change-Id: Ie1aa935b8271cd8cc3159f5337d483a77d74b8a0 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154147 268f45cc-cd09-0410-ab3c-d52691b4dbfc Reviewed-by: Michael Bruning <michael.bruning@digia.com>
| | * Crash when submitting form in a document with null encodingRyosuke Niwa2014-04-161-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=123975 Reviewed by Alexey Proskuryakov. Source/WebCore: Merge https://chromium.googlesource.com/chromium/blink/+/bba01a7fff09e3053ada96ababac2a6e4261fe5f The CString object which is passed to normalizeLineEndingsToCRLF() can be a null string. It is created in FormDataList::appendString(), and it produces a null CString if FormDataList::m_encoding is a null encoding. Test: fast/forms/form-submit-in-image-document.html * platform/text/LineEnding.cpp: (internalNormalizeLineEndingsToCRLF): Change-Id: Ia36bcf292fb4d1da7e4bb21e2eddf1146eecd71c git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158868 268f45cc-cd09-0410-ab3c-d52691b4dbfc Reviewed-by: Michael Bruning <michael.bruning@digia.com>
| | * Fix build on AndroidAllan Sandfeld Jensen2014-04-162-5/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Atomic increment/decrement was defined twice on Android, and gamepad support doesn't build. This removesthe redundant definition, and disables gamepad support on android. Change-Id: I62ceae141564c4dec7a1b941ef832889e82736fb Reviewed-by: Michael Bruning <michael.bruning@digia.com> Reviewed-by: Sérgio Martins <sergio.martins@kdab.com>
| | * Fix rendering of WebKit2 QML WebView with ANGLE.Michael Bruning2014-04-100-0/+0
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | The WebKit2 QML WebView was not rendered on ANGLE builds due to a precision mismatch for a uniform matrix used in in both vertex and fragment shaders which made the ANGLE compiler bail out on linking the shader program. This was fixed by overriding the precision to highp in both shaders. Task-number: QTBUG-37043 Change-Id: I840f8e348d5de1c5900576e7d68c3f8ddcdfa4a7 Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
* | Do not try to create invalid sized XPixmapsAllan Sandfeld Jensen2014-04-241-4/+10
| | | | | | | | | | | | | | | | | | | | | | If a visible plugin is resized to an empty size we request an empty sized xpixmap which is illegal. Instead hide and only free the exiting drawable. Task-number: QTBUG-38541 Change-Id: I2cb3d221d656b1b18391c479168221bcd0aa73b1 Reviewed-by: Michael Bruning <michael.bruning@digia.com>
* | Fix build with clang on linuxAllan Sandfeld Jensen2014-04-238-17/+30
| | | | | | | | | | | | | | Fixes a few issues with clang builds using libstdc++ Change-Id: I68d3af2c48bce42e2c5319c517e9b57bed2b729a Reviewed-by: Michael Bruning <michael.bruning@digia.com>
* | Bump MODULE_VERSION to 5.3.1Sergio Ahumada2014-04-231-1/+1
|/ | | | | Change-Id: Icef24bc1b350ed0e382578b0c6509589097effcd Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
* [mips] Fix or32 implementation in macro assembler.Julien Brianceau2014-04-081-1/+3
| | | | | | | | This patch fixes JavaScript issues for the mips backend, especially in the DFG stage when using (x|0) expressions. Change-Id: I4c7c7280735481dc06ca24745d2e42b2d8e13ef5 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
* icc does not have option -Wno-c++0x-compatThiago Macieira2014-04-031-2/+2
| | | | | | | | It keeps printing while compiling QtWebKit: icpc: command line warning #10006: ignoring unknown option '-Wno-c++0x-compat' Change-Id: I63d1ec2c5bcdfda373f75a66e70daa95fb48d906 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
* Fix wrong VK keycodesAllan Sandfeld Jensen2014-04-031-2/+3
| | | | | | | | The two paren keycodes were reversed and the exclam key was not mapped Task-number: QTBUG-38031 Change-Id: I5614ed85a4c99792ca684bc4f1188631ccaa45d3 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* Fix warnings found by the headerclean testThiago Macieira2014-04-022-4/+4
| | | | | | | Extra semi-colons at the end of lines, arguments shadowing members, etc. Change-Id: I8163ed42da31b6a5bb37a56d8cf4c7b2e32139d3 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
* Fix compilation: missing typedef for uint32_tThiago Macieira2014-04-021-0/+1
| | | | | | | status.cc:12:3: error: ‘uint32_t’ was not declared in this scope Change-Id: Id6ea656937f8db39976603a504bcdd0c7559e488 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
* Set image drag hotspot from drag image origin.Allan Sandfeld Jensen2014-03-281-3/+4
| | | | | | | | | | | QtWebKit does not currently set the drag image origin, this cause any dragged image to always visibly jump as soon as the drag start. By setting the hotspot any dragged image will start at its origin and only move when then the mouse moves. Change-Id: I6cdfa1bdbcf79a63f26fc62442978f65aabd493b Reviewed-by: Michael Bruning <michael.bruning@digia.com>
* Fix crash on access of dead QMimeDataAllan Sandfeld Jensen2014-03-282-39/+27
| | | | | | | | | | | | | | | When we give a QMimeData to the system pasteboard, we should no longer access it locally. This patch ensures we invalidate the pointer to the QMimeDate once it has been uploaded to the system clipboard. To ensure we can still read values we have writen, the code to read the pasteboard data will now read it from the system pasteboard when applicable. Several places the latter was done manually have been removed. Task-number: QTBUG-37904 Change-Id: I9c37b2fcc58ebbc387319be39c190fd7db6f70eb Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* Fix loading nested mpegurls using GStreamerAllan Sandfeld Jensen2014-03-271-7/+24
| | | | | | | | | | | | | | | | | | If gstreamer tries to load an http source, we currently lose the context of where it is loaded from, which causes the load to fail. This patch caches a loading context when one is set on the outer most appsrc, and uses that for gstreamer requests until the outer most source is unloaded. This can have consequences if multiple webviews are open at the same time with different QNetworkAccessManagers, but this is considered unusual, and wouldn't work with the QtMultimedia either. Task-number: QTBUG-37636 Change-Id: I9d3b4d10705254629bc5fce7d76765077585caa2 Reviewed-by: Michael Bruning <michael.bruning@digia.com> Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* Mention default encoding for QML WebView loadHtml method in docs.Michael Brüning2014-03-251-0/+4
| | | | | | | | | | The fact that the html string will be implicitly converted to UTF-16 led to some errors with loaded resources. Task-number: QTBUG-36656 Change-Id: I6ed36e2e814034cfccb4082c24e3327674e04cdf Reviewed-by: Leena Miettinen <riitta-leena.miettinen@digia.com> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
* Doc: Put \qtvariable in module page backv5.3.0-beta1Sergio Ahumada2014-03-211-0/+1
| | | | | | | | | It was removed by d441d6f39bb846989d95bcf5caf387b42414718d for some reason. Change-Id: I333cf71dc5bf69b3a1f5aa04f5089e9fbd617c6b Reviewed-by: Jerome Pasion <jerome.pasion@digia.com> Reviewed-by: Topi Reiniö <topi.reinio@digia.com>
* Fix static buildsAllan Sandfeld Jensen2014-03-194-2/+9
| | | | | | | | | Disable WebKit2 since WTF from qtdeclarative conflicts with ours, and renable use of thin archives for static builds, except only use it for the intermediate staticlibs. Change-Id: Iee625c5d25f01d1700d4c89028578e4d1288e2ba Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* Fix compiler warnings when building Qt WebKitAllan Sandfeld Jensen2014-03-183-87/+91
| | | | | | | | Fix warnings about C++11 violating syntax, unused variables in leveldb and non anynomous classes deriving from anonymous ones. Change-Id: I39326eed03fabe2856f1ea7c93eff65f30ee78ee Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* Fix build: LLIntAssembly.h is in a subdir of generated/Thiago Macieira2014-03-171-1/+2
| | | | | | | | | ruby /home/thiago/src/qt/qt5/qtwebkit/Source/JavaScriptCore/offlineasm/asm.rb /home/thiago/src/qt/qt5/qtwebkit/Source/JavaScriptCore/llint/LowLevelInterpreter.asm LLIntOffsetsExtractor generated/LLIntOffsetsExtractor/LLIntAssembly.h offlineasm: Parsing /home/thiago/src/qt/qt5/qtwebkit/Source/JavaScriptCore/llint/LowLevelInterpreter.asm and LLIntOffsetsExtractor and creating assembly file generated/LLIntOffsetsExtractor/LLIntAssembly.h. Change-Id: If12f1476de74c3feeb5c6d6e2e115829e1106581 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
* Fix a documentation oversightPierre Rossi2014-03-171-2/+2
| | | | | | | | | We had forgotten a few substitutions in the process it would seem. Change-Id: I37297c39bea84b0d277784edb80e72eab8de7ca7 Reviewed-by: Simon Hausmann <simon.hausmann@digia.com> Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com> Reviewed-by: Pierre Rossi <pierre.rossi@gmail.com>
* Fix doc warningsJocelyn Turcotte2014-03-179-51/+20
| | | | | | | | | | - Qt for Embedded Linux Requirements isn't available since Qt5 - NOTIFY signal documentations are now ignored and are part of their property - The QtQuick1 WebView code isn't available anymore - Adjust to other renamed and removed pages Change-Id: Ife04becb1a847fb0bfb11dfafa6db2caa36aa9f0 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
* Fix link and image draggingAllan Sandfeld Jensen2014-03-121-11/+47
| | | | | | | | Ensure we can drag and drop images, and fix copying and dragging of links so the link title is correctly preserved. Change-Id: Ib257ee67405ac259c72387616b5d620b163c07b0 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* Fix dragging of selectionsAllan Sandfeld Jensen2014-03-121-19/+27
| | | | | | | | | | A regression from (r151091) broke drag and drop of selections. This patch restores the maintenance of the m_writableData which is used by DragClientQt. Task-number: QTBUG-37314 Change-Id: I9afa193daec53d8d5affa560b8f225bb7dc79470 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
View Lorry Controller Status