diff options
author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2017-03-29 12:59:19 +0200 |
---|---|---|
committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2017-03-30 22:16:47 +0000 |
commit | f799a226b1025bf7158bc00dff35ee060f57a137 (patch) | |
tree | 409168c9cc203681029ba2295bb54e4a24381257 /src/xmlpatterns/functions | |
parent | 2e07221d52162231755d1bd521478a899f47da19 (diff) | |
download | qtxmlpatterns-f799a226b1025bf7158bc00dff35ee060f57a137.tar.gz |
Cleanup implicit fallthroughs in xmlpatterns5.8
Use Q_FALLTHOUGH instead of comments, and use it consistently.
Change-Id: Ieaf4867b612e624774011275b90cdd3678a29fe9
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
Diffstat (limited to 'src/xmlpatterns/functions')
-rw-r--r-- | src/xmlpatterns/functions/qerrorfn.cpp | 5 | ||||
-rw-r--r-- | src/xmlpatterns/functions/qsystempropertyfn.cpp | 3 |
2 files changed, 3 insertions, 5 deletions
diff --git a/src/xmlpatterns/functions/qerrorfn.cpp b/src/xmlpatterns/functions/qerrorfn.cpp index 19e9440..90f18c0 100644 --- a/src/xmlpatterns/functions/qerrorfn.cpp +++ b/src/xmlpatterns/functions/qerrorfn.cpp @@ -61,10 +61,11 @@ Item ErrorFN::evaluateSingleton(const DynamicContext::Ptr &context) const return Item(); } case 3: - /* Fallthrough, we don't use the 'error object' param. */ + /* Fallthrough, we don't use the 'error object' param. */ + Q_FALLTHROUGH(); case 2: msg = m_operands.at(1)->evaluateSingleton(context).stringValue(); - /* Fall through. */ + Q_FALLTHROUGH(); case 1: { const QNameValue::Ptr qName(m_operands.first()->evaluateSingleton(context).as<QNameValue>()); diff --git a/src/xmlpatterns/functions/qsystempropertyfn.cpp b/src/xmlpatterns/functions/qsystempropertyfn.cpp index 188a9a6..71a8d68 100644 --- a/src/xmlpatterns/functions/qsystempropertyfn.cpp +++ b/src/xmlpatterns/functions/qsystempropertyfn.cpp @@ -85,11 +85,8 @@ QString SystemPropertyFN::retrieveProperty(const QXmlName name) case StandardLocalNames::product_version: return QLatin1String("0.1"); case StandardLocalNames::is_schema_aware: - /* Fallthrough. */ case StandardLocalNames::supports_backwards_compatibility: - /* Fallthrough. */ case StandardLocalNames::supports_serialization: - /* Fallthrough. */ return QLatin1String("no"); default: return QString(); |