diff options
author | Qt Forward Merge Bot <qt_forward_merge_bot@qt-project.org> | 2019-12-10 03:02:04 +0100 |
---|---|---|
committer | Qt Forward Merge Bot <qt_forward_merge_bot@qt-project.org> | 2019-12-10 03:02:04 +0100 |
commit | fd98985f82cd6a6bb71f4653455d2709c3da5b82 (patch) | |
tree | ac9845eaf48231ed615e571da4cf81c15db7f2ed /src | |
parent | 5caf6d31f90a502ad0ca7cd1e222d84e67b77259 (diff) | |
parent | b714eeba4163c03532ac9cd017095dba8932a81c (diff) | |
download | qtxmlpatterns-fd98985f82cd6a6bb71f4653455d2709c3da5b82.tar.gz |
Merge remote-tracking branch 'origin/5.15' into dev
Change-Id: I3eb54f906dc1ee8fedf64a4cde67edb3f8ce5460
Diffstat (limited to 'src')
-rw-r--r-- | src/xmlpatterns/schema/qxsdschemahelper.cpp | 2 | ||||
-rw-r--r-- | src/xmlpatterns/schema/qxsdvalidatinginstancereader.cpp | 10 |
2 files changed, 11 insertions, 1 deletions
diff --git a/src/xmlpatterns/schema/qxsdschemahelper.cpp b/src/xmlpatterns/schema/qxsdschemahelper.cpp index 843e7c5..1123e4f 100644 --- a/src/xmlpatterns/schema/qxsdschemahelper.cpp +++ b/src/xmlpatterns/schema/qxsdschemahelper.cpp @@ -518,7 +518,7 @@ bool XsdSchemaHelper::constructAndCompare(const DerivedString<TypeString>::Ptr & const ReportContext::Ptr &context, const SourceLocationReflection *const sourceLocationReflection) { - Q_ASSERT_X(type->category() == SchemaType::SimpleTypeAtomic, Q_FUNC_INFO, + Q_ASSERT_X(type && type->category() == SchemaType::SimpleTypeAtomic, Q_FUNC_INFO, "We can only compare atomic values."); // we can not cast a xs:String to a xs:QName, so lets go the safe way diff --git a/src/xmlpatterns/schema/qxsdvalidatinginstancereader.cpp b/src/xmlpatterns/schema/qxsdvalidatinginstancereader.cpp index 7661569..f1b4014 100644 --- a/src/xmlpatterns/schema/qxsdvalidatinginstancereader.cpp +++ b/src/xmlpatterns/schema/qxsdvalidatinginstancereader.cpp @@ -1113,6 +1113,7 @@ bool XsdValidatingInstanceReader::selectNodeSets(const XsdElement::Ptr&, const Q const QXmlNodeModelIndex index = fieldItem.toNodeModelIndex(); const SchemaType::Ptr type = m_model->assignedType(index); + Q_ASSERT(type); bool typeOk = true; if (type->isComplexType()) { @@ -1136,6 +1137,15 @@ bool XsdValidatingInstanceReader::selectNodeSets(const XsdElement::Ptr&, const Q targetType = XsdSimpleType::Ptr(type)->primitiveType(); else targetType = XsdComplexType::Ptr(type)->contentType()->simpleType(); + + if (!targetType) { + // QTBUG-77620: pattern type within a union doesn't get + // its primitive type set. FIXME: find root cause and + // fix that, so we can remove this (and an XFAIL). + error(QtXmlPatterns::tr("Field %1 is missing its simple type.") + .arg(formatData(field->expression()))); + return false; + } } else { if (BuiltinTypes::xsAnySimpleType->name(m_namePool) == type->name(m_namePool)) { targetType = BuiltinTypes::xsString; |