summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChunyi Lyu <clyu@vmware.com>2023-01-31 10:36:08 +0000
committerChunyi Lyu <clyu@vmware.com>2023-01-31 10:36:08 +0000
commit6205e5e5e3acd23befdf2eced7ce019ed117a126 (patch)
treeeceeec8ad8244b0c6cd509fa848be168427fe27c
parentb02c268632e7729f7ce809adb264e05a8d041084 (diff)
downloadrabbitmq-server-git-6205e5e5e3acd23befdf2eced7ce019ed117a126.tar.gz
MQTT print stacktrace/payload only at debug level
-rw-r--r--deps/rabbitmq_mqtt/src/rabbit_mqtt_reader.erl3
-rw-r--r--deps/rabbitmq_web_mqtt/src/rabbit_web_mqtt_handler.erl2
2 files changed, 3 insertions, 2 deletions
diff --git a/deps/rabbitmq_mqtt/src/rabbit_mqtt_reader.erl b/deps/rabbitmq_mqtt/src/rabbit_mqtt_reader.erl
index a6c578a610..80d3b3e776 100644
--- a/deps/rabbitmq_mqtt/src/rabbit_mqtt_reader.erl
+++ b/deps/rabbitmq_mqtt/src/rabbit_mqtt_reader.erl
@@ -365,7 +365,8 @@ process_received_bytes(Bytes,
{stop, normal, {_SendWill = false, pstate(State, ProcState1)}}
end;
{error, {cannot_parse, Reason, Stacktrace}} ->
- ?LOG_ERROR("MQTT cannot parse a packet on connection '~ts', reason: ~tp, "
+ ?LOG_ERROR("Unparseable MQTT packet received from connection ~ts", [ConnName]),
+ ?LOG_DEBUG("MQTT cannot parse a packet on connection '~ts', reason: ~tp, "
"stacktrace: ~tp, payload (first 100 bytes): ~tp",
[ConnName, Reason, Stacktrace, rabbit_mqtt_util:truncate_binary(Bytes, 100)]),
{stop, {shutdown, Reason}, State};
diff --git a/deps/rabbitmq_web_mqtt/src/rabbit_web_mqtt_handler.erl b/deps/rabbitmq_web_mqtt/src/rabbit_web_mqtt_handler.erl
index 31e823dae3..175435d98f 100644
--- a/deps/rabbitmq_web_mqtt/src/rabbit_web_mqtt_handler.erl
+++ b/deps/rabbitmq_web_mqtt/src/rabbit_web_mqtt_handler.erl
@@ -286,7 +286,7 @@ parse(Data, ParseState) ->
rabbit_mqtt_packet:parse(Data, ParseState)
catch
_:Reason:Stacktrace ->
- ?LOG_ERROR("Web MQTT cannot parse a packet, reason: ~tp, stacktrace: ~tp, "
+ ?LOG_DEBUG("Web MQTT cannot parse a packet, reason: ~tp, stacktrace: ~tp, "
"payload (first 100 bytes): ~tp",
[Reason, Stacktrace, rabbit_mqtt_util:truncate_binary(Data, 100)]),
{error, cannot_parse}