summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Use externailzed rbe config in bazelmergify/bp/v3.9.x/pr-3683Philip Kuryloski2021-11-128-31/+249
| | | | | | | | | | | (cherry picked from commit 92068f481c7468d0b6d6633a053eb6df34e65cc6) # Conflicts: # .github/workflows/perform-bazel-execution-comparison.yaml # .github/workflows/test-erlang-git.yaml # .github/workflows/test-mixed-versions.yaml # .github/workflows/test.yaml # BUILD.bazel
* Merge pull request #3712 from rabbitmq/mergify/bp/v3.9.x/pr-3710Philip Kuryloski2021-11-122-0/+15
|\ | | | | Generate the rabbitmqadmin cli under bazel (backport #3710)
| * Generate the rabbitmqadmin cli under bazelPhilip Kuryloski2021-11-122-0/+15
|/ | | | (cherry picked from commit 9c70b3220a0e92832193fef13e210b8d246a79e2)
* Merge pull request #3711 from rabbitmq/mergify/bp/v3.9.x/pr-3656Michael Klishin2021-11-122-2/+8
|\ | | | | Expose pending enqueues in quorum queue overview (backport #3656)
| * Expose pending enqueues in overview output to allowKarl Nilsson2021-11-122-2/+8
|/ | | | | | | | | debugging of situation where messages may be stuck. Also cancel rabbit_fifo_client timer after message resend to avoid resending them again when the timer triggers. (cherry picked from commit bf6c7476070958f986cf8b892c3e1abb295d2c12)
* Merge pull request #3709 from rabbitmq/mergify/bp/v3.9.x/pr-3676Michael Klishin2021-11-122-1/+6
|\ | | | | Avoid slow mnesia transaction on QQ init (backport #3676)
| * Avoid slow mnesia transaction on QQ initKarl Nilsson2021-11-122-1/+6
|/ | | | | | | | As we only need to make sure the rabbit_queues table is populated use a dirty write function that only does this instead. This could potentially half recovery times for many QQ scenarios. (cherry picked from commit d2fde27b565780c2b443138557c27f7ee650f250)
* Merge pull request #3706 from rabbitmq/mergify/bp/v3.9.x/pr-3699Philip Kuryloski2021-11-121-2/+2
|\ | | | | Adopt otp 24.1.5 for OCI workflow (backport #3699)
| * Adopt otp 24.1.5 for OCI workflowGitHub2021-11-121-2/+2
|/ | | | (cherry picked from commit 979e984299c885213a7f970ba4eb20337ac59ed1)
* Merge pull request #3702 from rabbitmq/mergify/bp/v3.9.x/pr-3700Philip Kuryloski2021-11-121-0/+1
|\ | | | | Add --remote_download_toplevel to the bazel config (backport #3700)
| * Add --remote_download_toplevel to the bazel configmergify/bp/v3.9.x/pr-3700Philip Kuryloski2021-11-121-0/+1
|/ | | | | | | | | | | | | | Based on the testing and advice from BuildBuddy: Network limitations/flakiness in GitHub actions can be mitigated by reducing the number of artifacts that get downloaded. Since we only use bazel for testing currently, we don't actually care about the artifacts, so there is no downside to the flag. If this isn't enough, we can try the --remote_download_minimal flag, which limits the amount of downloads even further. (cherry picked from commit f92e6b436cd8a510d5386009fb3a0db6ff9c578c)
* Update 3.9.9 release notesv3.9.9Michael Klishin2021-11-111-0/+6
| | | | (cherry picked from commit 6182505828c30f79b4fe5a99931a197f89bba04e)
* Merge pull request #3587 from rabbitmq/prometheus-label-pre-render-optimizationMichael Klishin2021-11-113-18/+29
| | | | | | | | | | Pre-render prometheus labels (cherry picked from commit 1b7a8f869e6392719f4919f9a4ed06802af90454) Conflicts: rabbitmq-components.mk workspace_helpers.bzl
* Update 3.9.9 release notesMichael Klishin2021-11-111-0/+4
| | | | (cherry picked from commit ebfa084b505b0a70d8ea822ed3813a9489158120)
* Merge pull request #3690 from rabbitmq/mergify/bp/v3.9.x/pr-3689Michael Klishin2021-11-111-2/+7
|\ | | | | Use a for loop here because IE 11 does not support lambdas (backport #3689)
| * Use a for loop here because IE 11 does not support lambdasMichael Klishin2021-11-101-2/+7
|/ | | | | | Closes #3688 (cherry picked from commit 8e180c581ac4407137c7ae6aaf559db0a8725343)
* Merge pull request #3681 from rabbitmq/mergify/bp/v3.9.x/pr-3680Michael Klishin2021-11-101-1/+1
|\ | | | | Grammar (backport #3680)
| * GrammarSagi Sarussi2021-11-101-1/+1
|/ | | | (cherry picked from commit eff5c063cb9bfbf4ade3a5a8966f6af1b3d8068d)
* Merge pull request #3678 from rabbitmq/mergify/bp/v3.9.x/pr-3677Michael Klishin2021-11-091-0/+83
|\ | | | | 3.9.9 release notes (backport #3677)
| * 3.9.9 release notesMichael Klishin2021-11-091-0/+83
|/ | | | (cherry picked from commit e9b474bf2c5997d4879524e8b227680abf3ce7fa)
* Merge pull request #3673 from rabbitmq/osiris-123Michael Klishin2021-11-093-32/+9
|\ | | | | update osiris to 1.2.3
| * Update to osiris 1.2.3 in bazel buildPhilip Kuryloski2021-11-092-31/+8
| |
| * update osiris to 1.2.3Gabriele Santomaggio2021-11-091-1/+1
|/
* Merge pull request #3672 from rabbitmq/ra-2-0-2Philip Kuryloski2021-11-094-9/+12
|\ | | | | Ra v2.0.2
| * Use unique group names in rabbit_stream_SUITEra-2-0-2Philip Kuryloski2021-11-092-3/+6
| | | | | | | | | | Technically duplicate names is supported by common test, but we have seen it contribute to flakiness in our suite in practice
| * Add the ra sha to the bazel configPhilip Kuryloski2021-11-091-0/+1
| |
| * add aten config for bazelKarl Nilsson2021-11-091-3/+3
| |
| * Ra v2.0.2Karl Nilsson2021-11-092-3/+2
|/
* Fix metric active value when consuming from a QQKarl Nilsson2021-11-081-2/+2
| | | | Introduced in 1c6e45257d824ef72b11fad171bb11a88bb9a4b5
* Merge pull request #3670 from rabbitmq/mergify/bp/v3.9.x/pr-3628Michael Klishin2021-11-086-55/+102
|\ | | | | QQ: stability and channel side improvements (backport #3628)
| * Log recovery time by queue typeKarl Nilsson2021-11-081-1/+3
| | | | | | | | (cherry picked from commit 3d7edcea921a9fc15349475a61f0c47b6cc668ae)
| * QQ: set better timeouts for commandsKarl Nilsson2021-11-084-42/+73
| | | | | | | | | | | | | | | | Refactor how the single active consumer check is performed when consuming. Improve timeouts in rabbit_fifo_client. (cherry picked from commit 1c6e45257d824ef72b11fad171bb11a88bb9a4b5)
| * Handle quorum queue "queue pids"Karl Nilsson2021-11-081-1/+1
| | | | | | | | | | | | In a function called if a queue declare returns 'absent'. (cherry picked from commit 2fb1291c735028f359f88108a47232cf124179c0)
| * QQ: try all servers when registering enqueuerKarl Nilsson2021-11-082-11/+25
|/ | | | | | | | | | | This should avoid channel crashes when the leader has recently changed and the amqqueue record hasn't yet been updated. Also catch errors in the QQ tick temporary process that updates metrics. During shutdown the metrics ETS table may disappear before this process has finished which would result in a noisy error in the logs. (cherry picked from commit 3f4a7caf76311aea1dee764bdc5eaf40e14fa87a)
* Merge pull request #3668 from rabbitmq/mergify/bp/v3.9.x/pr-3667Michael Klishin2021-11-081-1/+2
|\ | | | | Increase some buildbuddy rbe timeouts (backport #3667)
| * Increase some buildbuddy rbe timeoutsPhilip Kuryloski2021-11-081-1/+2
|/ | | | | | | We have some timeouts in CI between the GitHub Actions worker and BuildBuddy. This should help. (cherry picked from commit e42d906f5417756a60e2d966bf020e73d788a3ac)
* Merge pull request #3661 from rabbitmq/mergify/bp/v3.9.x/pr-3657Philip Kuryloski2021-11-054-23/+8
|\ | | | | Adopt the new buildbuddy remote execution url (backport #3657)
| * Clean up auto-backportPhilip Kuryloski2021-11-052-139/+0
| |
| * Adopt the new buildbuddy remote execution urlPhilip Kuryloski2021-11-056-23/+147
|/ | | | | | | | | | Buildbuddy reached out and expects it should be more reliable (cherry picked from commit f9f751f1b658bd97adb547038be7cc689fe6ccb8) # Conflicts: # .github/workflows/perform-bazel-execution-comparison.yaml # .github/workflows/test-erlang-git.yaml
* Merge pull request #3660 from rabbitmq/mergify/bp/v3.9.x/pr-3658Michael Klishin2021-11-056-6/+7
|\ | | | | Update link in comment (backport #3658)
| * Update link in commentmergify/bp/v3.9.x/pr-3658Luke Bakken2021-11-056-6/+7
|/ | | | | | | It is a useful comment, so update all the links to the correct place on the internet: http://erlang.org/pipermail/erlang-questions/2010-April/050508.html (cherry picked from commit 160a74862a3c04780ca6e6223020df3d5fa5a2b8)
* Merge pull request #3654 from rabbitmq/mergify/bp/v3.9.x/pr-3653Michael Klishin2021-11-041-2435/+0
|\ | | | | Remove pacemaker OCF RA agent for RabbitMQ (backport #3653)
| * Remove pacemaker OCF RA agent for RabbitMQBogdan Dobrelya2021-11-041-2435/+0
|/ | | | | | | | | It has been moved to https://github.com/ClusterLabs/resource-agents/tree/master/heartbeat since it can be no longer CI tested here Signed-off-by: Bogdan Dobrelya <bogdando@mail.ru> (cherry picked from commit 3083d5fc210c04bf68a09015ceb75a792332a333)
* Merge pull request #3651 from rabbitmq/mergify/bp/v3.9.x/pr-3615Michael Klishin2021-11-041-0/+15
|\ | | | | rabbit_msg_store: Accept duplicate writes from the same queue (backport #3615)
| * rabbit_msg_store: Accept duplicate writes from the same queuemergify/bp/v3.9.x/pr-3615Jean-Sébastien Pédron2021-11-031-0/+15
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The situation is this one: if for some reason (i.e. a bug) a queue has the same message referenced twice (or more) in its index and this message is eligible for the message store (as opposed to being entirely stored in the queue index), it will send it multiple times to the message store. Until now, the code of the message store had two assertions: * one verified in the context of the queue process to make sure there was no two writes or two removes in a row; * one verified in the context of the message store process, doing exactly the same. Consider the following order of events: 1. the queue sends the first copy to the message store 2. the message store handles the first copy 3. the queue sends the second copy to the message 4. the message store handles the second copy In this scenario, none of the assertions are triggered and the message goes through the message store as if it was coming from different queues (i.e. a fan-out use case). Now consider this order of events: 1. the queue sends the first copy to the message store 2. the queue sends the second copy to the message store 3. the message store handles the first copy This time, the code will hit both assertions, leading to the crash of the queue, the crash of the message store and as a consequence, the crash of the entire vhost. In the case of two consecutive writes, those assertions are useless because the message store already knows how to handle multiple copies of the same message. However, the consequence are catastrophic: a single queue with a duplicate message could take down an entire vhost. This patch relaxes the assertion in the case of two consecutive writes. Now, both scenarii described above will be consistent: the copies from the same queue will be handled as any copies and the message store and the vhost will continue to work as usual. Note that this patch doesn't cover the reason why there were multiple copies in the queue in the first place! So the initial reason for this to happen is still there lurking somewhere. The user who saw this problem had duplicate messages in a dead-letter queue. Perhaps something related to the lack of publisher-confirms between the initial queue and the dead-letter one? (cherry picked from commit 49c733be3a77d94d6a62f587d006699248c83255)
* Merge pull request #3650 from rabbitmq/mergify/bp/v3.9.x/pr-3649Michael Klishin2021-11-031-2/+5
|\ | | | | Tweak more erlang_ls settings (backport #3649)
| * Tweak more erlang_ls settingsLuke Bakken2021-11-031-2/+5
|/ | | | | | | | | | | As suggested in #3647: * Add commented-out section to disable bound_var_in_pattern * Comment-out `elvis` as that is not yet a standard used by the team cc @kjnilsson @mkuratczyk (cherry picked from commit 53ed2c3d40b9b4cf67348f6e447fef51391f8845)
* Merge pull request #3648 from rabbitmq/mergify/bp/v3.9.x/pr-3647Michael Klishin2021-11-031-2/+2
|\ | | | | Comment-out code_reload (backport #3647)
| * Comment-out code_reloadLuke Bakken2021-11-031-2/+2
|/ | | | | | If RabbitMQ is not running, `erlang_ls` returns `nodedown` which is shown in your text editor console. (cherry picked from commit 2741b75937d15013f7dc700c3558ce970245aa92)
* Use version range for stream client Maven dependencyArnaud Cogoluègnes2021-11-032-2/+2
| | | | | | | | | In test suite. Note a snapshot for 1.0-SNAPSHOT has been pushed by mistake a while ago, so this one must be excluded. It's unlikely it will be erased, as the snapshots for the first stable version should be 1.0.0-SNAPSHOT. (cherry picked from commit ba5cfb1bae608a27382bfbfb96d8d22347e26825)