Added test for log rotation when it cannnot

create parent dirs, more informative exceptions.

1 files changed, 17 insertions, 3 deletions

diff --git a/src/rabbit_tests.erl b/src/rabbit_tests.erl
index 6d10c576..83e28c2f 100644
--- a/src/rabbit_tests.erl
+++ b/src/rabbit_tests.erl
@@ -236,7 +236,8 @@ test_log_management_during_startup() ->
     ok = error_logger:tty(false),
     ok = delete_log_handlers([sasl_report_tty_h]),
     ok = case catch control_action(start_app, []) of
-             ok -> exit(got_success_but_expected_failure);
+             ok -> exit({got_success_but_expected_failure,
+                        log_rotation_tty_no_handlers_test});
              {error, {cannot_log_to_tty, _, _}} -> ok
          end,
 
@@ -260,8 +261,21 @@ test_log_management_during_startup() ->
     ok = delete_log_handlers([rabbit_error_logger_file_h]),
     ok = add_log_handlers([{error_logger_file_h, MainLog}]),
     ok = case control_action(start_app, []) of
-             ok -> exit(got_success_but_expected_failure);
-             {error, {cannot_log_to_file, _, _}} -> ok
+             ok -> exit({got_success_but_expected_failure,
+                        log_rotation_no_write_permission_dir_test}); 
+            {error, {cannot_log_to_file, _, _}} -> ok
+         end,
+
+    %% start application with logging to a subdirectory which
+    %% parent directory has no write permissions
+    TmpTestDir = "/tmp/rabbit-tests/no-permission/test/log",
+    ok = application:set_env(kernel, error_logger, {file, TmpTestDir}),
+    ok = add_log_handlers([{error_logger_file_h, MainLog}]),
+    ok = case control_action(start_app, []) of
+             ok -> exit({got_success_but_expected_failure,
+                        log_rotatation_parent_dirs_test});
+             {error, {cannot_log_to_file, _,
+               {error, {cannot_create_parent_dirs, _, eacces}}}} -> ok
          end,
     ok = set_permissions(TmpDir, 8#00700),
     ok = set_permissions(TmpLog, 8#00600),