summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSimon MacMullen <simon@rabbitmq.com>2010-10-25 17:31:21 +0100
committerSimon MacMullen <simon@rabbitmq.com>2010-10-25 17:31:21 +0100
commit84e10e9ee5d3e4a654e9a72432dfd001a50eed73 (patch)
tree47d0fd896d43cdbc8121c39706a49635221e11e6
parentf9f26fe6a62e009331574bd60cce22366ce48712 (diff)
downloadrabbitmq-server-84e10e9ee5d3e4a654e9a72432dfd001a50eed73.tar.gz
Specs.
-rw-r--r--src/rabbit_upgrade.erl11
-rw-r--r--src/rabbit_upgrade_functions.erl10
2 files changed, 20 insertions, 1 deletions
diff --git a/src/rabbit_upgrade.erl b/src/rabbit_upgrade.erl
index 20ef8766..9ae90775 100644
--- a/src/rabbit_upgrade.erl
+++ b/src/rabbit_upgrade.erl
@@ -30,6 +30,15 @@
%% -------------------------------------------------------------------
+-ifdef(use_specs).
+
+-spec(maybe_upgrade/1 :: (file:filename()) -> 'ok').
+-spec(write_version/1 :: (file:filename()) -> 'ok').
+
+-endif.
+
+%% -------------------------------------------------------------------
+
%% Try to upgrade the schema. If no information on the existing schema could
%% be found, do nothing. rabbit_mnesia:check_schema_integrity() will catch the
%% problem.
@@ -48,7 +57,7 @@ maybe_upgrade(Dir) ->
[warn("Data store has had future upgrade ~w applied." ++
" Will not upgrade.~n", [U]) || U <- Unknown]
end,
- digraph:delete(G),
+ true = digraph:delete(G),
ok;
{error, enoent} ->
ok
diff --git a/src/rabbit_upgrade_functions.erl b/src/rabbit_upgrade_functions.erl
index c53187e2..75e4cf88 100644
--- a/src/rabbit_upgrade_functions.erl
+++ b/src/rabbit_upgrade_functions.erl
@@ -28,6 +28,16 @@
-rabbit_upgrade({test_remove_column, [test_add_column]}).
-rabbit_upgrade({remove_user_scope, []}).
+%% -------------------------------------------------------------------
+
+-ifdef(use_specs).
+
+-spec(remove_user_scope/0 :: () -> 'ok').
+-spec(test_add_column/0 :: () -> 'ok').
+-spec(test_remove_column/0 :: () -> 'ok').
+
+-endif.
+
%%--------------------------------------------------------------------
%% TODO this is just a hack, when branch bug23319 is merged this should use