summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSimon MacMullen <simon@lshift.net>2010-05-28 16:07:59 +0100
committerSimon MacMullen <simon@lshift.net>2010-05-28 16:07:59 +0100
commit7069f77efe8b6810e084bc8455f217c7d1088750 (patch)
treef648139ff8751b0d34c6bb9121d6f1439f1e700e
parentb4b29b285354678df1262799b59f6bf4259a5c94 (diff)
downloadrabbitmq-server-7069f77efe8b6810e084bc8455f217c7d1088750.tar.gz
s/fun(/fun (/g
-rw-r--r--src/delegate.erl10
-rw-r--r--src/gen_server2.erl2
-rw-r--r--src/rabbit_amqqueue.erl9
-rw-r--r--src/rabbit_control.erl4
-rw-r--r--src/rabbit_exchange.erl13
-rw-r--r--src/rabbit_misc.erl6
-rw-r--r--src/rabbit_mnesia.erl2
-rw-r--r--src/rabbit_multi.erl4
-rw-r--r--src/rabbit_net.erl2
-rw-r--r--src/rabbit_persister.erl2
-rw-r--r--src/rabbit_reader_queue_collector.erl4
-rw-r--r--src/rabbit_router.erl11
-rw-r--r--src/rabbit_tests.erl20
-rw-r--r--src/supervisor2.erl8
14 files changed, 51 insertions, 46 deletions
diff --git a/src/delegate.erl b/src/delegate.erl
index 98353453..8af28127 100644
--- a/src/delegate.erl
+++ b/src/delegate.erl
@@ -45,8 +45,8 @@
-ifdef(use_specs).
-spec(start_link/1 :: (non_neg_integer()) -> {'ok', pid()}).
--spec(invoke_no_result/2 :: (pid() | [pid()], fun((pid()) -> any())) -> 'ok').
--spec(invoke/2 :: (pid() | [pid()], fun((pid()) -> A)) -> A).
+-spec(invoke_no_result/2 :: (pid() | [pid()], fun ((pid()) -> any())) -> 'ok').
+-spec(invoke/2 :: (pid() | [pid()], fun ((pid()) -> A)) -> A).
-spec(process_count/0 :: () -> non_neg_integer()).
@@ -73,7 +73,7 @@ invoke(Pid, Fun) when is_pid(Pid) ->
invoke(Pids, Fun) when is_list(Pids) ->
lists:foldl(
- fun({Status, Result, Pid}, {Good, Bad}) ->
+ fun ({Status, Result, Pid}, {Good, Bad}) ->
case Status of
ok -> {[{Pid, Result}|Good], Bad};
error -> {Good, [{Pid, Result}|Bad]}
@@ -136,10 +136,10 @@ delegate_per_remote_node(NodePids, Fun, DelegateFun) ->
%% block forever.
[gen_server2:cast(
local_server(Node),
- {thunk, fun() ->
+ {thunk, fun () ->
Self ! {result,
DelegateFun(
- Node, fun() -> safe_invoke(Pids, Fun) end)}
+ Node, fun () -> safe_invoke(Pids, Fun) end)}
end}) || {Node, Pids} <- NodePids],
[receive {result, Result} -> Result end || _ <- NodePids].
diff --git a/src/gen_server2.erl b/src/gen_server2.erl
index 5b899cdb..547f0a42 100644
--- a/src/gen_server2.erl
+++ b/src/gen_server2.erl
@@ -639,7 +639,7 @@ do_multi_call(Nodes, Name, Req, Timeout) ->
Caller = self(),
Receiver =
spawn(
- fun() ->
+ fun () ->
%% Middleman process. Should be unsensitive to regular
%% exit signals. The sychronization is needed in case
%% the receiver would exit before the caller started
diff --git a/src/rabbit_amqqueue.erl b/src/rabbit_amqqueue.erl
index 483b5a93..1756640a 100644
--- a/src/rabbit_amqqueue.erl
+++ b/src/rabbit_amqqueue.erl
@@ -391,15 +391,16 @@ safe_delegate_call_ok(H, F, Pids) ->
end.
delegate_call(Pid, Msg, Timeout) ->
- delegate:invoke(Pid, fun(P) -> gen_server2:call(P, Msg, Timeout) end).
+ delegate:invoke(Pid, fun (P) -> gen_server2:call(P, Msg, Timeout) end).
delegate_pcall(Pid, Pri, Msg, Timeout) ->
- delegate:invoke(Pid, fun(P) -> gen_server2:pcall(P, Pri, Msg, Timeout) end).
+ delegate:invoke(Pid,
+ fun (P) -> gen_server2:pcall(P, Pri, Msg, Timeout) end).
delegate_cast(Pid, Msg) ->
- delegate:invoke_no_result(Pid, fun(P) -> gen_server2:cast(P, Msg) end).
+ delegate:invoke_no_result(Pid, fun (P) -> gen_server2:cast(P, Msg) end).
delegate_pcast(Pid, Pri, Msg) ->
delegate:invoke_no_result(Pid,
- fun(P) -> gen_server2:pcast(P, Pri, Msg) end).
+ fun (P) -> gen_server2:pcast(P, Pri, Msg) end).
diff --git a/src/rabbit_control.erl b/src/rabbit_control.erl
index d1834b3b..323d4d2f 100644
--- a/src/rabbit_control.erl
+++ b/src/rabbit_control.erl
@@ -59,8 +59,8 @@ start() ->
parse_args(FullCommand, #params{quiet = false,
node = rabbit_misc:makenode(NodeStr)}),
Inform = case Quiet of
- true -> fun(_Format, _Args1) -> ok end;
- false -> fun(Format, Args1) ->
+ true -> fun (_Format, _Args1) -> ok end;
+ false -> fun (Format, Args1) ->
io:format(Format ++ " ...~n", Args1)
end
end,
diff --git a/src/rabbit_exchange.erl b/src/rabbit_exchange.erl
index 8f41392f..835b1468 100644
--- a/src/rabbit_exchange.erl
+++ b/src/rabbit_exchange.erl
@@ -80,8 +80,9 @@
bind_res() | {'error', 'binding_not_found'}).
-spec(list_bindings/1 :: (vhost()) ->
[{exchange_name(), queue_name(), routing_key(), amqp_table()}]).
--spec(delete_queue_bindings/1 :: (queue_name()) -> fun(() -> none())).
--spec(delete_transient_queue_bindings/1 :: (queue_name()) -> fun(() -> none())).
+-spec(delete_queue_bindings/1 :: (queue_name()) -> fun (() -> none())).
+-spec(delete_transient_queue_bindings/1 :: (queue_name()) ->
+ fun (() -> none())).
-spec(delete/2 :: (exchange_name(), boolean()) ->
'ok' | not_found() | {'error', 'in_use'}).
-spec(list_queue_bindings/1 :: (queue_name()) ->
@@ -97,12 +98,12 @@
recover() ->
Exs = rabbit_misc:table_fold(
- fun(Exchange, Acc) ->
+ fun (Exchange, Acc) ->
ok = mnesia:write(rabbit_exchange, Exchange, write),
[Exchange | Acc]
end, [], rabbit_durable_exchange),
Bs = rabbit_misc:table_fold(
- fun(Route = #route{binding = B}, Acc) ->
+ fun (Route = #route{binding = B}, Acc) ->
{_, ReverseRoute} = route_with_reverse(Route),
ok = mnesia:write(rabbit_route,
Route, write),
@@ -349,7 +350,7 @@ continue({[], Continuation}) -> continue(mnesia:select(Continuation)).
call_with_exchange(Exchange, Fun) ->
rabbit_misc:execute_mnesia_transaction(
- fun() -> case mnesia:read({rabbit_exchange, Exchange}) of
+ fun () -> case mnesia:read({rabbit_exchange, Exchange}) of
[] -> {error, not_found};
[X] -> Fun(X)
end
@@ -357,7 +358,7 @@ call_with_exchange(Exchange, Fun) ->
call_with_exchange_and_queue(Exchange, Queue, Fun) ->
rabbit_misc:execute_mnesia_transaction(
- fun() -> case {mnesia:read({rabbit_exchange, Exchange}),
+ fun () -> case {mnesia:read({rabbit_exchange, Exchange}),
mnesia:read({rabbit_queue, Queue})} of
{[X], [Q]} -> Fun(X, Q);
{[ ], [_]} -> {error, exchange_not_found};
diff --git a/src/rabbit_misc.erl b/src/rabbit_misc.erl
index 9a911ab1..35739dcb 100644
--- a/src/rabbit_misc.erl
+++ b/src/rabbit_misc.erl
@@ -242,12 +242,12 @@ report_cover([Root]) when is_atom(Root) ->
report_cover(Root) ->
Dir = filename:join(Root, "cover"),
ok = filelib:ensure_dir(filename:join(Dir,"junk")),
- lists:foreach(fun(F) -> file:delete(F) end,
+ lists:foreach(fun (F) -> file:delete(F) end,
filelib:wildcard(filename:join(Dir, "*.html"))),
{ok, SummaryFile} = file:open(filename:join(Dir, "summary.txt"), [write]),
{CT, NCT} =
lists:foldl(
- fun(M,{CovTot, NotCovTot}) ->
+ fun (M,{CovTot, NotCovTot}) ->
{ok, {M, {Cov, NotCov}}} = cover:analyze(M, module),
ok = report_coverage_percentage(SummaryFile,
Cov, NotCov, M),
@@ -367,7 +367,7 @@ upmap(F, L) ->
Parent = self(),
Ref = make_ref(),
[receive {Ref, Result} -> Result end
- || _ <- [spawn(fun() -> Parent ! {Ref, F(X)} end) || X <- L]].
+ || _ <- [spawn(fun () -> Parent ! {Ref, F(X)} end) || X <- L]].
map_in_order(F, L) ->
lists:reverse(
diff --git a/src/rabbit_mnesia.erl b/src/rabbit_mnesia.erl
index 55a6761d..a0b7aa4e 100644
--- a/src/rabbit_mnesia.erl
+++ b/src/rabbit_mnesia.erl
@@ -346,7 +346,7 @@ table_has_copy_type(TabDef, DiscType) ->
create_local_table_copies(Type) ->
lists:foreach(
- fun({Tab, TabDef}) ->
+ fun ({Tab, TabDef}) ->
HasDiscCopies = table_has_copy_type(TabDef, disc_copies),
HasDiscOnlyCopies = table_has_copy_type(TabDef, disc_only_copies),
LocalTab = proplists:get_bool(local_content, TabDef),
diff --git a/src/rabbit_multi.erl b/src/rabbit_multi.erl
index 336f74bf..5db1d77a 100644
--- a/src/rabbit_multi.erl
+++ b/src/rabbit_multi.erl
@@ -111,7 +111,7 @@ action(start_all, [NodeCount], RpcTimeout) ->
action(status, [], RpcTimeout) ->
io:format("Status of all running nodes...~n", []),
call_all_nodes(
- fun({Node, Pid}) ->
+ fun ({Node, Pid}) ->
RabbitRunning =
case is_rabbit_running(Node, RpcTimeout) of
false -> not_running;
@@ -123,7 +123,7 @@ action(status, [], RpcTimeout) ->
action(stop_all, [], RpcTimeout) ->
io:format("Stopping all nodes...~n", []),
- call_all_nodes(fun({Node, Pid}) ->
+ call_all_nodes(fun ({Node, Pid}) ->
io:format("Stopping node ~p~n", [Node]),
rpc:call(Node, rabbit, stop_and_halt, []),
case kill_wait(Pid, RpcTimeout, false) of
diff --git a/src/rabbit_net.erl b/src/rabbit_net.erl
index 406977b4..975954fc 100644
--- a/src/rabbit_net.erl
+++ b/src/rabbit_net.erl
@@ -66,7 +66,7 @@ async_recv(Sock, Length, Timeout) when is_record(Sock, ssl_socket) ->
Pid = self(),
Ref = make_ref(),
- spawn(fun() -> Pid ! {inet_async, Sock, Ref,
+ spawn(fun () -> Pid ! {inet_async, Sock, Ref,
ssl:recv(Sock#ssl_socket.ssl, Length, Timeout)}
end),
diff --git a/src/rabbit_persister.erl b/src/rabbit_persister.erl
index 3cd42e47..8d3c2dc0 100644
--- a/src/rabbit_persister.erl
+++ b/src/rabbit_persister.erl
@@ -236,7 +236,7 @@ log_work(CreateWorkUnit, MessageList,
snapshot = Snapshot = #psnapshot{messages = Messages}}) ->
Unit = CreateWorkUnit(
rabbit_misc:map_in_order(
- fun(M = {publish, Message, QK = {_QName, PKey}}) ->
+ fun (M = {publish, Message, QK = {_QName, PKey}}) ->
case ets:lookup(Messages, PKey) of
[_] -> {tied, QK};
[] -> ets:insert(Messages, {PKey, Message}),
diff --git a/src/rabbit_reader_queue_collector.erl b/src/rabbit_reader_queue_collector.erl
index 841549e9..8d4e8fdb 100644
--- a/src/rabbit_reader_queue_collector.erl
+++ b/src/rabbit_reader_queue_collector.erl
@@ -82,8 +82,8 @@ handle_call({register_exclusive_queue, Q}, _From,
handle_call(delete_all, _From,
State = #state{exclusive_queues = ExclusiveQueues}) ->
[rabbit_misc:with_exit_handler(
- fun() -> ok end,
- fun() ->
+ fun () -> ok end,
+ fun () ->
erlang:demonitor(MonitorRef),
rabbit_amqqueue:delete(Q, false, false)
end)
diff --git a/src/rabbit_router.erl b/src/rabbit_router.erl
index 03979d6c..5cd15a94 100644
--- a/src/rabbit_router.erl
+++ b/src/rabbit_router.erl
@@ -57,14 +57,17 @@ deliver(QPids, Delivery = #delivery{mandatory = false,
%% is preserved. This scales much better than the non-immediate
%% case below.
delegate:invoke_no_result(
- QPids, fun(Pid) -> rabbit_amqqueue:deliver(Pid, Delivery) end),
+ QPids, fun (Pid) -> rabbit_amqqueue:deliver(Pid, Delivery) end),
{routed, QPids};
deliver(QPids, Delivery) ->
{Success, _} =
delegate:invoke(QPids,
- fun(Pid) -> rabbit_amqqueue:deliver(Pid, Delivery) end),
- {Routed, Handled} = lists:foldl(fun fold_deliveries/2, {false, []}, Success),
+ fun (Pid) ->
+ rabbit_amqqueue:deliver(Pid, Delivery)
+ end),
+ {Routed, Handled} =
+ lists:foldl(fun fold_deliveries/2, {false, []}, Success),
check_delivery(Delivery#delivery.mandatory, Delivery#delivery.immediate,
{Routed, Handled}).
@@ -88,7 +91,7 @@ match_routing_key(Name, RoutingKey) ->
lookup_qpids(Queues) ->
sets:fold(
- fun(Key, Acc) ->
+ fun (Key, Acc) ->
case mnesia:dirty_read({rabbit_queue, Key}) of
[#amqqueue{pid = QPid}] -> [QPid | Acc];
[] -> Acc
diff --git a/src/rabbit_tests.erl b/src/rabbit_tests.erl
index fa0ce2db..dc7f92d1 100644
--- a/src/rabbit_tests.erl
+++ b/src/rabbit_tests.erl
@@ -822,7 +822,7 @@ test_hooks() ->
{[arg1, arg2], 1, 3} = get(arg_hook_test_fired),
%% Invoking Pids
- Remote = fun() ->
+ Remote = fun () ->
receive
{rabbitmq_hook,[remote_test,test,[],Target]} ->
Target ! invoked
@@ -841,9 +841,9 @@ test_hooks() ->
test_delegates_async(SecondaryNode) ->
Self = self(),
- Sender = fun(Pid) -> Pid ! {invoked, Self} end,
+ Sender = fun (Pid) -> Pid ! {invoked, Self} end,
- Responder = make_responder(fun({invoked, Pid}) -> Pid ! response end),
+ Responder = make_responder(fun ({invoked, Pid}) -> Pid ! response end),
ok = delegate:invoke_no_result(spawn(Responder), Sender),
ok = delegate:invoke_no_result(spawn(SecondaryNode, Responder), Sender),
@@ -858,7 +858,7 @@ test_delegates_async(SecondaryNode) ->
make_responder(FMsg) -> make_responder(FMsg, timeout).
make_responder(FMsg, Throw) ->
- fun() ->
+ fun () ->
receive Msg -> FMsg(Msg)
after 1000 -> throw(Throw)
end
@@ -887,22 +887,22 @@ must_exit(Fun) ->
end.
test_delegates_sync(SecondaryNode) ->
- Sender = fun(Pid) -> gen_server:call(Pid, invoked) end,
- BadSender = fun(_Pid) -> exit(exception) end,
+ Sender = fun (Pid) -> gen_server:call(Pid, invoked) end,
+ BadSender = fun (_Pid) -> exit(exception) end,
- Responder = make_responder(fun({'$gen_call', From, invoked}) ->
+ Responder = make_responder(fun ({'$gen_call', From, invoked}) ->
gen_server:reply(From, response)
end),
- BadResponder = make_responder(fun({'$gen_call', From, invoked}) ->
+ BadResponder = make_responder(fun ({'$gen_call', From, invoked}) ->
gen_server:reply(From, response)
end, bad_responder_died),
response = delegate:invoke(spawn(Responder), Sender),
response = delegate:invoke(spawn(SecondaryNode, Responder), Sender),
- must_exit(fun() -> delegate:invoke(spawn(BadResponder), BadSender) end),
- must_exit(fun() ->
+ must_exit(fun () -> delegate:invoke(spawn(BadResponder), BadSender) end),
+ must_exit(fun () ->
delegate:invoke(spawn(SecondaryNode, BadResponder), BadSender) end),
LocalGoodPids = spawn_responders(node(), Responder, 2),
diff --git a/src/supervisor2.erl b/src/supervisor2.erl
index 55753512..0b1d7265 100644
--- a/src/supervisor2.erl
+++ b/src/supervisor2.erl
@@ -301,13 +301,13 @@ handle_call({terminate_child, Name}, _From, State) ->
handle_call(which_children, _From, State) when ?is_simple(State) ->
[#child{child_type = CT, modules = Mods}] = State#state.children,
- Reply = lists:map(fun({Pid, _}) -> {undefined, Pid, CT, Mods} end,
+ Reply = lists:map(fun ({Pid, _}) -> {undefined, Pid, CT, Mods} end,
?DICT:to_list(State#state.dynamics)),
{reply, Reply, State};
handle_call(which_children, _From, State) ->
Resp =
- lists:map(fun(#child{pid = Pid, name = Name,
+ lists:map(fun (#child{pid = Pid, name = Name,
child_type = ChildType, modules = Mods}) ->
{Name, Pid, ChildType, Mods}
end,
@@ -415,7 +415,7 @@ update_childspec1([], Children, KeepOld) ->
lists:reverse(Children ++ KeepOld).
update_chsp(OldCh, Children) ->
- case lists:map(fun(Ch) when OldCh#child.name =:= Ch#child.name ->
+ case lists:map(fun (Ch) when OldCh#child.name =:= Ch#child.name ->
Ch#child{pid = OldCh#child.pid};
(Ch) ->
Ch
@@ -828,7 +828,7 @@ validShutdown(Shutdown, _) -> throw({invalid_shutdown, Shutdown}).
validMods(dynamic) -> true;
validMods(Mods) when is_list(Mods) ->
- lists:foreach(fun(Mod) ->
+ lists:foreach(fun (Mod) ->
if
is_atom(Mod) -> ok;
true -> throw({invalid_module, Mod})