summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatthias Radestock <matthias@rabbitmq.com>2013-03-21 12:29:04 +0000
committerMatthias Radestock <matthias@rabbitmq.com>2013-03-21 12:29:04 +0000
commite436479612e5f3a47b8d7d4654de2ad88616fe3b (patch)
treea12382e26b8fbece244160f3fe9b63b89767661d
parentae743ee4ea4e6cec41fb43710b7f908c8f9ed71f (diff)
parentf9d7a85fa4340762a522f10d130a985663ea2550 (diff)
downloadrabbitmq-server-e436479612e5f3a47b8d7d4654de2ad88616fe3b.tar.gz
merge bug25384 into default
-rw-r--r--packaging/debs/apt-repository/distributions2
-rw-r--r--src/rabbit_alarm.erl14
-rw-r--r--src/rabbit_node_monitor.erl5
-rw-r--r--src/rabbit_tests.erl2
4 files changed, 17 insertions, 6 deletions
diff --git a/packaging/debs/apt-repository/distributions b/packaging/debs/apt-repository/distributions
index 61fd778a..75b9fe46 100644
--- a/packaging/debs/apt-repository/distributions
+++ b/packaging/debs/apt-repository/distributions
@@ -2,6 +2,6 @@ Origin: RabbitMQ
Label: RabbitMQ Repository for Debian / Ubuntu etc
Suite: testing
Codename: kitten
-Architectures: AVR32 alpha amd64 arm armel armhf hppa hurd-i386 i386 ia64 kfreebsd-amd64 kfreebsd-i386 m32 m68k mips mipsel netbsd-alpha netbsd-i386 powerpc s390 s390x sh sparc
+Architectures: AVR32 alpha amd64 arm armel armhf hppa hurd-i386 i386 ia64 kfreebsd-amd64 kfreebsd-i386 m32 m68k mips mipsel netbsd-alpha netbsd-i386 powerpc s390 s390x sh sparc source
Components: main
Description: RabbitMQ Repository for Debian / Ubuntu etc
diff --git a/src/rabbit_alarm.erl b/src/rabbit_alarm.erl
index 362b11aa..6d24d130 100644
--- a/src/rabbit_alarm.erl
+++ b/src/rabbit_alarm.erl
@@ -208,11 +208,19 @@ internal_register(Pid, {M, F, A} = AlertMFA,
State#alarms{alertees = NewAlertees}.
handle_set_alarm({{resource_limit, Source, Node}, []}, State) ->
- rabbit_log:warning("~s resource limit alarm set on node ~p~n",
- [Source, Node]),
+ rabbit_log:warning(
+ "~s resource limit alarm set on node ~p.~n~n"
+ "**********************************************************~n"
+ "*** Publishers will be blocked until this alarm clears ***~n"
+ "**********************************************************~n",
+ [Source, Node]),
{ok, maybe_alert(fun dict:append/3, Node, Source, State)};
handle_set_alarm({file_descriptor_limit, []}, State) ->
- rabbit_log:warning("file descriptor limit alarm set~n"),
+ rabbit_log:warning(
+ "file descriptor limit alarm set.~n~n"
+ "********************************************************************~n"
+ "*** New connections will not be accepted until this alarm clears ***~n"
+ "********************************************************************~n"),
{ok, State};
handle_set_alarm(Alarm, State) ->
rabbit_log:warning("alarm '~p' set~n", [Alarm]),
diff --git a/src/rabbit_node_monitor.erl b/src/rabbit_node_monitor.erl
index de53b7f0..3872f3df 100644
--- a/src/rabbit_node_monitor.erl
+++ b/src/rabbit_node_monitor.erl
@@ -318,6 +318,9 @@ alive_nodes() ->
Nodes = rabbit_mnesia:cluster_nodes(all),
[N || N <- Nodes, pong =:= net_adm:ping(N)].
+alive_rabbit_nodes() ->
+ [N || N <- alive_nodes(), rabbit_nodes:is_running(N, rabbit)].
+
await_cluster_recovery() ->
rabbit_log:warning("Cluster minority status detected - awaiting recovery~n",
[]),
@@ -346,7 +349,7 @@ handle_dead_rabbit_state(State = #state{partitions = Partitions}) ->
%% that we do not attempt to deal with individual (other) partitions
%% going away. It's only safe to forget anything about partitions when
%% there are no partitions.
- Partitions1 = case Partitions -- (Partitions -- alive_nodes()) of
+ Partitions1 = case Partitions -- (Partitions -- alive_rabbit_nodes()) of
[] -> [];
_ -> Partitions
end,
diff --git a/src/rabbit_tests.erl b/src/rabbit_tests.erl
index 1188c554..cd8fa720 100644
--- a/src/rabbit_tests.erl
+++ b/src/rabbit_tests.erl
@@ -1580,7 +1580,7 @@ control_action(Command, Node, Args, Opts) ->
info_action(Command, Args, CheckVHost) ->
ok = control_action(Command, []),
- if CheckVHost -> ok = control_action(Command, []);
+ if CheckVHost -> ok = control_action(Command, [], ["-p", "/"]);
true -> ok
end,
ok = control_action(Command, lists:map(fun atom_to_list/1, Args)),