summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlexandru Scvortov <alexandru@rabbitmq.com>2011-07-25 16:07:24 +0100
committerAlexandru Scvortov <alexandru@rabbitmq.com>2011-07-25 16:07:24 +0100
commit2cc159da0cb509ae51ad3b47f786abc3d2e86250 (patch)
treea1dff2223354dc9c15e77b3493bd1ef30c54dfa6
parent18539d5367da128fcd48909ee7414a57e20a44a1 (diff)
downloadrabbitmq-server-2cc159da0cb509ae51ad3b47f786abc3d2e86250.tar.gz
improve comments
-rw-r--r--src/rabbit_mnesia.erl3
-rw-r--r--src/rabbit_upgrade.erl6
2 files changed, 3 insertions, 6 deletions
diff --git a/src/rabbit_mnesia.erl b/src/rabbit_mnesia.erl
index 9d1fe423..96eedf3c 100644
--- a/src/rabbit_mnesia.erl
+++ b/src/rabbit_mnesia.erl
@@ -599,9 +599,6 @@ create_schema(OnDisk) ->
ok = rabbit_version:record_desired().
is_disc_node() ->
- %% This is pretty ugly but we can't start Mnesia and ask it (will hang),
- %% we can't look at the config file (may not include us even if we're a
- %% disc node).
mnesia:system_info(use_dir).
should_be_disc_node(ClusterNodes) ->
diff --git a/src/rabbit_upgrade.erl b/src/rabbit_upgrade.erl
index a6d04f7e..9739f6b7 100644
--- a/src/rabbit_upgrade.erl
+++ b/src/rabbit_upgrade.erl
@@ -144,7 +144,7 @@ upgrade_mode(AllNodes) ->
case nodes_running(AllNodes) of
[] ->
AfterUs = rabbit_mnesia:read_previously_running_nodes(),
- case {is_disc_node(), AfterUs} of
+ case {is_disc_node_legacy(), AfterUs} of
{true, []} ->
primary;
{true, _} ->
@@ -212,7 +212,7 @@ force_tables() ->
secondary_upgrade(AllNodes) ->
%% must do this before we wipe out schema
- IsDiscNode = is_disc_node(),
+ IsDiscNode = is_disc_node_legacy(),
rabbit_misc:ensure_ok(mnesia:delete_schema([node()]),
cannot_delete_schema),
%% Note that we cluster with all nodes, rather than all disc nodes
@@ -276,7 +276,7 @@ lock_filename() -> lock_filename(dir()).
lock_filename(Dir) -> filename:join(Dir, ?LOCK_FILENAME).
backup_dir() -> dir() ++ "-upgrade-backup".
-is_disc_node() ->
+is_disc_node_legacy() ->
%% This is pretty ugly but we can't start Mnesia and ask it (will
%% hang), we can't look at the config file (may not include us
%% even if we're a disc node). We also can't use