summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFrancesco Mazzoli <francesco@rabbitmq.com>2012-04-24 16:00:56 +0100
committerFrancesco Mazzoli <francesco@rabbitmq.com>2012-04-24 16:00:56 +0100
commit100f1750179a57193eed57b2ca454d352a630b74 (patch)
treeba2cc9eb46f7946d981795e6a3ff652b8a620283
parent0a9c5474c0e020fbab0bb204d3d687f51e4ecb87 (diff)
downloadrabbitmq-server-100f1750179a57193eed57b2ca454d352a630b74.tar.gz
Add comment explaining why ack() and state() exist.
-rw-r--r--src/rabbit_variable_queue.erl5
1 files changed, 4 insertions, 1 deletions
diff --git a/src/rabbit_variable_queue.erl b/src/rabbit_variable_queue.erl
index c3462929..8fc55dba 100644
--- a/src/rabbit_variable_queue.erl
+++ b/src/rabbit_variable_queue.erl
@@ -324,7 +324,6 @@
-type(timestamp() :: {non_neg_integer(), non_neg_integer(), non_neg_integer()}).
-type(seq_id() :: non_neg_integer()).
--type(ack() :: seq_id()).
-type(rates() :: #rates { egress :: {timestamp(), non_neg_integer()},
ingress :: {timestamp(), non_neg_integer()},
@@ -336,6 +335,10 @@
count :: non_neg_integer(),
end_seq_id :: non_neg_integer() }).
+%% The compiler (rightfully) complains that ack() and state() are unused. The
+%% problem here is that we can't parametrise the BQ behaviour by these two types
+%% as we would like to. We still leave these here for documentation purposes.
+-type(ack() :: seq_id()).
-type(state() :: #vqstate {
q1 :: ?QUEUE:?QUEUE(),
q2 :: ?QUEUE:?QUEUE(),