diff options
author | Matthias Radestock <matthias@rabbitmq.com> | 2013-05-25 21:57:33 +0100 |
---|---|---|
committer | Matthias Radestock <matthias@rabbitmq.com> | 2013-05-25 21:57:33 +0100 |
commit | d4c1dd230e08fe9794a4508c52030d1c6290e73a (patch) | |
tree | 095a2056c67dda9b856b64b40058003757c82d5a | |
parent | 84fd8e5e56a9641fd23305166e8d1dd8458bd6a3 (diff) | |
download | rabbitmq-server-d4c1dd230e08fe9794a4508c52030d1c6290e73a.tar.gz |
simplify error logging
-rw-r--r-- | src/rabbit_access_control.erl | 17 |
1 files changed, 7 insertions, 10 deletions
diff --git a/src/rabbit_access_control.erl b/src/rabbit_access_control.erl index 16387268..5b92a5c3 100644 --- a/src/rabbit_access_control.erl +++ b/src/rabbit_access_control.erl @@ -71,9 +71,7 @@ check_vhost_access(User = #user{ username = Username, rabbit_vhost:exists(VHostPath) andalso Module:check_vhost_access(User, VHostPath) end, - "~s failed checking vhost access to ~s for ~s: ~p~n", - [Module, VHostPath, Username], - "access to vhost '~s' refused for user '~s'", + Module, "access to vhost '~s' refused for user '~s'", [VHostPath, Username]). check_resource_access(User, R = #resource{kind = exchange, name = <<"">>}, @@ -84,15 +82,14 @@ check_resource_access(User = #user{username = Username, auth_backend = Module}, Resource, Permission) -> check_access( fun() -> Module:check_resource_access(User, Resource, Permission) end, - "~s failed checking resource access to ~p for ~s: ~p~n", - [Module, Resource, Username], - "access to ~s refused for user '~s'", + Module, "access to ~s refused for user '~s'", [rabbit_misc:rs(Resource), Username]). -check_access(Fun, ErrStr, ErrArgs, RefStr, RefArgs) -> +check_access(Fun, Module, ErrStr, ErrArgs) -> Allow = case Fun() of - {error, _} = E -> - rabbit_log:error(ErrStr, ErrArgs ++ [E]), + {error, E} -> + rabbit_log:error(ErrStr ++ " by ~s: ~p~n", + ErrArgs ++ [Module, E]), false; Else -> Else @@ -101,5 +98,5 @@ check_access(Fun, ErrStr, ErrArgs, RefStr, RefArgs) -> true -> ok; false -> - rabbit_misc:protocol_error(access_refused, RefStr, RefArgs) + rabbit_misc:protocol_error(access_refused, ErrStr, ErrArgs) end. |