summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSimon MacMullen <simon@rabbitmq.com>2014-04-16 13:25:38 +0100
committerSimon MacMullen <simon@rabbitmq.com>2014-04-16 13:25:38 +0100
commitc6e332a5723ee6aececdf2ef67398ccc26b32362 (patch)
tree470e96e3d02c74ddf2d7e5c3a552ab3e3d954fff
parent79c0f9cd425253e8035be03fe029ec0973c9ee99 (diff)
parent27d16335d0e3025b718d7dc9bad9b3749e2fd43f (diff)
downloadrabbitmq-server-c6e332a5723ee6aececdf2ef67398ccc26b32362.tar.gz
Merge bug26118
-rw-r--r--Makefile5
-rw-r--r--src/mirrored_supervisor.erl8
-rw-r--r--src/rabbit_mirror_queue_misc.erl4
3 files changed, 11 insertions, 6 deletions
diff --git a/Makefile b/Makefile
index e413f879..81a477ae 100644
--- a/Makefile
+++ b/Makefile
@@ -194,6 +194,11 @@ run: all
RABBITMQ_SERVER_START_ARGS="$(RABBITMQ_SERVER_START_ARGS)" \
./scripts/rabbitmq-server
+run-background: all
+ $(BASIC_SCRIPT_ENVIRONMENT_SETTINGS) \
+ RABBITMQ_SERVER_START_ARGS="$(RABBITMQ_SERVER_START_ARGS)" \
+ ./scripts/rabbitmq-server -detached
+
run-node: all
$(BASIC_SCRIPT_ENVIRONMENT_SETTINGS) \
RABBITMQ_NODE_ONLY=true \
diff --git a/src/mirrored_supervisor.erl b/src/mirrored_supervisor.erl
index 7a352451..1ed6d710 100644
--- a/src/mirrored_supervisor.erl
+++ b/src/mirrored_supervisor.erl
@@ -446,10 +446,10 @@ supervisor(Pid) -> with_exit_handler(fun() -> dead end,
fun() -> delegate(Pid) end).
write(Group, Overall, ChildSpec) ->
- ok = mnesia:write(
- #mirrored_sup_childspec{key = {Group, id(ChildSpec)},
- mirroring_pid = Overall,
- childspec = ChildSpec}),
+ S = #mirrored_sup_childspec{key = {Group, id(ChildSpec)},
+ mirroring_pid = Overall,
+ childspec = ChildSpec},
+ ok = mnesia:write(?TABLE, S, write),
ChildSpec.
delete(Group, Id) ->
diff --git a/src/rabbit_mirror_queue_misc.erl b/src/rabbit_mirror_queue_misc.erl
index a2f4eec5..ff1d5815 100644
--- a/src/rabbit_mirror_queue_misc.erl
+++ b/src/rabbit_mirror_queue_misc.erl
@@ -203,13 +203,13 @@ start_child(Name, MirrorNode, Q, SyncMode) ->
report_deaths(_MirrorPid, _IsMaster, _QueueName, []) ->
ok;
report_deaths(MirrorPid, IsMaster, QueueName, DeadPids) ->
- log_info(QueueName, "~s ~s saw deaths of mirrors ~s~n",
+ log_info(QueueName, "~s ~s saw deaths of mirrors~s~n",
[case IsMaster of
true -> "Master";
false -> "Slave"
end,
rabbit_misc:pid_to_string(MirrorPid),
- [[rabbit_misc:pid_to_string(P), $ ] || P <- DeadPids]]).
+ [[$ , rabbit_misc:pid_to_string(P)] || P <- DeadPids]]).
log_info (QName, Fmt, Args) -> log(info, QName, Fmt, Args).
log_warning(QName, Fmt, Args) -> log(warning, QName, Fmt, Args).