From 8a25a1aa86eb707bb0ed68d3f78f18f4a25c0bc5 Mon Sep 17 00:00:00 2001 From: Jean-Sebastien Pedron Date: Wed, 26 Nov 2014 17:53:45 +0100 Subject: Drop {refuse, _, _} from rabbit_auth_mechanism:handle_response/2 return values --- src/rabbit_auth_mechanism.erl | 3 --- src/rabbit_reader.erl | 4 ---- 2 files changed, 7 deletions(-) diff --git a/src/rabbit_auth_mechanism.erl b/src/rabbit_auth_mechanism.erl index 4f771db2..c8e23a75 100644 --- a/src/rabbit_auth_mechanism.erl +++ b/src/rabbit_auth_mechanism.erl @@ -36,15 +36,12 @@ %% Another round is needed. Here's the state I want next time. %% {protocol_error, Msg, Args} %% Client got the protocol wrong. Log and die. -%% {refused, Msg, Args} -%% (deprecated) Client failed authentication. Log and die. %% {refused, Username, Msg, Args} %% Client failed authentication. Log and die. -callback handle_response(binary(), any()) -> {'ok', rabbit_types:user()} | {'challenge', binary(), any()} | {'protocol_error', string(), [any()]} | - {'refused', string(), [any()]} | {'refused', rabbit_types:username() | none, string(), [any()]}. -else. diff --git a/src/rabbit_reader.erl b/src/rabbit_reader.erl index 364dfc05..713b1844 100644 --- a/src/rabbit_reader.erl +++ b/src/rabbit_reader.erl @@ -1048,10 +1048,6 @@ auth_phase(Response, case AuthMechanism:handle_response(Response, AuthState) of {refused, Username, Msg, Args} -> auth_fail(Username, Msg, Args, Name, State); - {refused, Msg, Args} -> - %% Deprecated: older auth mechanisms don't return the - %% username, even if they reach a stage where they know it. - auth_fail(none, Msg, Args, Name, State); {protocol_error, Msg, Args} -> notify_auth_result(none, user_authentication_failure, Msg, Args, State), -- cgit v1.2.1