diff options
author | antirez <antirez@gmail.com> | 2010-12-19 12:22:12 +0100 |
---|---|---|
committer | antirez <antirez@gmail.com> | 2010-12-19 12:23:35 +0100 |
commit | 1443a814d0a204c55e6bae21042adefb9acc6f6d (patch) | |
tree | f6d5d236515883172eda58d11224bd582ad0171b | |
parent | 6418b4c790adc1373cea9e4e3342982e9a209505 (diff) | |
download | redis-1443a814d0a204c55e6bae21042adefb9acc6f6d.tar.gz |
overflow detection in INCR family functions
-rw-r--r-- | src/t_string.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/src/t_string.c b/src/t_string.c index eb080c882..c3e3607f3 100644 --- a/src/t_string.c +++ b/src/t_string.c @@ -346,14 +346,19 @@ void msetnxCommand(redisClient *c) { } void incrDecrCommand(redisClient *c, long long incr) { - long long value; + long long value, oldvalue; robj *o; o = lookupKeyWrite(c->db,c->argv[1]); if (o != NULL && checkType(c,o,REDIS_STRING)) return; if (getLongLongFromObjectOrReply(c,o,&value,NULL) != REDIS_OK) return; + oldvalue = value; value += incr; + if ((incr < 0 && value > oldvalue) || (incr > 0 && value < oldvalue)) { + addReplyError(c,"increment or decrement would overflow"); + return; + } o = createStringObjectFromLongLong(value); dbReplace(c->db,c->argv[1],o); touchWatchedKey(c->db,c->argv[1]); |