diff options
author | Binbin <binloveplay1314@qq.com> | 2022-06-07 22:38:31 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-06-07 17:38:31 +0300 |
commit | ae9764ea0a6bb3cfeff9baae2d4fd748a53d1864 (patch) | |
tree | b816ae67053c2e5eb450e1db9591dabae9de5907 | |
parent | b8665b879b760d13d103a00667a6277e372ea18b (diff) | |
download | redis-ae9764ea0a6bb3cfeff9baae2d4fd748a53d1864.tar.gz |
Increment the stat_rdb_saves counter in SAVE command (#10827)
Currently, we only increment stat_rdb_saves in rdbSaveBackground,
we should also increment it in the SAVE command.
We concluded there's no need to increment when:
1. saving a base file for an AOF
2. when saving an empty rdb file to delete an old one
3. when saving to sockets (not creating a persistence / snapshot file)
The stat counter was introduced in #10178
* fix a wrong comment in startSaving
-rw-r--r-- | src/rdb.c | 5 |
1 files changed, 4 insertions, 1 deletions
@@ -2746,7 +2746,7 @@ void stopLoading(int success) { } void startSaving(int rdbflags) { - /* Fire the persistence modules end event. */ + /* Fire the persistence modules start event. */ int subevent; if (rdbflags & RDBFLAGS_AOF_PREAMBLE && getpid() != server.pid) subevent = REDISMODULE_SUBEVENT_PERSISTENCE_AOF_START; @@ -3479,6 +3479,9 @@ void saveCommand(client *c) { addReplyError(c,"Background save already in progress"); return; } + + server.stat_rdb_saves++; + rdbSaveInfo rsi, *rsiptr; rsiptr = rdbPopulateSaveInfo(&rsi); if (rdbSave(SLAVE_REQ_NONE,server.rdb_filename,rsiptr) == C_OK) { |