summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorantirez <antirez@gmail.com>2020-01-13 13:25:37 +0100
committerantirez <antirez@gmail.com>2020-01-13 13:25:37 +0100
commit28d146bed69cd1d288ff435fe86ca9ad2c9cb879 (patch)
tree04e2a1dc85fe55e50b646885e360f0f59a208998
parent9506c860f6642bc14aa4079e991c1c298138044a (diff)
downloadredis-28d146bed69cd1d288ff435fe86ca9ad2c9cb879.tar.gz
Simplify #6379 changes.
-rw-r--r--src/aof.c5
-rw-r--r--src/cluster.c8
2 files changed, 4 insertions, 9 deletions
diff --git a/src/aof.c b/src/aof.c
index efdd68efa..9eeb3f1e2 100644
--- a/src/aof.c
+++ b/src/aof.c
@@ -1149,10 +1149,7 @@ int rioWriteBulkStreamID(rio *r,streamID *id) {
int retval;
sds replyid = sdscatfmt(sdsempty(),"%U-%U",id->ms,id->seq);
- if ((retval = rioWriteBulkString(r,replyid,sdslen(replyid))) == 0) {
- sdsfree(replyid);
- return 0;
- }
+ retval = rioWriteBulkString(r,replyid,sdslen(replyid));
sdsfree(replyid);
return retval;
}
diff --git a/src/cluster.c b/src/cluster.c
index f9d8ae151..c05e46f76 100644
--- a/src/cluster.c
+++ b/src/cluster.c
@@ -276,11 +276,9 @@ int clusterLoadConfig(char *filename) {
} else {
start = stop = atoi(argv[j]);
}
- if (start < 0 || start >= CLUSTER_SLOTS) {
- sdsfreesplitres(argv,argc);
- goto fmterr;
- }
- if (stop < 0 || stop >= CLUSTER_SLOTS) {
+ if (start < 0 || start >= CLUSTER_SLOTS ||
+ stop < 0 || stop >= CLUSTER_SLOTS)
+ {
sdsfreesplitres(argv,argc);
goto fmterr;
}