summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorzhaozhao.zz <zhaozhao.zz@alibaba-inc.com>2019-05-21 11:37:13 +0800
committerzhaozhao.zz <zhaozhao.zz@alibaba-inc.com>2019-05-21 11:37:13 +0800
commit8b33975944397a0522f6d05d0776d9871a7c6be0 (patch)
treeff81cebbbd1c9a8361096fdd745f39374aa86956
parentfd0ee469ab165d0e005e9fe1fca1c4f5c604cd56 (diff)
downloadredis-8b33975944397a0522f6d05d0776d9871a7c6be0.tar.gz
Threaded IO: use main thread to handle write work
-rw-r--r--src/networking.c12
1 files changed, 10 insertions, 2 deletions
diff --git a/src/networking.c b/src/networking.c
index 4bc22120a..4da762a15 100644
--- a/src/networking.c
+++ b/src/networking.c
@@ -2525,7 +2525,7 @@ pthread_mutex_t io_threads_mutex[IO_THREADS_MAX_NUM];
_Atomic unsigned long io_threads_pending[IO_THREADS_MAX_NUM];
int io_threads_active; /* Are the threads currently spinning waiting I/O? */
int io_threads_op; /* IO_THREADS_OP_WRITE or IO_THREADS_OP_READ. */
-list *io_threads_list[IO_THREADS_MAX_NUM];
+list *io_threads_list[IO_THREADS_MAX_NUM+1];
void *IOThreadMain(void *myid) {
/* The ID is the thread number (from 0 to server.iothreads_num-1), and is
@@ -2598,6 +2598,7 @@ void initThreadedIO(void) {
}
io_threads[i] = tid;
}
+ io_threads_list[server.io_threads_num] = listCreate();
}
void startThreadedIO(void) {
@@ -2669,7 +2670,7 @@ int handleClientsWithPendingWritesUsingThreads(void) {
while((ln = listNext(&li))) {
client *c = listNodeValue(ln);
c->flags &= ~CLIENT_PENDING_WRITE;
- int target_id = item_id % server.io_threads_num;
+ int target_id = item_id % (server.io_threads_num+1);
listAddNodeTail(io_threads_list[target_id],c);
item_id++;
}
@@ -2682,6 +2683,13 @@ int handleClientsWithPendingWritesUsingThreads(void) {
io_threads_pending[j] = count;
}
+ listRewind(io_threads_list[server.io_threads_num],&li);
+ while((ln = listNext(&li))) {
+ client *c = listNodeValue(ln);
+ writeToClient(c->fd,c,0);
+ }
+ listEmpty(io_threads_list[server.io_threads_num]);
+
/* Wait for all threads to end their work. */
while(1) {
unsigned long pending = 0;