summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorantirez <antirez@gmail.com>2018-02-16 11:55:51 +0100
committerantirez <antirez@gmail.com>2018-03-15 12:54:10 +0100
commitc9d86c2b16a106f90504dbab5c7ba91068975c3a (patch)
tree986a812dd3385398063ec94efe7a0fe2d35c7ade
parent9f60a6bcee16c35eed14408303062a27d6dd0be3 (diff)
downloadredis-c9d86c2b16a106f90504dbab5c7ba91068975c3a.tar.gz
CG: More specific duplicated group error.
-rw-r--r--src/t_stream.c3
-rw-r--r--tests/unit/type/stream-cgroups.tcl11
2 files changed, 13 insertions, 1 deletions
diff --git a/src/t_stream.c b/src/t_stream.c
index c071c3dc1..872005949 100644
--- a/src/t_stream.c
+++ b/src/t_stream.c
@@ -1391,7 +1391,8 @@ NULL
if (cg) {
addReply(c,shared.ok);
} else {
- addReplyError(c,"Consumer Group name already exists");
+ addReplySds(c,
+ sdsnew("-BUSYGROUP Consumer Group name already exists\r\n"));
}
} else if (!strcasecmp(opt,"SETID") && c->argc == 5) {
} else if (!strcasecmp(opt,"DELGROUP") && c->argc == 4) {
diff --git a/tests/unit/type/stream-cgroups.tcl b/tests/unit/type/stream-cgroups.tcl
new file mode 100644
index 000000000..9a657a9ed
--- /dev/null
+++ b/tests/unit/type/stream-cgroups.tcl
@@ -0,0 +1,11 @@
+start_server {
+ tags {"stream"}
+} {
+ test {XGROUP CREATE: creation and duplicate group name detection} {
+ r DEL mystream
+ r XADD mystream * foo bar
+ r XGROUP CREATE mystream mygroup $
+ catch {r XGROUP CREATE mystream mygroup $} err
+ set err
+ } {BUSYGROUP*}
+}