summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorantirez <antirez@gmail.com>2019-05-13 17:27:06 +0200
committerantirez <antirez@gmail.com>2019-05-13 17:27:10 +0200
commit4f4676a1420a446e4233c04a80f2009aa819b21f (patch)
treebac7e8be0c0b48dc63c5ce837706ee54360ad605
parente633254ccf7c0342e981dbeb8687e54bf4a15c64 (diff)
downloadredis-4f4676a1420a446e4233c04a80f2009aa819b21f.tar.gz
Fix test false positive introduced by threaded I/O.
Now clients that are ready to be terminated asynchronously are processed more often in beforeSleep() instead of being processed in serverCron(). This means that the test will not be able to catch the moment the client was terminated, also note that the 'omem' figure now changes in big steps, because of the new client output buffers layout. So we have to change the test range in order to accomodate for that. Yet the test is useful enough to be worth taking, even if its precision is reduced by this commit. Probably if we get more problems, a thing that makes sense is just to check that the limit is < 200k. That's more than enough actually.
-rw-r--r--tests/unit/obuf-limits.tcl2
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/unit/obuf-limits.tcl b/tests/unit/obuf-limits.tcl
index 5d625cf45..c45bf8e86 100644
--- a/tests/unit/obuf-limits.tcl
+++ b/tests/unit/obuf-limits.tcl
@@ -15,7 +15,7 @@ start_server {tags {"obuf-limits"}} {
if {![regexp {omem=([0-9]+)} $c - omem]} break
if {$omem > 200000} break
}
- assert {$omem >= 90000 && $omem < 200000}
+ assert {$omem >= 70000 && $omem < 200000}
$rd1 close
}