diff options
| author | antirez <antirez@gmail.com> | 2015-08-06 15:08:54 +0200 |
|---|---|---|
| committer | antirez <antirez@gmail.com> | 2015-08-20 10:15:13 +0200 |
| commit | 0b765249830576b995d9556c7e6a20ed37620337 (patch) | |
| tree | 0d0e71d10fe8846b022203d06c9787ae0d6bdb4c | |
| parent | 421582f845e20defc3d628d50bea9f2faa90bdaa (diff) | |
| download | redis-0b765249830576b995d9556c7e6a20ed37620337.tar.gz | |
flushSlavesOutputBuffers(): details clarified via comments.
Talking with @oranagra we had to reason a little bit to understand if
this function could ever flush the output buffers of the wrong slaves,
having online state but actually not being ready to receive writes
before the first ACK is received from them (this happens with diskless
replication).
Next time we'll just read this comment.
| -rw-r--r-- | src/networking.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/src/networking.c b/src/networking.c index 8094353a3..94b2eceec 100644 --- a/src/networking.c +++ b/src/networking.c @@ -1680,6 +1680,12 @@ void flushSlavesOutputBuffers(void) { redisClient *slave = listNodeValue(ln); int events; + /* Note that the following will not flush output buffers of slaves + * in STATE_ONLINE but having put_online_on_ack set to true: in this + * case the writable event is never installed, since the purpose + * of put_online_on_ack is to postpone the moment it is installed. + * This is what we want since slaves in this state should not receive + * writes before the first ACK. */ events = aeGetFileEvents(server.el,slave->fd); if (events & AE_WRITABLE && slave->replstate == REDIS_REPL_ONLINE && |