diff options
| author | guybe7 <guy.benoish@redislabs.com> | 2022-01-20 10:32:11 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-01-20 11:32:11 +0200 |
| commit | 10bbeb68377bc2b20442e6578183dbc61fb57ec3 (patch) | |
| tree | 2b74cd978aaa459d0e118687ac279ba26eca8d13 /src/commands/cluster-delslots.json | |
| parent | 9c6029225060a52d433ce7e5707736080688fe80 (diff) | |
| download | redis-10bbeb68377bc2b20442e6578183dbc61fb57ec3.tar.gz | |
Add command tips to COMMAND DOCS (#10104)
Adding command tips (see https://redis.io/topics/command-tips) to commands.
Breaking changes:
1. Removed the "random" and "sort_for_script" flags. They are now command tips.
(this isn't affecting redis behavior since #9812, but could affect some client applications
that's relying on COMMAND command flags)
Summary of changes:
1. add BLOCKING flag (new flag) for all commands that could block. The ACL category with
the same name is now implicit.
2. move RANDOM flag to a `nondeterministic_output` tip
3. move SORT_FOR_SCRIPT flag to `nondeterministic_output_order` tip
3. add REQUEST_POLICY and RESPONSE_POLICY where appropriate as documented in the tips
4. deprecate (ignore) the `random` flag for RM_CreateCommand
Other notes:
1. Proxies need to send `RANDOMKEY` to all shards and then select one key randomly.
The other option is to pick a random shard and transfer `RANDOMKEY `to it, but that scheme
fails if this specific shard is empty
2. Remove CMD_RANDOM from `XACK` (i.e. XACK does not have RANDOM_OUTPUT)
It was added in 9e4fb96ca12476b1c7468b143efca86b478bfb4a, I guess by mistake.
Also from `(P)EXPIRETIME` (new command, was flagged "random" by mistake).
3. Add `nondeterministic_output` to `OBJECT ENCODING` (for the same reason `XTRIM` has it:
the reply may differ depending on the internal representation in memory)
4. RANDOM on `HGETALL` was wrong (there due to a limitation of the old script sorting logic), now
it's `nondeterministic_output_order`
5. Unrelated: Hide CMD_PROTECTED from COMMAND
Diffstat (limited to 'src/commands/cluster-delslots.json')
| -rw-r--r-- | src/commands/cluster-delslots.json | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/commands/cluster-delslots.json b/src/commands/cluster-delslots.json index 99f1ea9ff..862299b7e 100644 --- a/src/commands/cluster-delslots.json +++ b/src/commands/cluster-delslots.json @@ -10,9 +10,11 @@ "command_flags": [ "NO_ASYNC_LOADING", "ADMIN", - "RANDOM", "STALE" ], + "command_tips": [ + "NONDETERMINISTIC_OUTPUT" + ], "arguments": [ { "name": "slot", |