diff options
author | Salvatore Sanfilippo <antirez@gmail.com> | 2020-04-02 11:23:23 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-04-02 11:23:23 +0200 |
commit | dfef4074999d2640f0336551937605802299f08b (patch) | |
tree | b713a1395e7c0de05fa5b8a6092f03985662c87f /tests/unit | |
parent | 8d6dc136e162004b874ffa868246dde7d89d447e (diff) | |
parent | 1547d72cf3ec4ef5b67cbba7cf50726983be31e4 (diff) | |
download | redis-dfef4074999d2640f0336551937605802299f08b.tar.gz |
Merge pull request #7029 from valentinogeron/fix-xack
XACK should be executed in a "all or nothing" fashion.
Diffstat (limited to 'tests/unit')
-rw-r--r-- | tests/unit/type/stream-cgroups.tcl | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/tests/unit/type/stream-cgroups.tcl b/tests/unit/type/stream-cgroups.tcl index a27e1f582..04661707b 100644 --- a/tests/unit/type/stream-cgroups.tcl +++ b/tests/unit/type/stream-cgroups.tcl @@ -93,6 +93,18 @@ start_server { assert {[r XACK mystream mygroup $id1 $id2] eq 1} } + test {XACK should fail if got at least one invalid ID} { + r del mystream + r xgroup create s g $ MKSTREAM + r xadd s * f1 v1 + set c [llength [lindex [r xreadgroup group g c streams s >] 0 1]] + assert {$c == 1} + set pending [r xpending s g - + 10 c] + set id1 [lindex $pending 0 0] + assert_error "*Invalid stream ID specified*" {r xack s g $id1 invalid-id} + assert {[r xack s g $id1] eq 1} + } + test {PEL NACK reassignment after XGROUP SETID event} { r del events r xadd events * f1 v1 |