summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Fix redis-benchmark abort output1906-mergeMatt Stancliff2014-08-251-1/+1
|
* Deny CLIENT command in scriptsMatt Stancliff2014-08-251-1/+1
| | | | | | | | | | We don't want scripts doing CLIENT SETNAME or CLIENT KILL or CLIENT LIST or CLIENT PAUSE. Originally reported by Chris Wj then proper action inspired by Itamar Haber. Reference: https://groups.google.com/forum/#!topic/redis-db/09B2EYwyVgk
* redis-benchmark: Remove unused bufferMatt Stancliff2014-08-251-9/+0
| | | | | | | | | | This just deletes old code that didn't get removed when logic changed. We were setting offsets that never got read anywhere. Since clients are now just cloned, we don't need to track per-client buffer offsets anywhere because they are all the same from the original client.
* redis-benchmark: add auth optionCharSyam2014-08-251-0/+14
| | | | Closes #1097
* Rename two 'buf' vars to 'ip' for better clarityMatt Stancliff2014-08-251-5/+5
| | | | | Clearly ip[32] is wrong, but it's less clear that buf[32] was wrong without further reading.
* Sentinel: fix bufsize to support IPv6 addressEiichi Sato2014-08-251-2/+2
| | | | Closes #1914
* Use correct github url to find commands.jsonJan-Erik Rediger2014-08-251-1/+1
| | | | | | | | | | Once this is merged: - merge the latest changes to commands.json in antirez/redis-doc - re-run: utils/generate-command-help.rb > src/help.h Then we'll have nice and easy tab-completed help in redis-cli again. Closes #1909
* Stop tests from leaving a black backgroundMariano Pérez Rodríguez2014-08-251-1/+1
| | | | | | | | Uses ANSI "default background" color code after closing tests so any non-black terminals don't remain polluted. Fixes #1649 Closes #1912
* Sentinel: Reject config from STDINMatt Stancliff2014-08-251-0/+7
| | | | | | | Sentinel needs to die with a more accurate error message when attempted to open a config from STDIN. See: https://groups.google.com/forum/#!topic/redis-db/sYx7VNMWaNM
* Cluster: Fix segfault if cluster config corruptMatt Stancliff2014-08-251-3/+7
| | | | | | | | | | | This commit adds a size check after initial config line parsing to make sure we have *at least* 8 arguments per line. Also, instead of asserting for cluster->myself, we just test and error out normally (since the error does a hard exit anyway). Closes #1597
* Fix memory leak in cluster config parsingMatt Stancliff2014-08-181-0/+1
| | | | | | The continue stop us from triggering the free after the long line for loop, so add it earlier.
* Remove unused global variableMatt Stancliff2014-08-181-1/+0
| | | | It has an important name, but nothing uses it...
* Fix invalid expire error for SET family commands.antirez2014-08-181-1/+1
|
* Remove unused functionCong Ding2014-08-181-6/+0
| | | | Closes #878
* Extend range of bytesToHuman to TB and PBDavid Palm2014-08-181-0/+9
| | | | | | | Also adds a fallthrough case for when given large values (like overflow numbers of 2^64 by mistake). Closes #858
* Add error check for writing RDB checksumyoav2014-08-181-1/+1
| | | | Closes #857
* redis-cli: fix prompt after shutdown commandDov Murik2014-08-181-1/+4
| | | | | Fix redis-cli prompt to state "not connected" after a SHUTDOWN command is sent.
* Clarify argument to dict macroxiaoyu2014-08-181-1/+1
| | | | | | d is more clear because the type of argument is dict not dictht Closes #513
* Clarify existing slot wording on cluster startMatt Stancliff2014-08-181-6/+5
|
* Remove warnings and improve integer sign correctness.antirez2014-08-1317-48/+66
|
* Add -W to compilation flags.antirez2014-08-131-1/+1
|
* Use unsigned integers in SDS header.antirez2014-08-134-9/+15
| | | | This raises the max string to 4GB without any downside.
* va_copy must be matched by va_endPieter Noordhuis2014-08-121-0/+1
| | | | | | Hat tip to @rfuchs. See: https://github.com/redis/hiredis/pull/178. Fixes #1187
* Remove duplicate prototypes in redis.hcharsyam2014-08-121-3/+1
| | | | | | Also moves acceptHandler() to be near the other accept...() functions. Closes #1105
* Use resolv library in SolarisNanXiao2014-08-121-1/+1
| | | | | | | | | | For some Solaris flavours, the inet_aton in in resolv library. Not linking this library will introduce link error. Improves compatability with older Solaris and still works on new Solaris. Closes #1092
* Define AR to help with lua cross-compilationDaniel Price2014-08-121-1/+6
| | | | Closes #997
* representRedisNodeFlags() moved into right code section.antirez2014-08-081-38/+41
| | | | | | | The funciton was also modified in order to be more standalone and produce an output without trailing spaces, making the reuse simpler. The global variable was renamed in cammel case as most other Redis globals, except the main ones we refer too many times, like 'server'.
* Refactor cluster flag printingcharsyam2014-08-081-20/+36
| | | | | | Less copy/paste code duplication. Closes #952
* Cleanup double semicolonsMatt Stancliff2014-08-082-2/+2
| | | | Closes #1161
* Free memory in clusterLoadConfig error handlerSungBin_Hong2014-08-081-0/+1
| | | | Closes #1327
* redis-check-dump: Prevent segfault if can't mallocChris Lamb2014-08-081-0/+1
| | | | | | | | | | Found by The Mayhem Team (Alexandre Rebert, Thanassis Avgerinos, Sang Kil Cha, David Brumley, Manuel Egele) Cylab, Carnegie Mellon University. See http://bugs.debian.org/716259 for more. Signed-off-by: Chris Lamb <lamby@debian.org> Fixes #1191
* Remove unused LINE_BUFLEN definitioncharsyam2014-08-081-1/+0
| | | | Closes #1129
* Reject MOVE to non-integer DBsMatt Stancliff2014-08-082-1/+12
| | | | | | | | | | | | | Previously, "MOVE key somestring" would move the key to DB 0 which is just unexpected and wrong. String as DB == error. Test added too. Modified by @antirez in order to use the getLongLongFromObject() API instead of strtol(). Fixes #1428
* pubsub: Return integers for NUMSUB, not stringsMatt Stancliff2014-08-082-1/+5
| | | | | | | | Also adds test for numsub — due to tcl being tcl, it doesn't capture the "numberness" of the fix, but now we at least have one test case for numsub. Closes #1561
* Avoid unnecessary decoding in ziplist.cXiaojie Zhang2014-08-081-13/+13
| | | | Closes #1519
* Improve accuracy of HAVE_ATOMIC dependency checkSamuel Chou2014-08-081-1/+6
| | | | | | | [I had to split out the clang check due to clang *really* not liking the __GLIBC_PREREQ macro; -matt] Closes #1456
* Remove redundant event loop fd processingJim Howard2014-08-081-2/+2
| | | | | | | Reason: https://github.com/antirez/redis/pull/1450#issuecomment-30432925 Closes #1450
* memtest: Add missing free()Xian Li2014-08-081-0/+1
| | | | Closes #1614
* src/Makefile: Reword "to run make test" messageJoshua Anderson2014-08-081-1/+1
| | | | Closes #1610
* Use 'void' for zero-argument functionscubicdaiya2014-08-086-20/+20
| | | | | | | | According to the C standard, it is desirable to give the type 'void' to functions have no argument. Closes #1631
* Fix assert technical correctnessMatt Stancliff2014-08-081-1/+1
| | | | | | | | dictAdd returns DICT_OK, not REDIS_OK. They both have the same underlying values, so it works even though the code is technically wrong. Fixes #1512
* install_server.sh: add missing bangJan-Erik Rediger2014-08-071-2/+2
| | | | | | | | This was discovered by _bodya and reported in the IRC channel. Everything worked fine as these scripts are always executed as shell scripts. Closes #1728
* Change unixsocketperm comment to 700 from 755Edgars Irmejs2014-08-071-1/+1
| | | | | | | | According to unix manuals, "Connecting to the socket object requires read/write permission." -- mode 755 is useless for anybody other than the owner. Fixes #1696
* redis-check-dump: use names instead of magic numsripcurld00d2014-08-071-1/+3
| | | | | | | Use constants to avoid magic numbers in `types`, which is an array that stores the names of `REDIS` types. Closes #1681
* Fix issues raised by clang analyzerKashif Rasul2014-08-072-4/+4
| | | | | | | | | | | Modified by @antirez since the original fix to genInfoString() looked weak. Probably the clang analyzer complained about `section` being possibly NULL, and strcasecmp() called with a NULL pointer. In the practice this can never happen, still for the sake of correctness the right fix is not to modify only the first call, but to set `section` to the value of "default" if it happens to be NULL. Closes #1660
* Force quit when receiving a second SIGINT.antirez2014-08-072-2/+14
| | | | | Also quit ASAP when we are still loading a DB, since care is not needed in this special condition, especially for a SIGINT.
* Add graceful exit when Ctrl-C is receivedMatt Stancliff2014-08-071-5/+17
|
* Fix intset midpoint selectionMatt Stancliff2014-08-071-1/+1
| | | | | | | | | | | The classic (min+max)/2 is provably unsafe. Fixed as recommended in research: http://googleresearch.blogspot.com/2006/06/extra-extra-read-all-about-it-nearly.html Fix inspired by @wjin, but I used a different approach. (later, I found @kuebler fixed the same issue too). Fixes #1741, #1602
* Fix key extraction for SORTMatt Stancliff2014-08-072-2/+11
| | | | | | | | | | We only want to use the last STORE key, but we have to record we actually found a STORE key so we can increment the final return key count. Test added to prevent further regression. Closes #1883, #1645, #1647
* Handle large getrange requestsJan-Erik Rediger2014-08-072-1/+6
| | | | | | | | Previously the end was casted to a smaller type which resulted in a wrong check and failed with values larger than handled by unsigned. Closes #1847, #1844
View Lorry Controller Status