summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Redis 2.8.3.2.8.3antirez2013-12-112-1/+19
|
* Replication: publish the slave_repl_offset when disconnected from master.antirez2013-12-111-1/+8
| | | | | | | | When a slave was disconnected from its master the replication offset was reported as -1. Now it is reported as the replication offset of the previous master, so that failover can be performed using this value in order to try to select a slave with more processed data from a set of slaves of the old master.
* Return proper error on requests with an unbalanced number of quotes.Yossi Gottlieb2013-12-112-0/+13
|
* Fix wrong repldboff type which causes dropped replication in rare cases.Yossi Gottlieb2013-12-111-1/+1
|
* Slaves heartbeats during sync improved.antirez2013-12-103-15/+29
| | | | | | | | | | | | | | | The previous fix for false positive timeout detected by master was not complete. There is another blocking stage while loading data for the first synchronization with the master, that is, flushing away the current data from the DB memory. This commit uses the newly introduced dict.c callback in order to make some incremental work (to send "\n" heartbeats to the master) while flushing the old data from memory. It is hard to write a regression test for this issue unfortunately. More support for debugging in the Redis core would be needed in terms of functionalities to simulate a slow DB loading / deletion.
* dict.c: added optional callback to dictEmpty().antirez2013-12-108-21/+22
| | | | | | | | | | Redis hash table implementation has many non-blocking features like incremental rehashing, however while deleting a large hash table there was no way to have a callback called to do some incremental work. This commit adds this support, as an optiona callback argument to dictEmpty() that is currently called at a fixed interval (one time every 65k deletions).
* Log empty DB + Loading data into two separated messages.antirez2013-12-101-1/+2
|
* Don't send more than 1 newline/sec while loading RDB.antirez2013-12-101-2/+6
|
* Slaves heartbeat while loading RDB files.antirez2013-12-102-1/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Starting with Redis 2.8 masters are able to detect timed out slaves, while before 2.8 only slaves were able to detect a timed out master. Now that timeout detection is bi-directional the following problem happens as described "in the field" by issue #1449: 1) Master and slave setup with big dataset. 2) Slave performs the first synchronization, or a full sync after a failed partial resync. 3) Master sends the RDB payload to the slave. 4) Slave loads this payload. 5) Master detects the slave as timed out since does not receive back the REPLCONF ACK acknowledges. Here the problem is that the master has no way to know how much the slave will take to load the RDB file in memory. The obvious solution is to use a greater replication timeout setting, but this is a shame since for the 0.1% of operation time we are forced to use a timeout that is not what is suited for 99.9% of operation time. This commit tries to fix this problem with a solution that is a bit of an hack, but that modifies little of the replication internals, in order to be back ported to 2.8 safely. During the RDB loading time, we send the master newlines to avoid being sensed as timed out. This is the same that the master already does while saving the RDB file to still signal its presence to the slave. The single newline is used because: 1) It can't desync the protocol, as it is only transmitted all or nothing. 2) It can be safely sent while we don't have a client structure for the master or in similar situations just with write(2).
* Handle inline requested terminated with just \n.antirez2013-12-101-1/+8
|
* Sentinel: fix reported role info sampling.antirez2013-12-061-10/+10
| | | | | | | The way the role change was recoded was not sane and too much convoluted, causing the role information to be not always updated. This commit fixes issue #1445.
* Sentinel: fix reported role fields when master is reset.antirez2013-12-061-0/+2
| | | | | | | | | | | | | When there is a master address switch, the reported role must be set to master so that we have a chance to re-sample the INFO output to check if the new address is reporting the right role. Otherwise if the role was wrong, it will be sensed as wrong even after the address switch, and for enough time according to the role change time, for Sentinel consider the master SDOWN. This fixes isue #1446, that describes the effects of this bug in practice.
* Fixed typo in redis.conf.antirez2013-12-061-1/+1
|
* Grammar fix.Anurag Ramdasan2013-12-051-1/+1
|
* fixed typoAnurag Ramdasan2013-12-051-1/+1
|
* Fixed grammar: 'usually' to 'usual'Anurag Ramdasan2013-12-051-1/+1
|
* Fixed grammar: before H the article is a, not an.antirez2013-12-0518-28/+28
|
* Fixed typos in redis.conf file.antirez2013-12-051-8/+8
|
* Removed old comments and dead code from freeClient().antirez2013-12-032-14/+14
|
* Grammar fix in freeClient().antirez2013-12-031-1/+1
|
* Redis 2.8.2.2.8.2antirez2013-12-022-1/+10
|
* Sentinel: don't write HZ when flushing config.antirez2013-12-021-7/+11
| | | | See issue #1419.
* Sentinel: better time desynchronization.antirez2013-12-021-5/+10
| | | | | | | | | | | | | | | | | | Sentinels are now desynchronized in a better way changing the time handler frequency between 10 and 20 HZ. This way on average a desynchronization of 25 milliesconds is produced that should be larger enough compared to network latency, avoiding most split-brain condition during the vote. Now that the clocks are desynchronized, to have larger random delays when performing operations can be easily achieved in the following way. Take as example the function that starts the failover, that is called with a frequency between 10 and 20 HZ and will start the failover every time there are the conditions. By just adding as an additional condition something like rand()%4 == 0, we can amplify the desynchronization between Sentinel instances easily. See issue #1419.
* Stop writes on MISCONF only if instance is a master.antirez2013-11-281-2/+4
| | | | | From the point of view of the slave not accepting writes from the master can only create a bigger consistency issue.
* SLAVEOF command refactored into a proper API.antirez2013-11-282-15/+28
| | | | | We now have replicationSetMaster() and replicationUnsetMaster() that can be called in other contexts (for instance Redis Cluster).
* Reply to PING with error when there is a MISCONF state.antirez2013-11-281-1/+2
|
* Sentinel: log vote received from other Sentinels.antirez2013-11-281-0/+5
|
* fix a bug in sentinel.c about pub/sub linkhuangz19902013-11-261-3/+2
|
* Redis 2.8.1.2.8.1antirez2013-11-252-1/+10
|
* Merge pull request #1370 from yaauie/deprecate-redis-copy-script-2.8Salvatore Sanfilippo2013-11-251-55/+12
|\ | | | | Deprecate redis copy script 2.8
| * Deprecate utils/redis-copy.rb in favor of redis-copy gemRyan Biesemeyer2013-11-081-55/+12
| |
* | Sentinel: fixes inverted strcmp() test preventing config updates.antirez2013-11-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | The result of this one-char bug was pretty serious, if the new master had the same port of the previous master, but just a different IP address, non-leader Sentinels would not be able to recognize the configuration change. This commit fixes issue #1394. Many thanks to @shanemadden that reported the bug and helped investigating it.
* | Sentinel: fix type specifier for Hello msg generation.antirez2013-11-251-2/+2
| | | | | | | | This fixes issue #1395.
* | Fix false positive in memory efficiency test.antirez2013-11-251-1/+1
| | | | | | | | Fixes issue #1298.
* | Redis 2.8.0.2.8.0antirez2013-11-222-1/+10
| |
* | Sentinel: example sentinel.conf updated.antirez2013-11-211-31/+27
| |
* | Sentinel: different comments updated to new implementation.antirez2013-11-211-21/+18
| |
* | Sentinel: cleanup around SENTINEL_INFO_VALIDITY_TIME.antirez2013-11-211-15/+25
| |
* | Sentinel: removed mem leak and useless code.antirez2013-11-211-8/+0
| |
* | Sentinel: manual failover works again.antirez2013-11-211-2/+5
| |
* | Sentinel: test for writable config file.antirez2013-11-213-2/+14
| | | | | | | | | | This commit introduces a funciton called when Sentinel is ready for normal operations to avoid putting Sentinel specific stuff in redis.c.
* | Sentinel: check for disconnected links in sentinelSendHello().antirez2013-11-211-0/+1
| | | | | | | | | | Does not fix any bug as the test is performed by the caller, but better to have the check.
* | Sentinel: Hello message sending code refactored.antirez2013-11-211-21/+41
| |
* | Sentinel: select slave with best (greater) replication offset.antirez2013-11-211-2/+13
| |
* | Sentinel: take the replication offset in slaves state.antirez2013-11-211-1/+11
| |
* | CONFIG REWRITE: don't add the signature if it already exists.antirez2013-11-211-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | At the end of the file, CONFIG REWRITE adds a comment line that: # Generated by CONFIG REWRITE Followed by the additional config options required. However this was added again and again at every rewrite in praticular conditions (when a given set of options change in a given time during the time). Now if it was alrady encountered, it is not added a second time. This is especially important for Sentinel that rewrites the config at every state change.
* | Sentinel: distinguish between is-master-down-by-addr requests.antirez2013-11-212-7/+15
| | | | | | | | | | | | | | Some are just to know if the master is down, and in this case the runid in the request is set to "*", others are actually in order to seek for a vote and get elected. In the latter case the runid is set to the runid of the instance seeking for the vote.
* | Sentinel: various fixes to leader election implementation.antirez2013-11-211-28/+40
| |
* | Sentinel: failover script execution fixed.antirez2013-11-211-9/+21
| |
* | Sentinel: no longer used defines removed.antirez2013-11-211-8/+1
| |
View Lorry Controller Status