summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* Detect corrupted sparse HLLs in hllSparseSum().antirez2014-04-161-11/+18
|
* hllSparseAdd(): faster code removing conditional.antirez2014-04-161-5/+14
| | | | | Bottleneck found profiling. Big run time improvement found when testing after the change.
* Comment typo in hllSparseAdd(). first -> fits.antirez2014-04-161-1/+1
|
* Merge adjacent VAL opcodes in hllSparseAdd().antirez2014-04-161-5/+36
| | | | | As more values are added splitting ZERO or XZERO opcodes, try to merge adjacent VAL opcodes if they have the same value.
* More robust HLL_SPARSE macros protecting 'p' with parens.antirez2014-04-161-8/+8
| | | | Now the macros will work with arguments such as "ptr+1".
* hllSparseAdd() opcode seek stop condition fixed.antirez2014-04-161-1/+1
|
* Fixed error message generation in PFDEBUG GETREG.antirez2014-04-161-1/+2
| | | | | | Bulk length for registers was emitted too early, so if there was a bug the reply looked like a long array with just one element, blocking the client as result.
* Fixed memmove() count in hllSparseAdd().antirez2014-04-161-1/+1
|
* hllSparseAdd(): more correct dense conversion conditional.antirez2014-04-161-1/+1
| | | | | We want to promote if the total string size exceeds the resulting size after the upgrade.
* hllSparseToDense(): sanity check added.antirez2014-04-161-5/+20
| | | | | | | | | | The function checks if all the HLL_REGISTERS were processed during the convertion from sparse to dense encoding, returning REDIS_OK or REDIS_ERR to signal a corruption problem. A bug in PFDEBUG GETREG was fixed: when the object is converted to the dense representation we need to reassign the new pointer to the header structure pointer.
* PFDEBUG DECODE added.antirez2014-04-161-0/+35
| | | | | | Provides a human readable description of the opcodes composing a run-length encoded HLL (sparse encoding). The command is only useful for debugging / development tasks.
* PFDEBUG added, PFGETREG removed.antirez2014-04-163-9/+25
| | | | | PFDEBUG will be the interface to do debugging tasks with a key containing an HLL object.
* hllSparseToDense API changed to take ref to object.antirez2014-04-161-6/+10
| | | | | | The new API takes directly the object doing everything needed to turn it into a dense representation, including setting the new representation as object->ptr.
* hllSparseAdd() sanity check for span != 0 added.antirez2014-04-161-0/+3
|
* Fix hllSparseAdd() new sequence replacement when next is NULL.antirez2014-04-161-4/+2
| | | | | sdsIncrLen() must be called anyway even if we are replacing the last oppcode of the sparse representation.
* Fix seqlen computation in hllSparseAdd().antirez2014-04-161-1/+1
|
* Abstract hllSparseAdd() / hllDenseAdd() via hllAdd().antirez2014-04-161-4/+19
|
* hllSparseSum(): multiply 1 * runlen for zero entries.antirez2014-04-161-2/+2
|
* Macro HLL_SPARSE_XZERO_LEN fixed.antirez2014-04-161-1/+1
|
* Fix HLL sparse object creation #2.antirez2014-04-161-2/+2
| | | | Two vars initialized to wrong values in createHLLObject().
* Increment pointer while iterating sparse HLL object.antirez2014-04-161-0/+6
|
* Fix HLL sparse object creation.antirez2014-04-161-2/+2
| | | | | The function didn't considered the fact that each XZERO opcode is two bytes.
* Create HyperLogLog objects with sparse encoding.antirez2014-04-161-10/+28
|
* HyperLogLog sparse to dense conversion function.antirez2014-04-161-3/+44
|
* HyperLogLog sparse representation initial implementation.antirez2014-04-161-9/+269
| | | | | | | | | Code never tested, but the basic layout is shaped in this commit. Also missing: 1) Sparse -> Dense conversion function. 2) New HLL object creation using the sparse representation. 3) Implementation of PFMERGE for the sparse representation.
* hllCount() refactored to support multiple representations.antirez2014-04-161-34/+62
|
* hllAdd() refactored into two functions.antirez2014-04-161-24/+35
| | | | Also dense representation access macro renamed accordingly.
* HyperLogLog refactoring to support different encodings.antirez2014-04-161-99/+135
| | | | | | | Metadata are now placed at the start of the representation as an header. There is a proper structure to access the representation. Still work to do in order to truly abstract the implementation from the representation, commands still work assuming dense representation.
* HyperLogLog sparse representation slightly modified.antirez2014-04-161-39/+43
| | | | | | | After running a few simulations with different alternative encodings, it was found that the VAL opcode performs better using 5 bits for the value and 2 bits for the run length, at least for cardinalities in the range of interest.
* HyperLogLog sparse representation description and macros.antirez2014-04-161-3/+104
|
* Add casting to match printf format.antirez2014-04-162-7/+12
| | | | | | | adjustOpenFilesLimit() and clusterUpdateSlotsWithConfig() that were assuming uint64_t is the same as unsigned long long, which is true probably for all the systems out there that we target, but still GCC emitted a warning since technically they are two different types.
* ZRANGEBYLEX and ZREVRANGEBYLEX implementation.antirez2014-04-163-2/+456
|
* PFCOUNT: always unshare/decode the object.antirez2014-04-161-3/+1
| | | | | | This will be a non-op most of the times since the object will be unshared / decoded, however it is more technically correct to start this way since the object may be decoded even in the read-only code path.
* tryObjectEncoding() refactoring.antirez2014-04-161-42/+54
| | | | We also avoid to re-create an object that is already in EMBSTR encoding.
* Changed HyperLogLog hash seed to a non-zero value.antirez2014-04-161-1/+1
| | | | | | | | | | | | | | | Using a seed of zero has the side effect of having the empty string hashing to what is a very special case in the context of HyperLogLog: a very long run of zeroes. This did not influenced the correctness of the result with 16k registers because of the harmonic mean, but still it is inconvenient that a so obvious value maps to a so special hash. The seed 0xadc83b19 is used instead, which is the first 64 bits of the SHA1 of the empty string. Reference: issue #1657.
* Initial HyperLogLog tests.antirez2014-04-162-0/+69
|
* Return "WRONGTYPE" error on PF* type mismatch.antirez2014-04-161-1/+3
|
* Fix PFADD infinite loop.antirez2014-04-161-6/+3
| | | | | | | | We need to guarantee that the last bit is 1, otherwise an element may hash to just zeroes with probability 1/(2^64) and trigger an infinite loop. See issue #1657.
* Make hll-gnuplot-graph.rb callable from cli.antirez2014-04-161-4/+5
|
* Remove HyperLogLog type checking duplicated code.antirez2014-04-161-45/+21
|
* PFGETREG added for testing purposes.antirez2014-04-163-2/+42
| | | | | The new command allows to get a dump of the registers stored into an HyperLogLog data structure for testing / debugging purposes.
* PFCOUNT: unshare the object when cached cardinality is modified.antirez2014-04-161-0/+3
|
* PFSELFTEST improved to test the approximation error.antirez2014-04-161-6/+35
|
* hll-gnuplot-graph.rb improved with new filter.antirez2014-04-161-13/+22
| | | | | | The function to generate graphs is also more flexible as now includes step and max value. The step of the samples generation function is no longer limited to min step of 1000.
* HyperLogLog: added magic / version.antirez2014-04-161-25/+45
| | | | | | | This will allow future changes like compressed representations. Currently the magic is not checked for performance reasons but this may change in the future, for example if we add new types encoded in strings that may have the same size of HyperLogLogs.
* Fixed pfadd/pfcount commands emitting hll* events instead of pf* eventsRaymond Myers2014-04-161-2/+2
|
* Change HLL* to PF* in error messagesRaymond Myers2014-04-161-3/+3
|
* Include redis.h before other stuff in hyperloglog.c.antirez2014-04-161-1/+2
| | | | | Otherwise fmacros.h is included later and this may break compilation on different systems.
* HyperLogLog API prefix modified from "P" to "PF".antirez2014-04-165-19/+19
| | | | Using both the initials of Philippe Flajolet instead of just "P".
* Makefile.dep updated with hyperloglog.o deps.antirez2014-04-161-3/+7
|
View Lorry Controller Status