| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
| |
When we are blocked and a few events a processed from time to time, it
is smarter to call the event handler a few times in order to handle the
accept, read, write, close cycle of a client in a single pass, otherwise
there is too much latency added for clients to receive a reply while the
server is busy in some way (for example during the DB loading).
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the listening sockets readable event is fired, we have the chance
to accept multiple clients instead of accepting a single one. This makes
Redis more responsive when there is a mass-connect event (for example
after the server startup), and in workloads where a connect-disconnect
pattern is used often, so that multiple clients are waiting to be
accepted continuously.
As a side effect, this commit makes the LOADING, BUSY, and similar
errors much faster to deliver to the client, making Redis more
responsive when there is to return errors to inform the clients that the
server is blocked in an not interruptible operation.
|
| |
|
|
|
|
|
|
|
| |
Verify proper expire-before-delete behavior.
This test passes with the expire-before-delete commit and fails
without it.
|
|
|
|
|
|
| |
Deleting an expired key should return 0, not success.
Fixes #1648
|
|
|
|
|
|
| |
I happen to be working on a system that lacks urandom. While the code does try
to handle this case and artificially create some bytes if the file pointer is
empty, it does try to close it unconditionally, leading to a segfault.
|
|\
| |
| | |
Fixed typos.
|
| | |
|
|/
|
|
|
|
|
| |
When we set a protocol error we should return with REDIS_ERR to let the
caller know it should stop processing the client.
Bug found in a code auditing related to issue #1699.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
The internal HLL raw encoding used by PFCOUNT when merging multiple keys
is aligned to 8 bits (1 byte per register) so we can exploit this to
improve performances by processing multiple bytes per iteration.
In benchmarks the new code was several times faster with HLLs with many
registers set to zero, while no slowdown was observed with populated
HLLs.
|
|
|
|
|
|
| |
When the register is set to zero, we need to add 2^-0 to E, which is 1,
but it is faster to just add 'ez' at the end, which is the number of
registers set to zero, a value we need to compute anyway.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
Given that the code was written with a 2 years pause... something
strange happened in the middle. So there was no function to free a
lex range min/max objects, and in some places the range was passed by
value.
|
|
|
|
| |
Like ZCOUNT for lexicographical ranges.
|
| |
|
| |
|
|
|
|
| |
Converts HyperLogLogs from sparse to dense. Used for testing.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After running a few benchmarks, 3000 looks like a reasonable value to
keep HLLs with a few thousand elements small while the CPU cost is
still not huge.
This covers all the cases where the dense representation would use N
orders of magnitude more space, like in the case of many HLLs with
carinality of a few tens or hundreds.
It is not impossible that in the future this gets user configurable,
however it is easy to pick an unreasoable value just looking at savings
in the space dimension without checking what happens in the time
dimension.
|
| |
|
| |
|
|
|
|
| |
It is safer since it is able to have side effects.
|
|
|
|
|
| |
Even if it is a debugging command, make sure that when it forces a
change in encoding, the command is propagated.
|
|
|
|
|
| |
If we converted to dense, a register must be updated in the dense
representation.
|
|
|
|
|
| |
Mostly by reordering opcodes check conditional by frequency of opcodes
in larger sparse-encoded HLLs.
|
| |
|
|
|
|
|
| |
Bottleneck found profiling. Big run time improvement found when testing
after the change.
|
| |
|
|
|
|
|
| |
As more values are added splitting ZERO or XZERO opcodes, try to merge
adjacent VAL opcodes if they have the same value.
|
|
|
|
| |
Now the macros will work with arguments such as "ptr+1".
|
| |
|
|
|
|
|
|
| |
Bulk length for registers was emitted too early, so if there was a bug
the reply looked like a long array with just one element, blocking the
client as result.
|
| |
|
|
|
|
|
| |
We want to promote if the total string size exceeds the resulting size
after the upgrade.
|
|
|
|
|
|
|
|
|
|
| |
The function checks if all the HLL_REGISTERS were processed during the
convertion from sparse to dense encoding, returning REDIS_OK or
REDIS_ERR to signal a corruption problem.
A bug in PFDEBUG GETREG was fixed: when the object is converted to the
dense representation we need to reassign the new pointer to the header
structure pointer.
|