| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Related to issue #2409.
|
|
|
|
|
|
|
|
| |
1. Remove useless "cs" initialization.
2. Add a "select" var to capture a condition checked multiple times.
3. Avoid duplication of the same if (!copy) conditional.
4. Don't increment dirty if copy is given (no deletion is performed),
otherwise we propagate MIGRATE when not needed.
|
|
|
|
|
| |
Avoid redundant SELECT calls when continuously migrating keys to
the same dbid within a target Redis instance.
|
| |
|
|\
| |
| | |
rehashing.c: Fix compile error originating from SPOP rewrite
|
| | |
|
| | |
|
| |
| |
| |
| |
| | |
This is safe since bufpos is small, inside the range of the local
client buffer.
|
| | |
|
|\ \
| | |
| | | |
Bitops: Stop overallocating storage space on set
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Previously the string was created empty then re-sized
to fit the offset, but sds resize causes the sds to
over-allocate by at least 1 MB (which is a lot when
you are operating at bit-level access).
This also improves the speed of initial sets by 2% to 6%
based on quick testing.
Patch logic provided by @oranagra
Fixes #1918
|
|\ \ \
| | | |
| | | | |
Sentinel: Add initial quorum bounds check
|
| | | |
| | | |
| | | |
| | | | |
Fixes #2054
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Revert some size_t back to off_t
Set reply_bytes needs to 64 bits everywhere
Revert bufpos to int since it's a max of 16k into buf[]
|
|\ \ \ \
| | | | |
| | | | | |
Improve type correctness
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
read() and write() return ssize_t (signed long), not int.
For other offsets, we can use the unsigned size_t type instead
of a signed offset (since our replication offsets and buffer
positions are never negative).
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
It's possible large objects could be larger than 'int', so let's
upgrade all size counters to ssize_t.
This also fixes rdbSaveObject serialized bytes calculation.
Since entire serializations of data structures can be large,
so we don't want to limit their calculated size to a 32 bit signed max.
This commit increases object size calculation and
cascades the change back up to serializedlength printing.
Before:
127.0.0.1:6379> debug object hihihi
... encoding:quicklist serializedlength:-2147483559 ...
After:
127.0.0.1:6379> debug object hihihi
... encoding:quicklist serializedlength:2147483737 ...
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Sentinel: Improve INFO command behavior
|
| | |_|/ /
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Improvements:
- Return empty string if asking for non-existing section (INFO foo)
- Fix potential memory leak (caused by sdsempty() then returned if >2 args)
- Clean up argument parsing
- Allow "all" as valid section (same as "default" or zero args currently)
- Move strcasecmp to end of evaluation chain in conditionals
Also, since we're C99, I moved some variable declarations to be closer
to where they are actually used (saves us from needing to free an empty info
if detect argument errors up front).
Closes #1915
Closes #1966
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Improve consistency of INFO MEMORY
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Since we have the eviction policy, we should have the memory limit too.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Adds used_memory_rss_human and used_memory_lua_human to match
all the other fields reporting human-readable memory too.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix quicklist Pop()
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Now the tests actually compare return values instead of just
verifying _something_ got returned.
|
| | |_|_|_|/
| |/| | | |
| | | | | |
| | | | | | |
Closes #2398
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fixes issue #2392.
|
| | | | | | |
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
It's hard to pick a good approach here. A few arguments:
1) There are many exposed instances on the internet.
2) Changing the default when "bind" is not given is very dangerous,
after an upgrade the server changes a fundamental behavior.
3) Usually Redis, when used in a proper way, will be protected *and*
accessed often from other computers, so this new default is likely
not what most people want.
4) However if users end with this default, they are using the example
redis.conf: likely they are reading what is inside, and they'll see
the warning.
|
|\ \ \ \ \ |
|
| |\ \ \ \ \
| | | | | | |
| | | | | | | |
Readme fix
|
| | | | | | | |
|
| | | | | | | |
|
|/ / / / / / |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Apparently no refernece-style links supported in Github markdown.
|
| | | | | | |
|
|/ / / / / |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Less grays: more readable palette since usually we have a non linear
distribution of percentages and very near gray tones are hard to take
apart. Final part of the palette is gradient from yellow to red. The red
part is hardly reached because of usual distribution of latencies, but
shows up mainly when latencies are very high because of the logarithmic
scale, this is coherent to what people expect: red = bad.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Unify to uppercase the headline
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Related to PR #2357.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Support "1G" etc. units in CONFIG SET maxmemory
|
| | |_|_|/ /
| |/| | | |
| | | | | |
| | | | | | |
Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
|
| |/ / / /
|/| | | |
| | | | |
| | | | | |
Related to PR #2357.
|
| | | | | |
|
| | | | | |
|
| | | | | |
|