| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
| |
See issue #4466 / #4467.
|
| | |
|
| |\
| |
| | |
fix boundary case for _dictNextPower
|
| | | |
|
| |\ \
| | |
| | | |
Fixes an off-by-one in argument handling of `MEMORY USAGE`
|
| |/ /
| |
| | |
Fixes #4430
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Normally in modern Redis you can't create zero-len lists, however it's
possible to load them from old RDB files generated, for instance, using
Redis 2.8 (see issue #4409). The "Right Thing" would be not loading such
lists at all, but this requires to hook in rdb.c random places in a not
great way, for a problem that is at this point, at best, minor.
Here in this commit instead I just fix the fact that zero length lists,
materialized as quicklists with the first node set to NULL, were
iterated in the wrong way while they are saved, leading to a crash.
The other parts of the list implementation are apparently able to deal
with empty lists correctly, even if they are no longer a thing.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Since SDS v2, we no longer have a single header, so the function to
rewrite the SDS in terms of the minimum space required, instead of just
using realloc() and let the underlying allocator decide what to do,
was doing an allocation + copy every time the minimum possible header
needed to represent the string was different than the current one.
This could be often a bit wasteful, because if we go, for instance, from
the 32 bit fields header to the 16 bit fields header, the overhead of
the header is normally very small. With this commit we call realloc
instead, unless the change in header size is very significant in relation
to the string length.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
There was not enough sanity checking in the code loading the slots of
Redis Cluster from the nodes.conf file, this resulted into the
attacker's ability to write data at random addresses in the process
memory, by manipulating the index of the array. The bug seems
exploitable using the following techique: the config file may be altered so
that one of the nodes gets, as node ID (which is the first field inside the
structure) some data that is actually executable: then by writing this
address in selected places, this node ID part can be executed after a
jump. So it is mostly just a matter of effort in order to exploit the
bug. In practice however the issue is not very critical because the
bug requires an unprivileged user to be able to modify the Redis cluster
nodes configuration, and at the same time this should result in some
gain. However Redis normally is unprivileged as well. Yet much better to
have this fixed indeed.
Fix #4278.
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
Certain checks were useless, at the same time certain malformed inputs
were accepted without problems (emtpy strings parsed as zero).
Cases where strtod() returns ERANGE but we still want to parse the input
where ok in getDoubleFromObject() but not in the long variant.
As a side effect of these fixes, this commit fixes #4391.
|
| | | |
|
| |\ \
| | |
| | | |
Module Context flags
|
| | | |
| | |
| | |
| | | |
in MULTI
|
| | | | |
|
| |/ / |
|
| | | |
|
| |\ \
| | |
| | | |
Lazyfree: avoid memory leak when free slowlog entry
|
| |/ / |
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This commit is a reinforcement of commit c1c99e9.
1. Replication information can be stored when the RDB file is
generated by a mater using server.slaveseldb when server.repl_backlog
is not NULL, or set repl_stream_db be -1. That's safe, because
NULL server.repl_backlog will trigger full synchronization,
then master will send SELECT command to replicaiton stream.
2. Only do rdbSave* when rsiptr is not NULL,
if we do rdbSave* without rdbSaveInfo, slave will miss repl-stream-db.
3. Save the replication informations also in the case of
SAVE command, FLUSHALL command and DEBUG reload.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This commit attempts to fix a number of bugs reported in #4316.
They are related to the way replication info like replication ID,
offsets, and currently selected DB in the master client, are stored
and loaded by Redis. In order to avoid inconsistencies the changes in
this commit try to enforce that:
1. Replication information are only stored when the RDB file is
generated by a slave that has a valid 'master' client, so that we can
always extract the currently selected DB.
2. When replication informations are persisted in the RDB file, all the
info for a successful PSYNC or nothing is persisted.
3. The RDB replication informations are only loaded if the instance is
configured as a slave, otherwise a master can start with IDs that relate
to a different history of the data set, and stil retain such IDs in the
future while receiving unrelated writes.
|
| |\ \ |
|
| | |\ \
| | | |
| | | | |
redis-benchmark: default value size usage update.
|
| | | | |
| | | |
| | | |
| | | | |
default size of SET/GET value in usage should be 3 bytes as in main code.
|
| | |\ \ \
| | | | |
| | | | | |
Remove Duplicate Processing
|
| | | | | | |
|
| |/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
A slave may be started with an RDB file able to provide enough slave to
perform a successful partial SYNC with its master. However in such a
case, how outlined in issue #4268, the slave backlog will not be
started, since it was only initialized on full syncs attempts. This
creates different problems with successive PSYNC attempts that will
always result in full synchronizations.
Thanks to @fdingiit for discovering the issue.
|
| |\ \ \ \
| | | | |
| | | | | |
Flush append only buffers before existing.
|
| |/ / / /
| | | |
| | | |
| | | |
| | | |
| | | | |
when SHUTDOWN command is recived it is possible that some of the recent
command were not yet flushed from the AOF buffer, and the server
experiences data loss at shutdown.
|
| |\ \ \ \
| | | | |
| | | | | |
Add missing fclose()
|
| |/ / / / |
|
| |\ \ \ \
| | | | |
| | | | | |
Changes command stats iteration to being dict-based
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
With the addition of modules, looping over the redisCommandTable
misses any added commands. By moving to dictionary iteration this
is resolved.
|
| | |_|/ /
|/| | | |
|
| |\ \ \ \
| | | | |
| | | | | |
Don't use extended Regexp Syntax
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
It's not POSIX (BSD systems have -E instead) and we don't actually need it.
Closes #1922
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Check that the whole first argument is a number
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fixes #2258
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Correct proceding -> proceeding typo.
|
| | | | | | | | |
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
fix rewrite config: auto-aof-rewrite-min-size
|
| | | | | | | | | |
|
| |\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Fix missing '-' in redis-benchmark help output (Issue #1996)
|
| | | | | | | | | | |
|
| |\ \ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | | |
fix mismatch argument and return wrong value of clusterDelNodeSlots
|
| | | | | | | | | | | |
|
| | | |_|/ / / / / /
| |/| | | | | | | |
|
| |\ \ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | | |
Fix lua ldb command log
|
| |/ / / / / / / / / |
|
