summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * Fix DEBUG structsize output.antirez2015-07-141-7/+7
| |
| * sds size classes - memory optimizationOran Agra2015-07-148-139/+364
| |
* | Merge pull request #2636 from badboy/cluster-lock-fixSalvatore Sanfilippo2015-07-172-1/+7
|\ \ | | | | | | Cluster lock fix
| * | Don't include sysctl headerJan-Erik Rediger2015-06-241-1/+0
| | | | | | | | | | | | It's not needed (anymore) and is not available on Solaris.
| * | Do not attempt to lock on SolarisJan-Erik Rediger2015-06-241-0/+7
| | |
* | | Merge pull request #2644 from MOON-CLJ/command_info_fixSalvatore Sanfilippo2015-07-171-1/+1
|\ \ \ | | | | | | | | pfcount support multi keys
| * | | pfcount support multi keysMOON_CLJ2015-06-261-1/+1
| |/ /
* | | bugfix: errno might change before loggingYongyue Sun2015-07-172-2/+2
| | | | | | | | | | | | Signed-off-by: Yongyue Sun <abioy.sun@gmail.com>
* | | Fix: aof_delayed_fsync is not resetTom Kiemes2015-07-171-0/+1
| | | | | | | | | | | | aof_delayed_fsync was not set to 0 when calling CONFIG RESETSTAT
* | | Merge pull request #2676 from july2993/unstableSalvatore Sanfilippo2015-07-172-4/+4
|\ \ \ | | | | | | | | config tcp-keepalive should be numerical field not bool
| * | | config tcp-keepalive should be numerical field not boolJiahao Huang2015-07-162-4/+4
| | |/ | |/|
* | | Client timeout handling improved.antirez2015-07-161-12/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previos attempt to process each client at least once every ten seconds was not a good idea, because: 1. Usually because of the past min iterations set to 50, you get much better processing period most of the times. 2. However when there are many clients and a normal setting for server.hz, the edge case is triggered, and waiting 10 seconds for a BLPOP that asked for 1 second is not ok. 3. Moreover, because of the high min-itereations limit of 50, when HZ was set to an high value, the actual behavior was to process a lot of clients per second. Also the function checking for timeouts called gettimeofday() at each iteration which can be costly. The new implementation will try to process each client once per second, gets the current time as argument, and does not attempt to process more than 5 clients per iteration if not needed. So now: 1. The CPU usage of an idle Redis process is the same or better. 2. The CPU usage of a busy Redis process is the same or better. 3. However a non trivial amount of work may be performed per iteration when there are many many clients. In this particular case the user may want to raise the "HZ" value if needed. Btw with 4000 clients it was still not possible to noticy any actual latency created by processing 400 clients per second, since the work performed for each client is pretty small.
* | | Clarify a comment in clientsCron().antirez2015-07-161-5/+5
|/ /
* | DEBUG HTSTATS <dbid> added.antirez2015-07-144-91/+66
| | | | | | | | | | | | | | | | The command reports information about the hash table internal state representing the specified database ID. This can be used in order to investigate rehashings, memory usage issues and for other debugging purposes.
* | EXISTS is now variadic.antirez2015-07-132-6/+10
| | | | | | | | | | | | | | | | The new return value is the number of keys existing, among the ones specified in the command line, counting the same key multiple times if given multiple times (and if it exists). See PR #2667.
* | Geo: fix command table keys position indexes for three commands.antirez2015-07-131-3/+3
| | | | | | | | | | | | | | GEOHASH, GEOPOS and GEODIST where declared as commands not accepting keys, so the Redis Cluster redirection did not worked. Close #2671.
* | GEOENCODE / GEODECODE commands removed.antirez2015-07-093-108/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | Rationale: 1. The commands look like internals exposed without a real strong use case. 2. Whatever there is an use case, the client would implement the commands client side instead of paying RTT just to use a simple to reimplement library. 3. They add complexity to an otherwise quite straightforward API. So for now KILLED ;-)
* | Geo: use ULL suffix for unsigned 64 bit constants.antirez2015-07-091-14/+14
| |
* | Geo: -Ofast breaks builds on older GCCs.antirez2015-07-092-2/+2
| |
* | Geo: validate long,lat passed by user via APIantirez2015-07-063-9/+25
| |
* | Removed useless tryObjectEncoding() call from ZRANK.antirez2015-07-031-1/+1
| |
* | Geo: sync faster decoding from krtm that synched from Ardb.antirez2015-07-012-57/+96
| | | | | | | | | | | | Instead of successive divisions in iteration the new code uses bitwise magic to interleave / deinterleave two 32bit values into a 64bit one. All tests still passing and is measurably faster, so worth it.
* | Geo: added my copyright notice in modified files.geoantirez2015-06-295-0/+5
| |
* | Geo: support units only in abbreviated form.antirez2015-06-291-7/+7
| | | | | | | | | | I'm not a strong believer in multiple syntax for the same stuff, so now units can be specified only as m, km, ft, mi.
* | Geo: remove static declarations.antirez2015-06-291-6/+6
| | | | | | | | | | | | | | | | | | | | Stack traces produced by Redis on crash are the most useful tool we have to fix non easily reproducible crashes, or even easily reproducible ones where the user just posts a bug report and does not collaborate furhter. By declaring functions "static" they no longer show up in the stack trace.
* | Geo: GEODIST and tests.antirez2015-06-296-20/+94
| |
* | Geo: command function names converted to lowercase, as elsewhere.antirez2015-06-294-27/+21
| | | | | | | | | | In Redis MULTIWORDCOMMANDNAME are mapped to functions where the command name is all lowercase: multiwordcommandnameCommand().
* | Geo: GEOPOS command and tests.antirez2015-06-294-0/+52
| |
* | Geo: GEORADIUS COUNT tests.antirez2015-06-291-0/+8
| |
* | Geo: GEOENCODE test fixed for new return value.antirez2015-06-291-1/+2
| |
* | Geo: GEOENCODE: fix command arity check.antirez2015-06-291-3/+3
| |
* | Geo: GEOENCODE now returns score ranges.antirez2015-06-291-9/+22
| | | | | | | | | | | | | | | | If GEOENCODE must be our door to enter the Geocoding implementation details and do fancy things client side, than return the scores as well so that we can query the sorted sets directly if we wish to do the same search multiple times, or want to compute the boxes in the client side to refine our search needs.
* | Geo: fix comment indentation.antirez2015-06-291-1/+1
| |
* | Geo: debugging printf calls removed.antirez2015-06-291-7/+0
| |
* | Geo: GEOADD form using radius removed.antirez2015-06-291-19/+5
| | | | | | | | | | Can't immagine how this is useful in the context of the API exported by Redis, and we are always in time to add more bloat if needed, later.
* | Geo: commands top comment as in other Redis code.antirez2015-06-291-12/+7
| |
* | Geo: COUNT option for GEORADIUS.antirez2015-06-271-2/+20
| |
* | Geo: only one way to specify any given option.antirez2015-06-272-10/+11
| |
* | Geo: remove useless variable. geoRadiusGeneric() top comment improved.antirez2015-06-271-8/+4
| |
* | Geo: from lat,lon API to lon,lat API according to GIS standardantirez2015-06-267-176/+146
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The GIS standard and all the major DBs implementing GIS related functions take coordinates as x,y that is longitude,latitude. It was a bad start for Redis to do things differently, so even if this means that existing users of the Geo module will be required to change their code, Redis now conforms to the standard. Usually Redis is very backward compatible, but this is not an exception to this rule, since this is the first Geo implementation entering the official Redis source code. It is not wise to try to be backward compatible with code forks... :-) Close #2637.
* | Geo: explain increment magic in membersOfGeoHashBox().antirez2015-06-241-0/+20
| |
* | Geo: GEOHASH command test.antirez2015-06-241-0/+7
| |
* | Geo: GEOHASH command added, returning standard geohash strings.antirez2015-06-243-0/+57
| |
* | Geo: Fix geohashEstimateStepsByRadius() step underestimation.antirez2015-06-243-11/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The returned step was in some case not enough towards normal coordinates (for example when our search position was was already near the margin of the central area, and we had to match, using the east or west neighbor, a very far point). Example: geoadd points 67.575457940146066 -62.001317572780565 far geoadd points 66.685439060295664 -58.925040587282297 center georadius points 66.685439060295664 -58.925040587282297 200 km In the above case the code failed to find a match (happens at smaller latitudes too) even if far and center are at less than 200km. Another fix introduced by this commit is a progressively larger area towards the poles, since meridians are a lot less far away, so we need to compensate for this. The current implementation works comparably to the Tcl brute-force stress tester implemented in the fuzzy test in the geo.tcl unit for latitudes between -70 and 70, and is pretty accurate over +/-80 too, with sporadic false negatives. A more mathematically clean implementation is possible by computing the meridian distance at the specified latitude and computing the step according to it.
* | Geo: GEORADIUS fuzzy testing by reimplementing it in Tcl.antirez2015-06-241-0/+63
| | | | | | | | | | | | | | | | | | We set random points in the world, pick a random position, and check if the returned points by Redis match the ones computed by Tcl by brute forcing all the points using the distance between two points formula. This approach is sounding since immediately resulted in finding a bug in the original implementation.
* | Geo: return REDIS_* where appropriate, improve commentingantirez2015-06-231-12/+19
| |
* | Geo: test GEOADD with wrong input coordinatesantirez2015-06-231-0/+8
| |
* | Geo: GEOADD implementation improved, replication fixedantirez2015-06-233-37/+39
| | | | | | | | | | | | | | 1. We no longer use a fake client but just rewriting. 2. We group all the inserts into a single ZADD dispatch (big speed win). 3. As a side effect of the correct implementation, replication works. 4. The return value of the command is now correct.
* | Geo: more x,y renamed lat,lonantirez2015-06-231-8/+8
| |
* | Geo: rename x,y to lat,lon for clarityantirez2015-06-231-13/+12
| |
View Lorry Controller Status