summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Update pretty printing in debugging to generate valid Lua code for ↵testingPaul Kulchenko2015-12-221-2/+2
| | | | userdata-like types.
* Update pretty printing in debugging to generate valid Lua code for tables.Paul Kulchenko2015-12-221-1/+2
|
* Cluster: rebalance now supports --threshold option.antirez2015-12-181-2/+24
|
* Cluster: redis-trib reshard / rebalance --pipeline support.antirez2015-12-181-5/+21
|
* Cluster: verify slaves consistency after resharding.antirez2015-12-181-0/+23
|
* Fix typo in prepareClientToWrite() comment.antirez2015-12-181-1/+1
|
* Cluster: resharding test now checks AOF consistency.antirez2015-12-171-0/+42
| | | | | | It's a key invariant that when AOF is enabled, after the cluster reshards, a crash-recovery event causes all the keys to be still fine with the expected logical content. Now this is part of unit 04.
* Fix a race that may lead to the active (slave) client to be freed.antirez2015-12-171-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In issue #2948 a crash was reported in processCommand(). Later Oran Agra (@oranagra) traced the bug (in private chat) in the following sequence of events: 1. Some maxmemory is set. 2. The slave is the currently active client and is executing PING or REPLCONF or whatever a slave can send to its master. 3. freeMemoryIfNeeded() is called since maxmemory is set. 4. flushSlavesOutputBuffers() is called by freeMemoryIfNeeded(). 5. During slaves buffers flush, a write error could be encoutered in writeToClient() or sendReplyToClient() depending on the version of Redis. This will trigger freeClient() against the currently active client, so a segmentation fault will likely happen in processCommand() immediately after the call to freeMemoryIfNeeded(). There are different possible fixes: 1. Add flags to writeToClient() (recent versions code base) so that we can ignore the write errors, and use this flag in flushSlavesOutputBuffers(). However this is not simple to do in older versions of Redis. 2. Use freeClientAsync() during write errors. This works but changes the current behavior of releasing clients ASAP when possible. Normally we write to clients during the normal event loop processing, in the writable client, where there is no active client, so no care must be taken. 3. The fix of this commit: to detect that the current client is no longer valid. This fix is a bit "ad-hoc", but works across all the versions and has the advantage of not changing the remaining behavior. Only alters what happens during this race condition, hopefully.
* Fix processCommand() comment about return value.antirez2015-12-171-2/+2
|
* Hopefully better memory test on crash.antirez2015-12-173-86/+133
| | | | | | | | | | | | | | | The old test, designed to do a transformation on the bits that was invertible, in order to avoid touching the original memory content, was not effective as it was redis-server --test-memory. The former often reported OK while the latter was able to spot the error. So the test was substituted with one that may perform better, however the new one must backup the memory tested, so it tests memory in small pieces. This limits the effectiveness because of the CPU caches. However some attempt is made in order to trash the CPU cache between the fill and the check stages, but not for the addressing test unfortunately. We'll see if this test will be able to find errors where the old failed.
* Suppress harmless warnings.antirez2015-12-173-4/+8
|
* memtest.c now can be called as API in non interactive mode.antirez2015-12-172-43/+73
|
* Crash report format improvements.antirez2015-12-171-24/+35
|
* Cluster: allows abbreviated node IDs with rebalance --weight option.antirez2015-12-171-3/+19
|
* Cluster: rebalancing option --simulate, and a fix.antirez2015-12-171-8/+12
|
* Cluster: redis-trib rebalance initial implementation.antirez2015-12-171-17/+154
|
* Initial implementation of redis-trib info subcommand.antirez2015-12-171-0/+22
|
* Log address causing SIGSEGV.antirez2015-12-151-0/+4
|
* lua_struct.c/getnum: throw error if overflow happenSun He2015-12-141-4/+6
| | | | Fix issue #2855
* Cluster: redis-trib: use variadic MIGRATE.antirez2015-12-131-15/+13
| | | | | | | | | | | | | | | | We use the new variadic/pipelined MIGRATE for faster migration. Testing is not easy because to see the time it takes for a slot to be migrated requires a very large data set, but even with all the overhead of migrating multiple slots and to setup them properly, what used to take 4 seconds (1 million keys, 200 slots migrated) is now 1.6 which is a good improvement. However the improvement can be a lot larger if: 1. We use large datasets where a single slot has many keys. 2. By moving more than 10 keys per iteration, making this configurable, which is planned. Close #2710 Close #2711
* MIGRATE: Fix key extraction for new form.antirez2015-12-133-1/+29
|
* MIGRATE: test more corner cases.antirez2015-12-131-0/+37
|
* MIGRATE: Fix new argument rewriting refcount handling.antirez2015-12-131-3/+2
|
* MIGRATE: fix replies processing and argument rewriting.antirez2015-12-132-15/+40
| | | | | | | We need to process replies after errors in order to delete keys successfully transferred. Also argument rewriting was fixed since it was broken in several ways. Now a fresh argument vector is created and set if we are acknowledged of at least one key.
* Test: pipelined MIGRATE tests added.antirez2015-12-131-0/+54
|
* Pipelined multiple keys MIGRATE.antirez2015-12-132-63/+115
|
* Cluster: redis-trib migrate default timeout set to 60 sec.antirez2015-12-111-1/+1
|
* redis-trib.rb: --timeout XXXXX option added to fix and reshard commands. ↵daniele2015-12-111-4/+10
| | | | Defaults to 15000 milliseconds
* Cluster: replica migration with delay.antirez2015-12-112-17/+39
| | | | | | | | | We wait a fixed amount of time (5 seconds currently) much greater than the usual Cluster node to node communication latency, before migrating. This way when a failover occurs, before detecting the new master as a target for migration, we give the time to its natural slaves (the slaves of the failed over master) to announce they switched to the new master, preventing an useless migration operation.
* Cluster: more reliable migration tests.antirez2015-12-101-43/+24
| | | | | | | | The old version was modeled with two failovers, however after the first it is possible that another slave will migrate to the new master, since for some time the new master is not backed by any slave. Probably there should be some pause after a failover, before the migration. Anyway the test is simpler in this way, and depends less on timing.
* Cluster: more reliable replicas migration test.antirez2015-12-101-0/+75
|
* Remove debugging message left there for error.antirez2015-12-101-1/+0
|
* unlinkClient(): clear flags according to ops performed.antirez2015-12-101-0/+2
|
* Fix replicas migration by adding a new flag.antirez2015-12-092-20/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | Some time ago I broken replicas migration (reported in #2924). The idea was to prevent masters without replicas from getting replicas because of replica migration, I remember it to create issues with tests, but there is no clue in the commit message about why it was so undesirable. However my patch as a side effect totally ruined the concept of replicas migration since we want it to work also for instances that, technically, never had slaves in the past: promoted slaves. So now instead the ability to be targeted by replicas migration, is a new flag "migrate-to". It only applies to masters, and is set in the following two cases: 1. When a master gets a slave, it is set. 2. When a slave turns into a master because of fail over, it is set. This way replicas migration targets are only masters that used to have slaves, and slaves of masters (that used to have slaves... obviously) and are promoted. The new flag is only internal, and is never exposed in the output nor persisted in the nodes configuration, since all the information to handle it are implicit in the cluster configuration we already have.
* Fix typo UNCOMMENT -> COMMENT in example redis.conf.antirez2015-12-031-1/+1
|
* Centralize slave replication handshake aborting.antirez2015-12-031-22/+23
| | | | | | | | Now we have a single function to call in any state of the slave handshake, instead of using different functions for different states which is error prone. Change performed in the context of issue #2479 but does not fix it, since should be functionally identical to the past. Just an attempt to make replication.c simpler to follow.
* fix sprintf and snprintf format stringantirez2015-11-282-3/+3
| | | | | | | There are some cases of printing unsigned integer with %d conversion specificator and vice versa (signed integer with %u specificator). Patch by Sergey Polovko. Backported to Redis from Disque.
* Revert Lua's `redis.LOG_<level>` to originalItamar Haber2015-11-271-4/+4
| | | | Fixes #2898
* Handle wait3() errors.antirez2015-11-271-1/+7
| | | | | | | | | | | My guess was that wait3() with WNOHANG could never return -1 and an error. However issue #2897 may possibly indicate that this could happen under non clear conditions. While we try to understand this better, better to handle a return value of -1 explicitly, otherwise in the case a BGREWRITE is in progress but wait3() returns -1, the effect is to match the first branch of the if/else block since server.rdb_child_pid is -1, and call backgroundSaveDoneHandler() without a good reason, that will, in turn, crash the Redis server with an assertion.
* Redis Cluster: hint about validity factor when slave can't failover.antirez2015-11-271-1/+3
|
* Lua debugger: infinite loop detection.antirez2015-11-191-7/+35
|
* Lua debugger: fix trace command infinite loop.antirez2015-11-191-5/+6
| | | | Thanks to Itamar Haber for bug report and test case to reproduce.
* Lua debugger: redis-cli: allow restart after end of session.antirez2015-11-191-1/+3
|
* Lua debugger: redis-cli can restart Lua debugging sessions.antirez2015-11-191-44/+74
|
* Lua debugger: maxlen command implemented.antirez2015-11-192-14/+55
| | | | Let the user control the replies truncation.
* Lua debugger: trace command implemented.antirez2015-11-191-0/+24
|
* Lua debugger: redis-cli: show compile errors in LDB mode.antirez2015-11-191-3/+12
|
* Lua debugger: print without args show all local vars.antirez2015-11-191-5/+34
|
* Lua debugger: default behavior of "list" command changed.antirez2015-11-191-4/+14
| | | | | | Now it lists code around the current position by default. Can list any other part using other arguments, but a new "whole" command was added in order to show the whole source code easily.
* Lua debugger: redis-cli error when --ldb is without --eval.antirez2015-11-191-0/+7
| | | | | Otherwise the result is a messed CLI without prompt. Thanks to Itamar Haber for reporting this issue.
View Lorry Controller Status