summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
...
| * Fix typo in redis.hxuxiang2014-09-291-1/+1
| | | | | | | | Closes #1386
| * Fix typosAaron Rutkovsky2014-09-292-5/+5
| | | | | | | | Closes #1513
| * Fix typo: ad -> andJan-Erik Rediger2014-09-291-2/+2
| | | | | | | | Closes #1537
| * Fix typoJuarez Bochi2014-09-291-1/+1
| | | | | | | | Closes #1682
| * Fix incorrect commentszionwu2014-09-292-2/+2
| | | | | | | | | | | | error != success; and 0 != number of bytes written Closes #1806
| * Fix many small typosJan-Erik Rediger2014-09-291-12/+12
| | | | | | | | Closes #1871
| * Remove surplus double quotesLynn2014-09-291-1/+1
| | | | | | | | Closes #1877
* | INCR: Modify incremented object in-place when possible.antirez2014-10-031-5/+15
|/ | | | | | | | | However we don't try to do this if the integer is already inside a range representable with a shared integer. The performance gain appears to be around ~15% in micro benchmarks, however in the long run this also helps to improve locality, so should have more, hard to measure, benefits.
* redis-trib should not abort easily on connection issues.antirez2014-09-261-2/+7
|
* DEBUG POPULATE two args form implemented.antirez2014-09-251-2/+4
| | | | | | | | | | | | | | | | | | | The old DEBUG POPULATE form for automatic creation of test keys is: DEBUG POPULATE <count> Now an additional form is available: DEBUG POPULATE <count> <prefix> When prefix is not specified, it defaults to "key", so the keys are named incrementally from key:0 to key:<count-1>. Otherwise the specified prefix is used instead of "key". The command is useful in order to populate different Redis instances with key names guaranteed to don't collide. There are other debugging uses, for example it is possible to add additional N keys using a count of N and a random prefix at every call.
* anetPeerToString(): make unix sockets distinguishable.antirez2014-09-181-1/+1
| | | | | | | | Following the CLIENT LIST output format, we prefix the unix socket address with a "/" so that it is different than an IPv4/6 address. This makes parsing simpler. Related to #2010.
* anetPeerToString() refactoring and more explicit checks.antirez2014-09-181-8/+19
| | | | Related to PR #2010.
* Unix domain sockets incorrectly listed as IPv6.Yossi Gottlieb2014-09-181-1/+4
|
* Cluster: claim ping_sent time even if we can't connect.antirez2014-09-171-0/+6
| | | | | | | | | | This fixes a potential bug that was never observed in practice since what happens is that the asynchronous connect returns ok (to fail later, calling the handler) every time, so a ping is queued, and sent_ping happens to always be populated. Howver technically connect(2) with a non blocking socket may return an error synchronously, so before this fix the code was not correct.
* Cluster: new option to work with partial slots coverage.antirez2014-09-175-6/+27
|
* Seek at the end of AOF after truncate call.antirez2014-09-161-3/+10
| | | | | | | It is not clear if files open in append only mode will automatically fix their offset after a truncate(2) operation. This commit makes sure that we reposition the AOF file descriptor offset at the end of the file after a truncated AOF is loaded and trimmed to the last valid command.
* On AOF end of file, truncate the AOF to last valid command.antirez2014-09-161-3/+16
| | | | | | | | | | | Recently we introduced the ability to load truncated AOFs, but unfortuantely the support was broken since the server, after loading the truncated AOF, continues appending to the file that is corrupted at the end. The problem is fixed only in the next AOF rewrite. This commit fixes the issue by truncating the AOF to the last valid opcode, and aborting if it is not possible to truncate the file correctly.
* Don't propagate SAVE.antirez2014-09-161-0/+1
| | | | | | This is a general fix (check that dirty delta is positive) but actually should have as the only effect fixing the SAVE propagation to AOF and slaves.
* Sentinel sentinelGetLeader() top comment improved.antirez2014-09-111-3/+3
|
* Sentinel: fix computation of total number of votes.antirez2014-09-111-2/+2
| | | | | | | | | | | The code to check the number of voters was never updated to follow the new Sentinel specification, so the number of voters was computed using only the set of Sentinels that provided a vote. This means that there is a changing majority on partitions, even if usually the issue is not triggered because of the configured quorum check (what was broken was the other implicit check that requires anyway half of the known sentinels to agree in order to start a failover).
* luaRedisGenericCommand() cached argv handling simplified.antirez2014-09-101-4/+2
| | | | As discussed in issue #1945.
* Limit the *SCAN command `dictScan` iterationsxiaost2014-09-091-1/+8
| | | | | *SCAN will cause redis server to hang for seconds after millions of keys was deleted by SCAN/DEL pairs
* Make aof-load-truncated option actually configurable.antirez2014-09-081-1/+14
|
* Correct cleanup when aborting AOF loading.antirez2014-09-081-8/+29
| | | | | | | Because of the new ability to start with a truncated AOF, we need to correctly release all the memory on EOF error. Otherwise there is a small leak, that is not really a problem, but causes a false positive in the tests that detect memory leaks.
* AOF ability to load truncated files.antirez2014-09-083-3/+14
|
* AOF loading: split handling of format errors from unexpected EOF.antirez2014-09-081-7/+10
|
* Merge branch 'unstable' of github.com:/antirez/redis into unstableantirez2014-09-041-5/+5
|\
| * Return empty string if GETRANGE of empty stringMatt Stancliff2014-09-021-1/+1
| | | | | | | | | | | | | | Previously, GETRANGE of a key containing nothing ("") would allocate a large (size_t)-1 return value causing crashes on 32bit builds when it tried to allocate the 4 GB return string.
| * Increase size of range request in getrangeMatt Stancliff2014-09-021-4/+4
| | | | | | | | | | | | | | | | | | | | 32 bit builds don't have a big enough long to capture the same range as a 64 bit build. If we use "long long" we get proper size limits everywhere. Also updates size of unsigned comparison to fit new size of `end`. Fixes #1981
* | Sentinel: don't set announce-ip if is empty.antirez2014-09-041-1/+2
| |
* | Sentinel: announce ip/port changes + rewrite.antirez2014-09-042-19/+35
| | | | | | | | | | | | The original implementation was modified in order to allow to selectively announce a different IP or port, and to rewrite the two options in the config file after a rewrite.
* | sentinel: Decouple bind address from address sent to other sentinelsDara Kong2014-09-041-3/+24
|/ | | | | | | There are instances such as EC2 where the bind address is private (behind a NAT) and cannot be accessible from WAN. https://groups.google.com/d/msg/redis-db/PVVvjO4nMd0/P3oWC036v3cJ
* Sentinel: Abort Hello quicker if not connectedMatt Stancliff2014-09-011-1/+2
| | | | | We can save a little work by aborting when we enter the function if we're disconnected.
* Store the length of the static argv when first allocated.Paddy Byers2014-09-011-0/+1
|
* Fix dictRehash assert casting type.antirez2014-08-261-1/+1
| | | | Also related to #1929.
* Cast to right type in dictNext().antirez2014-08-261-1/+1
| | | | This closes issue #1929, the other part was fixed in the context of issue
* Use long for rehash and iterator index in dict.h.antirez2014-08-261-3/+5
| | | | | | | | This allows to support datasets with more than 2 billion of keys (possible in very large memory instances, this bug was actually reported). Closes issue #1814.
* Use modern typedef form in cluster.h.antirez2014-08-251-5/+4
|
* No longer useful assert removed from sdsIncrLen().antirez2014-08-251-1/+0
|
* Merge branch '1906-merge' into unstableantirez2014-08-2534-185/+323
|\
| * Fix redis-benchmark abort output1906-mergeMatt Stancliff2014-08-251-1/+1
| |
| * Deny CLIENT command in scriptsMatt Stancliff2014-08-251-1/+1
| | | | | | | | | | | | | | | | | | | | We don't want scripts doing CLIENT SETNAME or CLIENT KILL or CLIENT LIST or CLIENT PAUSE. Originally reported by Chris Wj then proper action inspired by Itamar Haber. Reference: https://groups.google.com/forum/#!topic/redis-db/09B2EYwyVgk
| * redis-benchmark: Remove unused bufferMatt Stancliff2014-08-251-9/+0
| | | | | | | | | | | | | | | | | | | | This just deletes old code that didn't get removed when logic changed. We were setting offsets that never got read anywhere. Since clients are now just cloned, we don't need to track per-client buffer offsets anywhere because they are all the same from the original client.
| * redis-benchmark: add auth optionCharSyam2014-08-251-0/+14
| | | | | | | | Closes #1097
| * Rename two 'buf' vars to 'ip' for better clarityMatt Stancliff2014-08-251-5/+5
| | | | | | | | | | Clearly ip[32] is wrong, but it's less clear that buf[32] was wrong without further reading.
| * Sentinel: fix bufsize to support IPv6 addressEiichi Sato2014-08-251-2/+2
| | | | | | | | Closes #1914
| * Sentinel: Reject config from STDINMatt Stancliff2014-08-251-0/+7
| | | | | | | | | | | | | | Sentinel needs to die with a more accurate error message when attempted to open a config from STDIN. See: https://groups.google.com/forum/#!topic/redis-db/sYx7VNMWaNM
| * Cluster: Fix segfault if cluster config corruptMatt Stancliff2014-08-251-3/+7
| | | | | | | | | | | | | | | | | | | | | | This commit adds a size check after initial config line parsing to make sure we have *at least* 8 arguments per line. Also, instead of asserting for cluster->myself, we just test and error out normally (since the error does a hard exit anyway). Closes #1597
| * Fix memory leak in cluster config parsingMatt Stancliff2014-08-181-0/+1
| | | | | | | | | | | | The continue stop us from triggering the free after the long line for loop, so add it earlier.
| * Remove unused global variableMatt Stancliff2014-08-181-1/+0
| | | | | | | | It has an important name, but nothing uses it...