summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
...
* | | redis-benchmark: new option to show server errors on stdout.antirez2016-07-121-1/+17
| | | | | | | | | | | | | | | Disabled by default, can be activated with -e. Maybe the reverse was more safe but departs from the past behavior.
* | | Remove useless memmove() from freeMemoryIfNeeded().antirez2016-07-111-7/+2
| | | | | | | | | | | | | | | | | | We start from the end of the pool to the initial item, zero-ing every entry we use or every ghost entry, there is nothing to memmove since to the right everything should be already set to NULL.
* | | redis_check_rdb(): the rio structure must be global.antirez2016-07-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | The rio structure is referenced in the global 'riostate' structure in order for the logging functions to be always able to access the state of the "pseudo-loading" of the RDB, needed for the check. Courtesy of Valgrind.
* | | redis_check_rdb_main(): create shared objects only if needed.antirez2016-07-061-1/+5
| | | | | | | | | | | | | | | Otherwise Valgrind will complain a memory leak under certain tests where RDB checking is invoked from within Redis.
* | | Fix redis_check_rdb() return value.antirez2016-07-061-2/+3
| | |
* | | Remove dead code from geohash_helper.c.antirez2016-07-061-6/+0
| | | | | | | | | | | | | | | The function removed also had potential bugs related to signess of the expression, and is not used anyway.
* | | Fix signess issue in geohashEstimateStepsByRadius().antirez2016-07-061-1/+2
| | |
* | | Fix definition of M_PI in geohash_helper.c.antirez2016-07-062-1/+2
| | | | | | | | | | | | Without the right feature macros M_PI is not defined in math.h.
* | | geohash.c and geohash_helper.c are part of Redis.antirez2016-07-065-6/+686
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | They were under /deps since they originate from a different source tree, however at this point they are very modified and we took ownership of both the files making changes, fixing bugs, so there is no upgrade path from the original code tree. Given that, better to move the code under /src with proper dependencies and with a more simpler editing experience.
* | | Add expire.c and evict.c.antirez2016-07-062-0/+718
| | |
* | | Expire and LRU related code moved into different files.antirez2016-07-065-633/+4
| | |
* | | Makefile: don't build dependencies file for clean, distclean.antirez2016-07-061-0/+3
| | |
* | | Generate Makefile.dep at every build.antirez2016-07-062-194/+5
| | | | | | | | | | | | | | | Normally we used to update it from time to time. Too fragile... better to generate dependencies at every run and delete them on 'make clean'.
* | | getLongLongFromObject: use string2ll() instead of strict_strtoll().antirez2016-07-061-15/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | strict_strtoll() has a bug that reports the empty string as ok and parses it as zero. Apparently nobody ever replaced this old call with the faster/saner string2ll() which is used otherwise in the rest of the Redis core. This commit close #3333.
* | | redis-cli: check SELECT reply type just in state updated.antirez2016-07-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In issues #3361 / #3365 a problem was reported / fixed with redis-cli not updating correctly the current DB on error after SELECT. In theory this bug was fixed in 0042fb0e, but actually the commit only fixed the prompt updating, not the fact the state was set in a wrong way. This commit removes the check in the prompt update, now that hopefully it is the state that is correct, there is no longer need for this check.
* | | Merge pull request #3365 from sskorgal/unstableSalvatore Sanfilippo2016-07-051-1/+1
|\ \ \ | | | | | | | | Fix for redis_cli printing default DB when select command fails. #3361
| * | | Fix for redis_cli printing default DB when select command fails.sskorgal2016-07-011-1/+1
| | |/ | |/|
* | | Sentinel: fix cross-master Sentinel address update.antirez2016-07-041-2/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit both fixes the crash reported with issue #3364 and also properly closes the old links after the Sentinel address for the other masters gets updated. The two problems where: 1. The Sentinel that switched address may not monitor all the masters, it is possible that there is no match, and the 'match' variable is NULL. Now we check for no match and 'continue' to the next master. 2. By ispecting the code because of issue "1" I noticed that there was a problem in the code that disconnects the link of the Sentinel that needs the address update. Basically link->disconnected is non-zero even if just *a single link* (cc -- command link or pc -- pubsub link) are disconnected, so to check with if (link->disconnected) in order to close the links risks to leave one link connected. I was able to manually reproduce the crash at "1" and verify that the commit resolves the issue. Close #3364.
* | | CONFIG GET is now no longer case sensitive.antirez2016-07-041-12/+12
| | | | | | | | | | | | Like CONFIG SET always was. Close #3369.
* | | Make tcp-keepalive default to 300 in internal conf.antirez2016-07-041-1/+1
| | | | | | | | | | | | | | | We already changed the default in the redis.conf template, but I forgot to change the internal config as well.
* | | In Redis RDB check: more details in error reportings.rdb-checkantirez2016-07-011-13/+21
| | |
* | | In Redis RDB check: log decompression errors.antirez2016-07-012-2/+23
| | |
* | | In Redis RDB check: log object type on error.antirez2016-07-011-2/+27
| | |
* | | In Redis RDB check: minor output message changes.antirez2016-07-011-1/+4
| | |
* | | In Redis RDB check: better error reporting.antirez2016-07-014-14/+71
| | |
* | | In Redis RDB check: initial POC.antirez2016-06-302-660/+189
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | So far we used an external program (later executed within Redis) and parser in order to check RDB files for correctness. This forces, at each RDB format update, to have two copies of the same format implementation that are hard to keep in sync. Morover the former RDB checker only checked the very high-level format of the file, without actually trying to load things in memory. Certain corruptions can only be handled by really loading key-value pairs. This first commit attempts to unify the Redis RDB loadig code with the task of checking the RDB file for correctness. More work is needed but it looks like a sounding direction so far.
* | Merge branch 'unstable' of github.com:/antirez/redis into unstableantirez2016-06-272-2/+2
|\ \
| * | Fix RedisModule_Calloc() definition typo.Yossi Gottlieb2016-06-231-1/+1
| |/
| * Merge pull request #3324 from mishan/fix-wrong-comment-about-sentinel-modeSalvatore Sanfilippo2016-06-231-1/+1
| |\ | | | | | | Fix incorrect comment for checkForSentinelMode function
| | * Fix incorrect comment for checkForSentinelMode functionMisha Nasledov2016-06-161-1/+1
| | |
* | | Fix quicklistReplaceAtIndex() by updating the quicklist ziplist size.antirez2016-06-271-0/+1
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The quicklist takes a cached version of the ziplist representation size in bytes. The implementation must update this length every time the underlying ziplist changes. However quicklistReplaceAtIndex() failed to fix the length. During LSET calls, the size of the ziplist blob and the cached size inside the quicklist diverged. Later, when this size is used in an authoritative way, for example during nodes splitting in order to copy the nodes, we end with a duplicated node that may contain random garbage. This commit should fix issue #3343, however several problems were found reviewing the quicklist.c code in search of this bug that should be addressed soon or later. For example: 1. To take a cached ziplist length is fragile since failing to update it leads to this kind of issues. 2. The node splitting code needs auditing. For example it works just for a side effect of ziplistDeleteRange() to be able to cope with a wrong count of elements to remove. The code inside quicklist.c assumes that -1 means "delete till the end" while actually it's just a count of how many elements to delete, and is an unsigned count. So -1 gets converted into the maximum integer, and just by chance the ziplist code stops deleting elements after there are no more to delete. 3. Node splitting is extremely inefficient, it copies the node and removes elements from both nodes even when actually there is to move a single entry from one node to the other, or when the new resulting node is empty at all so there is nothing to copy but just to create a new node. However at least for Redis 3.2 to introduce fresh code inside quicklist.c may be even more risky, so instead I'm writing a better fuzzy tester to stress the internals a bit more in order to anticipate other possible bugs. This bug was found using a fuzzy tester written after having some clue about where the bug could be. The tester eventually created a ~2000 commands sequence able to always crash Redis. I wrote a better version of the tester that searched for the smallest sequence that could crash Redis automatically. Later this smaller sequence was minimized by removing random commands till it still crashed the server. This resulted into a sequence of 7 commands. With this small sequence it was just a matter of filling the code with enough printf() to understand enough state to fix the bug.
* | Modules: mention RedisModule_Calloc() in the doc.antirez2016-06-231-0/+1
| |
* | Merge pull request #3335 from dvirsky/rm_callocSalvatore Sanfilippo2016-06-232-1/+13
|\ \ | | | | | | added RM_Calloc implementation
| * | added RM_Calloc implementationDvir Volk2016-06-222-1/+13
| | |
* | | Merge branch 'unstable' of github.com:/antirez/redis into unstableantirez2016-06-235-2/+26
|\ \ \
| * \ \ Merge pull request #3336 from yossigo/create_string_from_stringSalvatore Sanfilippo2016-06-235-2/+26
| |\ \ \ | | | | | | | | | | Add RedisModule_CreateStringFromString().
| | * | | Add RedisModule_CreateStringFromString().Yossi Gottlieb2016-06-225-2/+26
| | | | |
* | | | | Actually remove static from #3331.antirez2016-06-231-2/+1
|/ / / / | | | | | | | | | | | | I forgot -a when amending in the previous commit.
* | | | Minor change to conform PR #3331 to Redis code base style.antirez2016-06-231-2/+1
| | | | | | | | | | | | | | | | Also avoid "static" in order to have symbols during crashes.
* | | | Merge pull request #3331 from yossigo/fix_openkey_crashSalvatore Sanfilippo2016-06-231-6/+13
|\ \ \ \ | | | | | | | | | | Fix occasional RM_OpenKey() crashes.
| * | | | Cleanup: remove zset reset function from RM_ZsetRangeStop().Yossi Gottlieb2016-06-221-7/+13
| | | | |
| * | | | Fix occasional RM_OpenKey() crashes.Yossi Gottlieb2016-06-211-0/+1
| | |/ / | |/| |
* | | | A string with 21 chars is not representable as a 64-bit integer.tielei2016-06-231-2/+2
| | | |
* | | | Merge pull request #3330 from yossigo/fix_constSalvatore Sanfilippo2016-06-2313-38/+38
|\ \ \ \ | | | | | | | | | | Use const in Redis Module API where possible.
| * | | | Use const in Redis Module API where possible.Yossi Gottlieb2016-06-2013-38/+38
| |/ / /
* | | | Modules: changes to logging function.antirez2016-06-233-19/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit changes what provided by PR #3315 (merged) in order to let the user specify the log level as a string. The define could be also used, but when this happens, they must be decoupled from the defines in the Redis core, like in the other part of the Redis modules implementations, so that a switch statement (or a function) remaps between the two, otherwise we are no longer free to change the internal Redis defines.
* | | | Add RedisModule_Log() logging API function.Yossi Gottlieb2016-06-233-0/+42
| | | |
* | | | Commit change in autoMemoryFreed(): first -> last.antirez2016-06-231-1/+2
| | | | | | | | | | | | | | | | | | | | It's more natural to call the last entry added as "last", the original commet got me confused until I actually read the code.
* | | | Modules: implement zig-zag scanning in autoMemoryFreed().antirez2016-06-231-16/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Most of the time to check the last element is the way to go, however there are patterns where the contrary is the best choice. Zig-zag scanning implemented in this commmit always checks the obvious element first (the last added -- think at a loop where the last element allocated gets freed again and again), and continues checking one element in the head and one in the tail. Thanks to @dvisrky that fixed the original implementation of the function and proposed zig zag scanning.
* | | | Merge pull request #3244 from dvirsky/optimize_autoMemoryFreedSalvatore Sanfilippo2016-06-231-4/+12
|\ \ \ \ | |_|/ / |/| | | Optimized autoMemoryFreed loop
View Lorry Controller Status